[meta-oe] faad2: Upgrade 2.10.0 -> 2.10.1

Update faad2 to latest 2.10.1 release. Use SRCREV matching tag 2.10.1 .

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alex Kiernan <alex.kiernan@gmail.com>
Cc: Khem Raj <raj.khem@gmail.com>
---
 .../faad2/{faad2_2.10.0.bb => faad2_2.10.1.bb}                  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta-oe/recipes-multimedia/faad2/{faad2_2.10.0.bb => faad2_2.10.1.bb} (88%)

seeing this

make[2]: *** No rule to make target '../../git/include/faad.h', needed
by 'all-am'.  Stop.
make[2]: *** Waiting for unfinished jobs....

https://errors.yoctoproject.org/Errors/Details/739273/

is it some sort of race ?

On Tue, Oct 3, 2023 at 1:58 PM Marek Vasut <marex@denx.de> wrote:
>
> Update faad2 to latest 2.10.1 release. Use SRCREV matching tag 2.10.1 .
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alex Kiernan <alex.kiernan@gmail.com>
> Cc: Khem Raj <raj.khem@gmail.com>
> ---
>  .../faad2/{faad2_2.10.0.bb => faad2_2.10.1.bb}                  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  rename meta-oe/recipes-multimedia/faad2/{faad2_2.10.0.bb => faad2_2.10.1.bb} (88%)
>
> diff --git a/meta-oe/recipes-multimedia/faad2/faad2_2.10.0.bb b/meta-oe/recipes-multimedia/faad2/faad2_2.10.1.bb
> similarity index 88%
> rename from meta-oe/recipes-multimedia/faad2/faad2_2.10.0.bb
> rename to meta-oe/recipes-multimedia/faad2/faad2_2.10.1.bb
> index 1b4236073..5d54dcfe1 100644
> --- a/meta-oe/recipes-multimedia/faad2/faad2_2.10.0.bb
> +++ b/meta-oe/recipes-multimedia/faad2/faad2_2.10.1.bb
> @@ -10,7 +10,7 @@ LICENSE_FLAGS = "commercial"
>  PV .= "+git${SRCPV}"
>
>  SRC_URI = "git://github.com/knik0/faad2.git;branch=master;protocol=https"
> -SRCREV = "df42c6fc018552519d140e3d8ffe7046ed48b0cf"
> +SRCREV = "3918dee56063500d0aa23d6c3c94b211ac471a8c"
>
>  S = "${WORKDIR}/git"
>
> --
> 2.40.1
>

I looked at the changes in master since 2.10 and most of them are
bugfixes, but one big change is switch away from autotools to cmake
so it might be worth to get all fixes and switch to cmake in recipe
for master instead of trying to fix the dependency issues to generate
faad.h
since we run autoreconf this might be messing up with bootstrap code
of this package.

On Wed, Oct 4, 2023 at 1:06 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> seeing this
>
> make[2]: *** No rule to make target '../../git/include/faad.h', needed
> by 'all-am'.  Stop.
> make[2]: *** Waiting for unfinished jobs....
>
> https://errors.yoctoproject.org/Errors/Details/739273/
>
> is it some sort of race ?
>
> On Tue, Oct 3, 2023 at 1:58 PM Marek Vasut <marex@denx.de> wrote:
> >
> > Update faad2 to latest 2.10.1 release. Use SRCREV matching tag 2.10.1 .
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Alex Kiernan <alex.kiernan@gmail.com>
> > Cc: Khem Raj <raj.khem@gmail.com>
> > ---
> >  .../faad2/{faad2_2.10.0.bb => faad2_2.10.1.bb}                  | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >  rename meta-oe/recipes-multimedia/faad2/{faad2_2.10.0.bb => faad2_2.10.1.bb} (88%)
> >
> > diff --git a/meta-oe/recipes-multimedia/faad2/faad2_2.10.0.bb b/meta-oe/recipes-multimedia/faad2/faad2_2.10.1.bb
> > similarity index 88%
> > rename from meta-oe/recipes-multimedia/faad2/faad2_2.10.0.bb
> > rename to meta-oe/recipes-multimedia/faad2/faad2_2.10.1.bb
> > index 1b4236073..5d54dcfe1 100644
> > --- a/meta-oe/recipes-multimedia/faad2/faad2_2.10.0.bb
> > +++ b/meta-oe/recipes-multimedia/faad2/faad2_2.10.1.bb
> > @@ -10,7 +10,7 @@ LICENSE_FLAGS = "commercial"
> >  PV .= "+git${SRCPV}"
> >
> >  SRC_URI = "git://github.com/knik0/faad2.git;branch=master;protocol=https"
> > -SRCREV = "df42c6fc018552519d140e3d8ffe7046ed48b0cf"
> > +SRCREV = "3918dee56063500d0aa23d6c3c94b211ac471a8c"
> >
> >  S = "${WORKDIR}/git"
> >
> > --
> > 2.40.1
> >

On 10/5/23 00:36, Khem Raj wrote:
> I looked at the changes in master since 2.10 and most of them are
> bugfixes, but one big change is switch away from autotools to cmake
> so it might be worth to get all fixes and switch to cmake in recipe
> for master instead of trying to fix the dependency issues to generate
> faad.h
> since we run autoreconf this might be messing up with bootstrap code
> of this package.

I also noticed that 2.11 is about to be released, so I'll send 2.11 with 
cmake when its out.

On Wed, Oct 4, 2023 at 7:22 PM Marek Vasut <marex@denx.de> wrote:
>
> On 10/5/23 00:36, Khem Raj wrote:
> > I looked at the changes in master since 2.10 and most of them are
> > bugfixes, but one big change is switch away from autotools to cmake
> > so it might be worth to get all fixes and switch to cmake in recipe
> > for master instead of trying to fix the dependency issues to generate
> > faad.h
> > since we run autoreconf this might be messing up with bootstrap code
> > of this package.
>
> I also noticed that 2.11 is about to be released, so I'll send 2.11 with
> cmake when its out.

sounds good. here is patch I was playing with :)
https://snips.sh/f/jbQFo4Oitx