| Message ID | 20230816063717.3305497-1-ewa.kujawska@3mdeb.com |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [meta-python] recipes-devtools/python/python3-libusb1_1.7.1.bb: recipe added | expand |
Hi Ewa Thanks for your patches I see subject field is not as recommended please read through this guide which is handy to find out submitting guidelines https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded rest of comments are inline. On 8/15/23 11:36 PM, Ewa Kujawska wrote: > --- > .../python/python3-libusb1_1.7.1.bb | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 meta-python/recipes-devtools/python/python3-libusb1_1.7.1.bb > > diff --git a/meta-python/recipes-devtools/python/python3-libusb1_1.7.1.bb b/meta-python/recipes-devtools/python/python3-libusb1_1.7.1.bb > new file mode 100644 > index 000000000000..476966c2178b > --- /dev/null > +++ b/meta-python/recipes-devtools/python/python3-libusb1_1.7.1.bb > @@ -0,0 +1,15 @@ > +SUMMARY = "Pure-python wrapper for libusb-1.0" > +HOMEPAGE = "http://github.com/vpelletier/python-libusb1" > +AUTHOR = "Vincent Pelletier <plr.vincent@gmail.com>" Drop setting AUTHOR, its unused > +LICENSE = "LGPL-2.1" Please use SPDX strings for LICENSE > +LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe" > + > +SRC_URI = "https://files.pythonhosted.org/packages/80/bb/4ee9d760dd29499d877ee384f1d2bc6bb9923defd4c69843aef5e729972d/libusb1-1.7.1.tar.gz" Try to use bitbake variables as much as possible. E.g. PV instead of 1.7.1 here > +SRC_URI[md5sum] = "cb4073182fef4cee6ab9c6666b48d1a1" Drop setting md5sum, its not needed anymore. > +SRC_URI[sha256sum] = "adf64a4f3f5c94643a1286f8153bcf4bc787c348b38934aacd7fe17fbeebc571" > + > +S = "${WORKDIR}/libusb1-1.7.1" > + Use PV instead of harding 1.7.1 > +RDEPENDS_${PN} = "libusb1" Override separator is ':' and not '_' anymore, this makes me wonder if this patch was tested against master or not. > + > +inherit setuptools3 > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#104413): https://lists.openembedded.org/g/openembedded-devel/message/104413 > Mute This Topic: https://lists.openembedded.org/mt/100774686/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-python/recipes-devtools/python/python3-libusb1_1.7.1.bb b/meta-python/recipes-devtools/python/python3-libusb1_1.7.1.bb new file mode 100644 index 000000000000..476966c2178b --- /dev/null +++ b/meta-python/recipes-devtools/python/python3-libusb1_1.7.1.bb @@ -0,0 +1,15 @@ +SUMMARY = "Pure-python wrapper for libusb-1.0" +HOMEPAGE = "http://github.com/vpelletier/python-libusb1" +AUTHOR = "Vincent Pelletier <plr.vincent@gmail.com>" +LICENSE = "LGPL-2.1" +LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe" + +SRC_URI = "https://files.pythonhosted.org/packages/80/bb/4ee9d760dd29499d877ee384f1d2bc6bb9923defd4c69843aef5e729972d/libusb1-1.7.1.tar.gz" +SRC_URI[md5sum] = "cb4073182fef4cee6ab9c6666b48d1a1" +SRC_URI[sha256sum] = "adf64a4f3f5c94643a1286f8153bcf4bc787c348b38934aacd7fe17fbeebc571" + +S = "${WORKDIR}/libusb1-1.7.1" + +RDEPENDS_${PN} = "libusb1" + +inherit setuptools3