| Message ID | 20240205125829.152301-1-dev@g0hl1n.net |
|---|---|
| Headers | show |
| Series | Add python3-httpx support | expand |
On Mon, Feb 5, 2024 at 4:58 AM Richard Leitner via lists.openembedded.org <dev=g0hl1n.net@lists.openembedded.org> wrote: > This series adds support for python3-httpx and its dependencies. > > Can you look into adding ptest also for these new packages? It doesn't necessarily block adding them, but we don't want to keep piling on technical debt of more recipes without ptest. > Richard Leitner (5): > python3-socksio: add recipe for v1.0.0 > python3-anyio: add recipe for v4.2.0 > python3-sniffio: add recipe for v1.3.0 > python3-httpcore: add recipe for v1.0.2 > python3-httpx: add recipe for v0.26.0 > > .../python/python3-anyio_4.2.0.bb | 23 ++++++++++ > .../python/python3-httpcore_1.0.2.bb | 26 +++++++++++ > .../python/python3-httpx_0.26.0.bb | 44 +++++++++++++++++++ > .../python/python3-sniffio_1.3.0.bb | 12 +++++ > .../0001-Unpin-flit-core-dependency.patch | 21 +++++++++ > .../python/python3-socksio_1.0.0.bb | 10 +++++ > 6 files changed, 136 insertions(+) > create mode 100644 meta-python/recipes-devtools/python/ > python3-anyio_4.2.0.bb > create mode 100644 meta-python/recipes-devtools/python/ > python3-httpcore_1.0.2.bb > create mode 100644 meta-python/recipes-devtools/python/ > python3-httpx_0.26.0.bb > create mode 100644 meta-python/recipes-devtools/python/ > python3-sniffio_1.3.0.bb > create mode 100644 > meta-python/recipes-devtools/python/python3-socksio/0001-Unpin-flit-core-dependency.patch > create mode 100644 meta-python/recipes-devtools/python/ > python3-socksio_1.0.0.bb > > -- > 2.40.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#108567): > https://lists.openembedded.org/g/openembedded-devel/message/108567 > Mute This Topic: https://lists.openembedded.org/mt/104175047/924729 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > ticotimo@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Mon, Feb 5, 2024 at 7:55 AM Tim Orling <ticotimo@gmail.com> wrote: > > > > On Mon, Feb 5, 2024 at 4:58 AM Richard Leitner via lists.openembedded.org <dev=g0hl1n.net@lists.openembedded.org> wrote: >> >> This series adds support for python3-httpx and its dependencies. >> > > Can you look into adding ptest also for these new packages? It doesn't necessarily block adding them, but we don't want to keep piling on technical debt of more recipes without ptest. I think this is a good idea. We run ptests for meta-python regularly as acceptance and do find issues these days. So adding ptest would be good here, perhaps for meta-python it could be made a needed thing for new recipes. > >> >> Richard Leitner (5): >> python3-socksio: add recipe for v1.0.0 >> python3-anyio: add recipe for v4.2.0 >> python3-sniffio: add recipe for v1.3.0 >> python3-httpcore: add recipe for v1.0.2 >> python3-httpx: add recipe for v0.26.0 >> >> .../python/python3-anyio_4.2.0.bb | 23 ++++++++++ >> .../python/python3-httpcore_1.0.2.bb | 26 +++++++++++ >> .../python/python3-httpx_0.26.0.bb | 44 +++++++++++++++++++ >> .../python/python3-sniffio_1.3.0.bb | 12 +++++ >> .../0001-Unpin-flit-core-dependency.patch | 21 +++++++++ >> .../python/python3-socksio_1.0.0.bb | 10 +++++ >> 6 files changed, 136 insertions(+) >> create mode 100644 meta-python/recipes-devtools/python/python3-anyio_4.2.0.bb >> create mode 100644 meta-python/recipes-devtools/python/python3-httpcore_1.0.2.bb >> create mode 100644 meta-python/recipes-devtools/python/python3-httpx_0.26.0.bb >> create mode 100644 meta-python/recipes-devtools/python/python3-sniffio_1.3.0.bb >> create mode 100644 meta-python/recipes-devtools/python/python3-socksio/0001-Unpin-flit-core-dependency.patch >> create mode 100644 meta-python/recipes-devtools/python/python3-socksio_1.0.0.bb >> >> -- >> 2.40.1 >> >> >> >> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#108574): https://lists.openembedded.org/g/openembedded-devel/message/108574 > Mute This Topic: https://lists.openembedded.org/mt/104175047/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Mon, Feb 5, 2024 at 9:44 AM Khem Raj <raj.khem@gmail.com> wrote: > On Mon, Feb 5, 2024 at 7:55 AM Tim Orling <ticotimo@gmail.com> wrote: > > > > > > > > On Mon, Feb 5, 2024 at 4:58 AM Richard Leitner via > lists.openembedded.org <dev=g0hl1n.net@lists.openembedded.org> wrote: > >> > >> This series adds support for python3-httpx and its dependencies. > >> > > > > Can you look into adding ptest also for these new packages? It doesn't > necessarily block adding them, but we don't want to keep piling on > technical debt of more recipes without ptest. > > I think this is a good idea. We run ptests for meta-python regularly > as acceptance and do find issues these days. So adding ptest would > be good here, perhaps for meta-python it could be made a needed thing > for new recipes. > I am definitely leaning in that direction, but I also know that some of the dependency trees get very deep very quickly. This is one of the reasons I have wished for recursive "devtool add", but that is an entirely different topic. > > > > >> > >> Richard Leitner (5): > >> python3-socksio: add recipe for v1.0.0 > >> python3-anyio: add recipe for v4.2.0 > >> python3-sniffio: add recipe for v1.3.0 > >> python3-httpcore: add recipe for v1.0.2 > >> python3-httpx: add recipe for v0.26.0 > >> > >> .../python/python3-anyio_4.2.0.bb | 23 ++++++++++ > >> .../python/python3-httpcore_1.0.2.bb | 26 +++++++++++ > >> .../python/python3-httpx_0.26.0.bb | 44 +++++++++++++++++++ > >> .../python/python3-sniffio_1.3.0.bb | 12 +++++ > >> .../0001-Unpin-flit-core-dependency.patch | 21 +++++++++ > >> .../python/python3-socksio_1.0.0.bb | 10 +++++ > >> 6 files changed, 136 insertions(+) > >> create mode 100644 meta-python/recipes-devtools/python/ > python3-anyio_4.2.0.bb > >> create mode 100644 meta-python/recipes-devtools/python/ > python3-httpcore_1.0.2.bb > >> create mode 100644 meta-python/recipes-devtools/python/ > python3-httpx_0.26.0.bb > >> create mode 100644 meta-python/recipes-devtools/python/ > python3-sniffio_1.3.0.bb > >> create mode 100644 > meta-python/recipes-devtools/python/python3-socksio/0001-Unpin-flit-core-dependency.patch > >> create mode 100644 meta-python/recipes-devtools/python/ > python3-socksio_1.0.0.bb > >> > >> -- > >> 2.40.1 > >> > >> > >> > >> > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#108576): > https://lists.openembedded.org/g/openembedded-devel/message/108576 > Mute This Topic: https://lists.openembedded.org/mt/104175047/924729 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > ticotimo@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
Hi Tim, Hi Khem, thanks for your feedback! On Mon, Feb 05, 2024 at 09:44:28AM -0800, Khem Raj wrote: > On Mon, Feb 5, 2024 at 7:55 AM Tim Orling <ticotimo@gmail.com> wrote: > > > > > > > > On Mon, Feb 5, 2024 at 4:58 AM Richard Leitner via lists.openembedded.org <dev=g0hl1n.net@lists.openembedded.org> wrote: > >> > >> This series adds support for python3-httpx and its dependencies. > >> > > > > Can you look into adding ptest also for these new packages? It doesn't necessarily block adding them, but we don't want to keep piling on technical debt of more recipes without ptest. > > I think this is a good idea. We run ptests for meta-python regularly > as acceptance and do find issues these days. So adding ptest would > be good here, perhaps for meta-python it could be made a needed thing > for new recipes. Sure. I will add them. Basically I totally agree on adding tests wherever possible. So from my side making them a requirement (unless there is a really good reason against) would be a good thing. Should I send a v2 or a separate series for that? As we are talking about "defaults" for python recipes. What is the "policy" for native and nativesdk? Is there any? Or should they be just added based on user needs/gut feeling? regards;rl > > > > >> > >> Richard Leitner (5): > >> python3-socksio: add recipe for v1.0.0 > >> python3-anyio: add recipe for v4.2.0 > >> python3-sniffio: add recipe for v1.3.0 > >> python3-httpcore: add recipe for v1.0.2 > >> python3-httpx: add recipe for v0.26.0 > >> > >> .../python/python3-anyio_4.2.0.bb | 23 ++++++++++ > >> .../python/python3-httpcore_1.0.2.bb | 26 +++++++++++ > >> .../python/python3-httpx_0.26.0.bb | 44 +++++++++++++++++++ > >> .../python/python3-sniffio_1.3.0.bb | 12 +++++ > >> .../0001-Unpin-flit-core-dependency.patch | 21 +++++++++ > >> .../python/python3-socksio_1.0.0.bb | 10 +++++ > >> 6 files changed, 136 insertions(+) > >> create mode 100644 meta-python/recipes-devtools/python/python3-anyio_4.2.0.bb > >> create mode 100644 meta-python/recipes-devtools/python/python3-httpcore_1.0.2.bb > >> create mode 100644 meta-python/recipes-devtools/python/python3-httpx_0.26.0.bb > >> create mode 100644 meta-python/recipes-devtools/python/python3-sniffio_1.3.0.bb > >> create mode 100644 meta-python/recipes-devtools/python/python3-socksio/0001-Unpin-flit-core-dependency.patch > >> create mode 100644 meta-python/recipes-devtools/python/python3-socksio_1.0.0.bb > >> > >> -- > >> 2.40.1 > >> > >> > >> > >>
On Mon, Feb 5, 2024 at 12:06 PM Richard Leitner <dev@g0hl1n.net> wrote: > Hi Tim, Hi Khem, > > thanks for your feedback! > > On Mon, Feb 05, 2024 at 09:44:28AM -0800, Khem Raj wrote: > > On Mon, Feb 5, 2024 at 7:55 AM Tim Orling <ticotimo@gmail.com> wrote: > > > > > > > > > > > > On Mon, Feb 5, 2024 at 4:58 AM Richard Leitner via > lists.openembedded.org <dev=g0hl1n.net@lists.openembedded.org> wrote: > > >> > > >> This series adds support for python3-httpx and its dependencies. > > >> > > > > > > Can you look into adding ptest also for these new packages? It doesn't > necessarily block adding them, but we don't want to keep piling on > technical debt of more recipes without ptest. > > > > I think this is a good idea. We run ptests for meta-python regularly > > as acceptance and do find issues these days. So adding ptest would > > be good here, perhaps for meta-python it could be made a needed thing > > for new recipes. > > Sure. I will add them. Basically I totally agree on adding tests wherever > possible. So from my side making them a requirement (unless there is a > really good reason against) would be a good thing. > > Should I send a v2 or a separate series for that? > If it turns out to be "straight forward" a v2 is good. but if you get bogged down maybe let us know and khem can just merge as is. > > As we are talking about "defaults" for python recipes. What is the > "policy" for native and nativesdk? Is there any? Or should they be just > added based on user needs/gut feeling? > The trick is that many folks were just adding BBCLASSEXTENDS = "native nativesdk" blindly without ever verifying that those things build. So, if you verify that all your recipes build, you can add it. But if any recipes you depend on do not currently build with "native" or "nativesdk" then you would need to go make all of those also work. For those that don't know: "bitbake -c populate_sdk python3-<foo>" is the syntax to build the nativesdk-python3-<foo> recipe and "bitbake python3-<foo>-native" is the syntax to build the native version. If either of those has missing dependencies, then you either need to fix all the dependent recipes or do not send a patch with it enabled. > > regards;rl > > > > > > > > >> > > >> Richard Leitner (5): > > >> python3-socksio: add recipe for v1.0.0 > > >> python3-anyio: add recipe for v4.2.0 > > >> python3-sniffio: add recipe for v1.3.0 > > >> python3-httpcore: add recipe for v1.0.2 > > >> python3-httpx: add recipe for v0.26.0 > > >> > > >> .../python/python3-anyio_4.2.0.bb | 23 ++++++++++ > > >> .../python/python3-httpcore_1.0.2.bb | 26 +++++++++++ > > >> .../python/python3-httpx_0.26.0.bb | 44 > +++++++++++++++++++ > > >> .../python/python3-sniffio_1.3.0.bb | 12 +++++ > > >> .../0001-Unpin-flit-core-dependency.patch | 21 +++++++++ > > >> .../python/python3-socksio_1.0.0.bb | 10 +++++ > > >> 6 files changed, 136 insertions(+) > > >> create mode 100644 meta-python/recipes-devtools/python/ > python3-anyio_4.2.0.bb > > >> create mode 100644 meta-python/recipes-devtools/python/ > python3-httpcore_1.0.2.bb > > >> create mode 100644 meta-python/recipes-devtools/python/ > python3-httpx_0.26.0.bb > > >> create mode 100644 meta-python/recipes-devtools/python/ > python3-sniffio_1.3.0.bb > > >> create mode 100644 > meta-python/recipes-devtools/python/python3-socksio/0001-Unpin-flit-core-dependency.patch > > >> create mode 100644 meta-python/recipes-devtools/python/ > python3-socksio_1.0.0.bb > > >> > > >> -- > > >> 2.40.1 > > >> > > >> > > >> > > >> >