diff mbox series

[dunfell] populate_sdk_ext.bbclass: only overwrite lsb string if uninative is used

Message ID 20240415072048.2008418-1-timon.bergelt@pm.me
State New
Headers show
Series [dunfell] populate_sdk_ext.bbclass: only overwrite lsb string if uninative is used | expand

Commit Message

Timon Bergelt April 15, 2024, 7:21 a.m. UTC
Overwriting the lsb string without inheriting from uninative causes
shared state cache entries to end up in the wrong path where they are
not beeing picked up by the extensible SDK environment.

Signed-off-by: Timon Bergelt <timon.bergelt@pm.me>
---
 meta/classes/populate_sdk_ext.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Steve Sakoman April 23, 2024, 11:52 a.m. UTC | #1
Dunfell has reached end of life and we are no longer taking changes.
The final build was done on April 15.

Steve

On Mon, Apr 15, 2024 at 12:21 AM Timon Bergelt via
lists.openembedded.org <timon.bergelt=pm.me@lists.openembedded.org>
wrote:
>
> Overwriting the lsb string without inheriting from uninative causes
> shared state cache entries to end up in the wrong path where they are
> not beeing picked up by the extensible SDK environment.
>
> Signed-off-by: Timon Bergelt <timon.bergelt@pm.me>
> ---
>  meta/classes/populate_sdk_ext.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass
> index 1bdfd92847..899f198659 100644
> --- a/meta/classes/populate_sdk_ext.bbclass
> +++ b/meta/classes/populate_sdk_ext.bbclass
> @@ -449,7 +449,7 @@ python copy_buildsystem () {
>      bb.utils.remove(sstate_out, True)
>
>      # uninative.bbclass sets NATIVELSBSTRING to 'universal%s' % oe.utils.host_gcc_version(d)
> -    fixedlsbstring = "universal%s" % oe.utils.host_gcc_version(d)
> +    fixedlsbstring = "universal%s" % oe.utils.host_gcc_version(d) if bb.data.inherits_class('uninative', d) else ""
>
>      sdk_include_toolchain = (d.getVar('SDK_INCLUDE_TOOLCHAIN') == '1')
>      sdk_ext_type = d.getVar('SDK_EXT_TYPE')
> --
> 2.34.1
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#198221): https://lists.openembedded.org/g/openembedded-core/message/198221
> Mute This Topic: https://lists.openembedded.org/mt/105531768/3620601
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [steve@sakoman.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass
index 1bdfd92847..899f198659 100644
--- a/meta/classes/populate_sdk_ext.bbclass
+++ b/meta/classes/populate_sdk_ext.bbclass
@@ -449,7 +449,7 @@  python copy_buildsystem () {
     bb.utils.remove(sstate_out, True)
 
     # uninative.bbclass sets NATIVELSBSTRING to 'universal%s' % oe.utils.host_gcc_version(d)
-    fixedlsbstring = "universal%s" % oe.utils.host_gcc_version(d)
+    fixedlsbstring = "universal%s" % oe.utils.host_gcc_version(d) if bb.data.inherits_class('uninative', d) else ""
 
     sdk_include_toolchain = (d.getVar('SDK_INCLUDE_TOOLCHAIN') == '1')
     sdk_ext_type = d.getVar('SDK_EXT_TYPE')