diff mbox series

[7/9] oeqa/runtime/login: Exclude qemuriscv64

Message ID 20240306162341.2267587-7-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit 7f7032c7613abd62ce510c98211c75fc7c5e7090
Headers show
Series [1/9] qemurunner.py: Fix error on calls to run_monitor | expand

Commit Message

Richard Purdie March 6, 2024, 4:23 p.m. UTC
From: Eilís 'pidge' Ní Fhlannagáin <pidge@baylibre.com>

Excluding riscv64 due to mouse rather than a touchscreen which adds a
moving cursor, so the diff ends up > 0. Need to fix the image to use the
touchscreen rather than mouse input.

Signed-off-by: Eilís 'pidge' Ní Fhlannagáin <pidge@baylibre.com>
---
 meta/lib/oeqa/runtime/cases/login.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Khem Raj March 6, 2024, 6:52 p.m. UTC | #1
On Wed, Mar 6, 2024 at 8:23 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> From: Eilís 'pidge' Ní Fhlannagáin <pidge@baylibre.com>
>
> Excluding riscv64 due to mouse rather than a touchscreen which adds a
> moving cursor, so the diff ends up > 0. Need to fix the image to use the
> touchscreen rather than mouse input.

Is it an option we are using to start the qemu which is causing this issue?
I would like to understand more

>
> Signed-off-by: Eilís 'pidge' Ní Fhlannagáin <pidge@baylibre.com>
> ---
>  meta/lib/oeqa/runtime/cases/login.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oeqa/runtime/cases/login.py b/meta/lib/oeqa/runtime/cases/login.py
> index ac8a0454f38..edbc48ac205 100644
> --- a/meta/lib/oeqa/runtime/cases/login.py
> +++ b/meta/lib/oeqa/runtime/cases/login.py
> @@ -28,7 +28,7 @@ from oeqa.runtime.decorator.package import OEHasPackage
>  class LoginTest(OERuntimeTestCase):
>      @OEHasPackage(['matchbox-desktop'])
>      def test_screenshot(self):
> -        if self.td.get('MACHINE') in ("qemuppc64", "qemuarmv5", "qemuriscv32", "qemuloongarch64"):
> +        if self.td.get('MACHINE') in ("qemuppc64", "qemuarmv5", "qemuriscv32", "qemuriscv64", "qemuloongarch64"):
>              self.skipTest("{0} is not currently supported.".format(self.td.get('MACHINE')))
>
>          pn = self.td.get('PN')
> --
> 2.40.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#196741): https://lists.openembedded.org/g/openembedded-core/message/196741
> Mute This Topic: https://lists.openembedded.org/mt/104768948/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Richard Purdie March 6, 2024, 10:34 p.m. UTC | #2
On Wed, 2024-03-06 at 10:52 -0800, Khem Raj wrote:
> On Wed, Mar 6, 2024 at 8:23 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > 
> > From: Eilís 'pidge' Ní Fhlannagáin <pidge@baylibre.com>
> > 
> > Excluding riscv64 due to mouse rather than a touchscreen which adds a
> > moving cursor, so the diff ends up > 0. Need to fix the image to use the
> > touchscreen rather than mouse input.
> 
> Is it an option we are using to start the qemu which is causing this issue?
> I would like to understand more

I suspect it will be. Somewhere on the other platforms we use a usb
touch input device (absolute coords) but I think for riscv64 it is
using a mouse (relative coords).

We just need to compare the usb devices and work out what is missing...

Cheers,

Richard
Richard Purdie March 7, 2024, 12:24 p.m. UTC | #3
On Wed, 2024-03-06 at 14:34 -0800, Richard Purdie via
lists.openembedded.org wrote:
> On Wed, 2024-03-06 at 10:52 -0800, Khem Raj wrote:
> > On Wed, Mar 6, 2024 at 8:23 AM Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > > 
> > > From: Eilís 'pidge' Ní Fhlannagáin <pidge@baylibre.com>
> > > 
> > > Excluding riscv64 due to mouse rather than a touchscreen which
> > > adds a
> > > moving cursor, so the diff ends up > 0. Need to fix the image to
> > > use the
> > > touchscreen rather than mouse input.
> > 
> > Is it an option we are using to start the qemu which is causing
> > this issue?
> > I would like to understand more
> 
> I suspect it will be. Somewhere on the other platforms we use a usb
> touch input device (absolute coords) but I think for riscv64 it is
> using a mouse (relative coords).
> 
> We just need to compare the usb devices and work out what is
> missing...

https://bugzilla.yoctoproject.org/show_bug.cgi?id=15427

Cheers,

Richard
Khem Raj March 7, 2024, 3:50 p.m. UTC | #4
On Wed, Mar 6, 2024 at 2:34 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Wed, 2024-03-06 at 10:52 -0800, Khem Raj wrote:
> > On Wed, Mar 6, 2024 at 8:23 AM Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > >
> > > From: Eilís 'pidge' Ní Fhlannagáin <pidge@baylibre.com>
> > >
> > > Excluding riscv64 due to mouse rather than a touchscreen which adds a
> > > moving cursor, so the diff ends up > 0. Need to fix the image to use the
> > > touchscreen rather than mouse input.
> >
> > Is it an option we are using to start the qemu which is causing this issue?
> > I would like to understand more
>
> I suspect it will be. Somewhere on the other platforms we use a usb
> touch input device (absolute coords) but I think for riscv64 it is
> using a mouse (relative coords).
>
> We just need to compare the usb devices and work out what is missing...
>

We use -device usb-tablet -device usb-kbd for qemuarm64 and for qemuriscv64
-device virtio-tablet-pci -device virtio-keyboard-pci is used. I think
that might be
the difference. I will test a change to use usb-tablet and usb-kbd, I
have a local
patch for kernel-cache and then these options work for qemuriscv64 as well
sadly the events are received by qemu but clicks do not work for qemuriscv32
somehow, I will make the changes for qemuriscv64 atleast and leave rv32 as it
is.

> Cheers,
>
> Richard
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#196757): https://lists.openembedded.org/g/openembedded-core/message/196757

> Mute This Topic: https://lists.openembedded.org/mt/104768948/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/lib/oeqa/runtime/cases/login.py b/meta/lib/oeqa/runtime/cases/login.py
index ac8a0454f38..edbc48ac205 100644
--- a/meta/lib/oeqa/runtime/cases/login.py
+++ b/meta/lib/oeqa/runtime/cases/login.py
@@ -28,7 +28,7 @@  from oeqa.runtime.decorator.package import OEHasPackage
 class LoginTest(OERuntimeTestCase):
     @OEHasPackage(['matchbox-desktop'])
     def test_screenshot(self):
-        if self.td.get('MACHINE') in ("qemuppc64", "qemuarmv5", "qemuriscv32", "qemuloongarch64"):
+        if self.td.get('MACHINE') in ("qemuppc64", "qemuarmv5", "qemuriscv32", "qemuriscv64", "qemuloongarch64"):
             self.skipTest("{0} is not currently supported.".format(self.td.get('MACHINE')))
 
         pn = self.td.get('PN')