| Message ID | 20240210074550.3489077-1-richard.purdie@linuxfoundation.org |
|---|---|
| State | Accepted, archived |
| Commit | 01d815aa2c0bea113fb79b51bf67c0ff90d57dd2 |
| Headers | show |
| Series | insane: Clarify runtime/ warning | expand |
> -----Original Message----- > From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie > Sent: den 10 februari 2024 08:46 > To: openembedded-core@lists.openembedded.org > Subject: [OE-core] [PATCH] insane: Clarify runtime/ warning > > We should be pointing people at VIRTUAL-RUNTIME, not virtual so tweak > the warning. Try and make it clear the difference between the build > dependencies and the runtime ones. > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > --- > meta/classes-global/insane.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass > index 828f618cda1..fa950652921 100644 > --- a/meta/classes-global/insane.bbclass > +++ b/meta/classes-global/insane.bbclass > @@ -1611,7 +1611,7 @@ python () { > for k in ['RDEPENDS', 'RPROVIDES']: > for var in bb.utils.explode_deps(d.getVar(k + ':' + pn) or ""): > if var.startswith("virtual/"): > - bb.warn("%s is set to %s, the substring 'virtual/' holds no meaning in this context. It is suggested to use the 'virtual-' instead." % (k, var)) > + bb.warn("%s is set to %s but the substring 'virtual/' holds no meaning in this context. It only works for build time dependencies, not runtime ones. It is suggested to use the 'VIRTUAL- RUNTIME_' instead." % (k, var)) I suggest changing "the 'VIRTUAL-RUNTIME_'" to "a 'VIRTUAL-RUNTIME_' variable": bb.warn("%s is set to %s but the substring 'virtual/' holds no meaning in this context. It only works for build time dependencies, not runtime ones. It is suggested to use a 'VIRTUAL-RUNTIME_' variable instead." % (k, var)) > > issues = [] > if (d.getVar('PACKAGES') or "").split(): > -- > 2.40.1 //Peter
diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index 828f618cda1..fa950652921 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -1611,7 +1611,7 @@ python () { for k in ['RDEPENDS', 'RPROVIDES']: for var in bb.utils.explode_deps(d.getVar(k + ':' + pn) or ""): if var.startswith("virtual/"): - bb.warn("%s is set to %s, the substring 'virtual/' holds no meaning in this context. It is suggested to use the 'virtual-' instead." % (k, var)) + bb.warn("%s is set to %s but the substring 'virtual/' holds no meaning in this context. It only works for build time dependencies, not runtime ones. It is suggested to use the 'VIRTUAL-RUNTIME_' instead." % (k, var)) issues = [] if (d.getVar('PACKAGES') or "").split():
We should be pointing people at VIRTUAL-RUNTIME, not virtual so tweak the warning. Try and make it clear the difference between the build dependencies and the runtime ones. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> --- meta/classes-global/insane.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)