diff mbox series

[5/7] oeqa/selftest/runtime_test: allow GPLv3 for bash

Message ID 20240208082821.430510-6-adrian.freihofer@siemens.com
State New
Headers show
Series python 3.12 related fixes | expand

Commit Message

Adrian Freihofer Feb. 8, 2024, 8:27 a.m. UTC
Test cases failed with:
  ERROR: core-image-full-cmdline-1.0-r0 do_rootfs: Package bash cannot
  be installed into the image because it has incompatible license(s):
  GPL-3.0-or-later

Allow GPLv3 for these tests.

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
---
 meta/lib/oeqa/selftest/cases/runtime_test.py | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Richard Purdie Feb. 8, 2024, 8:44 a.m. UTC | #1
On Thu, 2024-02-08 at 09:27 +0100, Adrian Freihofer wrote:
> Test cases failed with:
>   ERROR: core-image-full-cmdline-1.0-r0 do_rootfs: Package bash cannot
>   be installed into the image because it has incompatible license(s):
>   GPL-3.0-or-later
> 
> Allow GPLv3 for these tests.
> 
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> ---
>  meta/lib/oeqa/selftest/cases/runtime_test.py | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py b/meta/lib/oeqa/selftest/cases/runtime_test.py
> index 12000aac16e..4277c98a39c 100644
> --- a/meta/lib/oeqa/selftest/cases/runtime_test.py
> +++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
> @@ -124,6 +124,8 @@ class TestImage(OESelftestTestCase):
>          features = 'IMAGE_CLASSES += "testimage"\n'
>          features += 'IMAGE_INSTALL:append = " libssl"\n'
>          features += 'TEST_SUITES = "ping ssh selftest"\n'
> +        # core-image-full-cmdline needs bash which is GPL-3.0-or-later.
> +        features += 'INCOMPATIBLE_LICENSE:pn-core-image-full-cmdline = ""\n'
>          self.write_config(features)
>  
>          bitbake('core-image-full-cmdline socat')
> @@ -175,6 +177,8 @@ TEST_RUNQEMUPARAMS += " slirp"
>          features += 'PACKAGE_FEED_GPG_PASSPHRASE_FILE = "%s"\n' % os.path.join(signing_key_dir, 'key.passphrase')
>          features += 'GPG_PATH = "%s"\n' % self.gpg_home
>          features += 'PSEUDO_IGNORE_PATHS .= ",%s"\n' % self.gpg_home
> +        # core-image-full-cmdline needs bash which is GPL-3.0-or-later.
> +        features += 'INCOMPATIBLE_LICENSE:pn-core-image-full-cmdline = ""\n'
>          self.write_config(features)
>  
>          bitbake('core-image-full-cmdline socat')
> @@ -212,6 +216,8 @@ TEST_RUNQEMUPARAMS += " slirp"
>          features += 'PACKAGE_FEED_GPG_PASSPHRASE_FILE = "%s"\n' % os.path.join(signing_key_dir, 'key.passphrase')
>          features += 'GPG_PATH = "%s"\n' % self.gpg_home
>          features += 'PSEUDO_IGNORE_PATHS .= ",%s"\n' % self.gpg_home
> +        # core-image-full-cmdline needs bash which is GPL-3.0-or-later.
> +        features += 'INCOMPATIBLE_LICENSE:pn-core-image-full-cmdline = ""\n'
>          self.write_config(features)
>  
>          # Build core-image-sato and testimage

I don't understand this, where is this failing? We're not seeing this
on the autobuilder?

Cheers,

Richard
Adrian Freihofer Feb. 8, 2024, 11:24 a.m. UTC | #2
On Thu, 2024-02-08 at 08:44 +0000, Richard Purdie wrote:
> On Thu, 2024-02-08 at 09:27 +0100, Adrian Freihofer wrote:
> > Test cases failed with:
> >   ERROR: core-image-full-cmdline-1.0-r0 do_rootfs: Package bash
> > cannot
> >   be installed into the image because it has incompatible
> > license(s):
> >   GPL-3.0-or-later
> > 
> > Allow GPLv3 for these tests.
> > 
> > Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> > ---
> >  meta/lib/oeqa/selftest/cases/runtime_test.py | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py
> > b/meta/lib/oeqa/selftest/cases/runtime_test.py
> > index 12000aac16e..4277c98a39c 100644
> > --- a/meta/lib/oeqa/selftest/cases/runtime_test.py
> > +++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
> > @@ -124,6 +124,8 @@ class TestImage(OESelftestTestCase):
> >          features = 'IMAGE_CLASSES += "testimage"\n'
> >          features += 'IMAGE_INSTALL:append = " libssl"\n'
> >          features += 'TEST_SUITES = "ping ssh selftest"\n'
> > +        # core-image-full-cmdline needs bash which is GPL-3.0-or-
> > later.
> > +        features += 'INCOMPATIBLE_LICENSE:pn-core-image-full-
> > cmdline = ""\n'
> >          self.write_config(features)
> >  
> >          bitbake('core-image-full-cmdline socat')
> > @@ -175,6 +177,8 @@ TEST_RUNQEMUPARAMS += " slirp"
> >          features += 'PACKAGE_FEED_GPG_PASSPHRASE_FILE = "%s"\n' %
> > os.path.join(signing_key_dir, 'key.passphrase')
> >          features += 'GPG_PATH = "%s"\n' % self.gpg_home
> >          features += 'PSEUDO_IGNORE_PATHS .= ",%s"\n' %
> > self.gpg_home
> > +        # core-image-full-cmdline needs bash which is GPL-3.0-or-
> > later.
> > +        features += 'INCOMPATIBLE_LICENSE:pn-core-image-full-
> > cmdline = ""\n'
> >          self.write_config(features)
> >  
> >          bitbake('core-image-full-cmdline socat')
> > @@ -212,6 +216,8 @@ TEST_RUNQEMUPARAMS += " slirp"
> >          features += 'PACKAGE_FEED_GPG_PASSPHRASE_FILE = "%s"\n' %
> > os.path.join(signing_key_dir, 'key.passphrase')
> >          features += 'GPG_PATH = "%s"\n' % self.gpg_home
> >          features += 'PSEUDO_IGNORE_PATHS .= ",%s"\n' %
> > self.gpg_home
> > +        # core-image-full-cmdline needs bash which is GPL-3.0-or-
> > later.
> > +        features += 'INCOMPATIBLE_LICENSE:pn-core-image-full-
> > cmdline = ""\n'
> >          self.write_config(features)
> >  
> >          # Build core-image-sato and testimage
> 
> I don't understand this, where is this failing? We're not seeing this
> on the autobuilder?

You are right. Please ignore this patch.

I tried to recap what I did. Most probably I forgot to remove this
lines from my local.conf after debugging one failing test case
manually:

INCOMPATIBLE_LICENSE:pn-core-image-full-cmdline = "GPL-3.0* LGPL-3.0*"
INCOMPATIBLE_LICENSE:pn-core-image-weston = "GPL-3.0* LGPL-3.0*"

This would explain it.

Regards,
Adrian

> 
> Cheers,
> 
> Richard
> 
>
diff mbox series

Patch

diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py b/meta/lib/oeqa/selftest/cases/runtime_test.py
index 12000aac16e..4277c98a39c 100644
--- a/meta/lib/oeqa/selftest/cases/runtime_test.py
+++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
@@ -124,6 +124,8 @@  class TestImage(OESelftestTestCase):
         features = 'IMAGE_CLASSES += "testimage"\n'
         features += 'IMAGE_INSTALL:append = " libssl"\n'
         features += 'TEST_SUITES = "ping ssh selftest"\n'
+        # core-image-full-cmdline needs bash which is GPL-3.0-or-later.
+        features += 'INCOMPATIBLE_LICENSE:pn-core-image-full-cmdline = ""\n'
         self.write_config(features)
 
         bitbake('core-image-full-cmdline socat')
@@ -175,6 +177,8 @@  TEST_RUNQEMUPARAMS += " slirp"
         features += 'PACKAGE_FEED_GPG_PASSPHRASE_FILE = "%s"\n' % os.path.join(signing_key_dir, 'key.passphrase')
         features += 'GPG_PATH = "%s"\n' % self.gpg_home
         features += 'PSEUDO_IGNORE_PATHS .= ",%s"\n' % self.gpg_home
+        # core-image-full-cmdline needs bash which is GPL-3.0-or-later.
+        features += 'INCOMPATIBLE_LICENSE:pn-core-image-full-cmdline = ""\n'
         self.write_config(features)
 
         bitbake('core-image-full-cmdline socat')
@@ -212,6 +216,8 @@  TEST_RUNQEMUPARAMS += " slirp"
         features += 'PACKAGE_FEED_GPG_PASSPHRASE_FILE = "%s"\n' % os.path.join(signing_key_dir, 'key.passphrase')
         features += 'GPG_PATH = "%s"\n' % self.gpg_home
         features += 'PSEUDO_IGNORE_PATHS .= ",%s"\n' % self.gpg_home
+        # core-image-full-cmdline needs bash which is GPL-3.0-or-later.
+        features += 'INCOMPATIBLE_LICENSE:pn-core-image-full-cmdline = ""\n'
         self.write_config(features)
 
         # Build core-image-sato and testimage