| Message ID | 20240203005739.3960031-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | valgrind: Upgrade to 3.22 | expand |
On Fri, 2024-02-02 at 16:57 -0800, Khem Raj wrote: > Changes are summarised in Release announcement [1] > > [1] https://sourceforge.net/p/valgrind/mailman/message/50323635/ > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > ...inux-seg_override.c-add-missing-incl.patch | 30 ------------------- > ...{valgrind_3.21.0.bb => valgrind_3.22.0.bb} | 3 +- > 2 files changed, 1 insertion(+), 32 deletions(-) > delete mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch > rename meta/recipes-devtools/valgrind/{valgrind_3.21.0.bb => valgrind_3.22.0.bb} (98%) > > diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch b/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch > deleted file mode 100644 > index 5e36c28523e..00000000000 > --- a/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch > +++ /dev/null > @@ -1,30 +0,0 @@ > -From 978d9ed7f857f2cdcd2a8632f3c2feb56b99c825 Mon Sep 17 00:00:00 2001 > -From: Alexander Kanavin <alex@linutronix.de> > -Date: Mon, 8 May 2023 11:56:35 +0200 > -Subject: [PATCH] none/tests/x86-linux/seg_override.c: add missing include for > - musl builds > - > -Otherwise SYS_modify_ldt is undefined. > - > -Upstream-Status: Submitted [https://bugs.kde.org/show_bug.cgi?id=382034] > -Signed-off-by: Alexander Kanavin <alex@linutronix.de> > - > ---- > - none/tests/x86-linux/seg_override.c | 4 ++++ > - 1 file changed, 4 insertions(+) > - > -diff --git a/none/tests/x86-linux/seg_override.c b/none/tests/x86-linux/seg_override.c > -index ca8fbfe..4ef4394 100644 > ---- a/none/tests/x86-linux/seg_override.c > -+++ b/none/tests/x86-linux/seg_override.c > -@@ -3,6 +3,10 @@ > - #include <errno.h> > - #include <string.h> > - #include "../../../config.h" > -+#if defined(MUSL_LIBC) > -+#include <syscall.h> > -+#include <unistd.h> > -+#endif > - > - > - /* Stuff from Wine. */ > diff --git a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb > similarity index 98% > rename from meta/recipes-devtools/valgrind/valgrind_3.21.0.bb > rename to meta/recipes-devtools/valgrind/valgrind_3.22.0.bb > index 67a197c5097..85b29ca54db 100644 > --- a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb > +++ b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb > @@ -36,9 +36,8 @@ SRC_URI = "https://sourceware.org/pub/valgrind/valgrind-${PV}.tar.bz2 \ > file://0001-none-tests-fdleak_cmsg.stderr.exp-adjust-tmp-paths.patch \ > file://0001-memcheck-tests-Fix-timerfd-syscall-test.patch \ > file://0001-docs-Disable-manual-validation.patch \ > - file://0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch \ > " > -SRC_URI[sha256sum] = "10ce1618bb3e33fad16eb79552b0a3e1211762448a0d7fce11c8a6243b9ac971" > +SRC_URI[sha256sum] = "c811db5add2c5f729944caf47c4e7a65dcaabb9461e472b578765dd7bf6d2d4c" > UPSTREAM_CHECK_REGEX = "valgrind-(?P<pver>\d+(\.\d+)+)\.tar" > > COMPATIBLE_HOST = '(i.86|x86_64|arm|aarch64|mips|powerpc|powerpc64).*-linux' This is resulting in failing ptests on arm and x86: https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/6048 https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/6233 https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/6234 e.g.: http://autobuilder.yocto.io/pub/non-release/20240203-17/testresults/qemux86-64-ptest/valgrind.log Cheers, Richard
On 2024-02-03 4:38 p.m., Richard Purdie via lists.openembedded.org wrote: > On Fri, 2024-02-02 at 16:57 -0800, Khem Raj wrote: >> Changes are summarised in Release announcement [1] >> >> [1]https://sourceforge.net/p/valgrind/mailman/message/50323635/ >> >> Signed-off-by: Khem Raj<raj.khem@gmail.com> >> --- >> ...inux-seg_override.c-add-missing-incl.patch | 30 ------------------- >> ...{valgrind_3.21.0.bb => valgrind_3.22.0.bb} | 3 +- >> 2 files changed, 1 insertion(+), 32 deletions(-) >> delete mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch >> rename meta/recipes-devtools/valgrind/{valgrind_3.21.0.bb => valgrind_3.22.0.bb} (98%) >> >> diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch b/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch >> deleted file mode 100644 >> index 5e36c28523e..00000000000 >> --- a/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch >> +++ /dev/null >> @@ -1,30 +0,0 @@ >> -From 978d9ed7f857f2cdcd2a8632f3c2feb56b99c825 Mon Sep 17 00:00:00 2001 >> -From: Alexander Kanavin<alex@linutronix.de> >> -Date: Mon, 8 May 2023 11:56:35 +0200 >> -Subject: [PATCH] none/tests/x86-linux/seg_override.c: add missing include for >> - musl builds >> - >> -Otherwise SYS_modify_ldt is undefined. >> - >> -Upstream-Status: Submitted [https://bugs.kde.org/show_bug.cgi?id=382034] >> -Signed-off-by: Alexander Kanavin<alex@linutronix.de> >> - >> ---- >> - none/tests/x86-linux/seg_override.c | 4 ++++ >> - 1 file changed, 4 insertions(+) >> - >> -diff --git a/none/tests/x86-linux/seg_override.c b/none/tests/x86-linux/seg_override.c >> -index ca8fbfe..4ef4394 100644 >> ---- a/none/tests/x86-linux/seg_override.c >> -+++ b/none/tests/x86-linux/seg_override.c >> -@@ -3,6 +3,10 @@ >> - #include <errno.h> >> - #include <string.h> >> - #include "../../../config.h" >> -+#if defined(MUSL_LIBC) >> -+#include <syscall.h> >> -+#include <unistd.h> >> -+#endif >> - >> - >> - /* Stuff from Wine. */ >> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb >> similarity index 98% >> rename from meta/recipes-devtools/valgrind/valgrind_3.21.0.bb >> rename to meta/recipes-devtools/valgrind/valgrind_3.22.0.bb >> index 67a197c5097..85b29ca54db 100644 >> --- a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb >> +++ b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb >> @@ -36,9 +36,8 @@ SRC_URI ="https://sourceware.org/pub/valgrind/valgrind-${PV}.tar.bz2 \ >> file://0001-none-tests-fdleak_cmsg.stderr.exp-adjust-tmp-paths.patch >> \ file://0001-memcheck-tests-Fix-timerfd-syscall-test.patch \ >> file://0001-docs-Disable-manual-validation.patch \ - >> file://0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch >> \ " >> -SRC_URI[sha256sum] = "10ce1618bb3e33fad16eb79552b0a3e1211762448a0d7fce11c8a6243b9ac971" >> +SRC_URI[sha256sum] = "c811db5add2c5f729944caf47c4e7a65dcaabb9461e472b578765dd7bf6d2d4c" >> UPSTREAM_CHECK_REGEX = "valgrind-(?P<pver>\d+(\.\d+)+)\.tar" >> >> COMPATIBLE_HOST = '(i.86|x86_64|arm|aarch64|mips|powerpc|powerpc64).*-linux' > This is resulting in failing ptests on arm and x86: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/6048 > https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/6233 > https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/6234 > > e.g.: > > http://autobuilder.yocto.io/pub/non-release/20240203-17/testresults/qemux86-64-ptest/valgrind.log This is the same 14 ptest failures (1) that I saw > 1 month ago and still haven't gotten to. I have some patches (2) that reduce noise such as: PASS: cachegrind/tests/ann-merge1 python3: can't open file '/usr/lib/valgrind/ptest/cachegrind/tests/../cg_annotate': [Errno 2] No such file or directory post check failed: python3 ../cg_annotate ann-merge1a.cgout ann-merge1b.cgout PASS: cachegrind/tests/ann-merge2 but I haven't been able to make time to work on the ptest failures yet. Upstream suggested starting with: massif/tests/bug469146, massif/tests/new-cpp, massif/tests/overloaded-new so that's my plan should I ever get the time during the work week. ../Randy 1) === Test Summary === TOTAL: 792 PASSED: 759 FAILED: 14 SKIPPED: 19 DURATION: 1121 END: /usr/lib/valgrind/ptest 2024-02-04T00:17 STOP: ptest-runner TOTAL: 1 FAIL: 0 ❯ rg FAIL ~/Downloads/valgrind.log 152:FAIL: memcheck/tests/linux/dlclose_leak-no-keep 153:FAIL: memcheck/tests/linux/dlclose_leak 299:FAIL: memcheck/tests/wrap1 300:FAIL: memcheck/tests/wrap2 301:FAIL: memcheck/tests/wrap3 302:FAIL: memcheck/tests/wrap4 303:FAIL: memcheck/tests/wrap5 304:FAIL: memcheck/tests/wrap6 305:FAIL: memcheck/tests/wrap7 306:FAIL: memcheck/tests/wrap8 345:FAIL: cachegrind/tests/wrap5 573:FAIL: massif/tests/bug469146 588:FAIL: massif/tests/new-cpp 592:FAIL: massif/tests/overloaded-new 1511:FAILED: 14 2) https://lore.kernel.org/openembedded-core/94196e06-f078-4df5-afee-e29c05f11b37@windriver.com/#r rebased locally on master and: 55d23bd803 (HEAD -> master) valgrind: add python3-compile and enable cachegrind c64d10bec0 valgrind: drop Make-local-function-static patch 63741cbd41 valgrind: drop mips32 opcode patch 08b8f5c88e valgrind: drop context API musl patch 25bf857dca valgrind: update from 3.21.0 to 3.22.0 e135dc30e5 valgrind: make ptest depend on all components b73804429c (origin/master, origin/HEAD) rpm: add missing dependencies for packageconfig e41515b5f9 systemtap: Backport GCC-14 related calloc fixes a7ed494c4a kexec-tools: Fix build with gas 2.42 > > Cheers, > > Richard > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#194864):https://lists.openembedded.org/g/openembedded-core/message/194864 > Mute This Topic:https://lists.openembedded.org/mt/104132068/3616765 > Group Owner:openembedded-core+owner@lists.openembedded.org > Unsubscribe:https://lists.openembedded.org/g/openembedded-core/unsub [randy.macleod@windriver.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch b/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch deleted file mode 100644 index 5e36c28523e..00000000000 --- a/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch +++ /dev/null @@ -1,30 +0,0 @@ -From 978d9ed7f857f2cdcd2a8632f3c2feb56b99c825 Mon Sep 17 00:00:00 2001 -From: Alexander Kanavin <alex@linutronix.de> -Date: Mon, 8 May 2023 11:56:35 +0200 -Subject: [PATCH] none/tests/x86-linux/seg_override.c: add missing include for - musl builds - -Otherwise SYS_modify_ldt is undefined. - -Upstream-Status: Submitted [https://bugs.kde.org/show_bug.cgi?id=382034] -Signed-off-by: Alexander Kanavin <alex@linutronix.de> - ---- - none/tests/x86-linux/seg_override.c | 4 ++++ - 1 file changed, 4 insertions(+) - -diff --git a/none/tests/x86-linux/seg_override.c b/none/tests/x86-linux/seg_override.c -index ca8fbfe..4ef4394 100644 ---- a/none/tests/x86-linux/seg_override.c -+++ b/none/tests/x86-linux/seg_override.c -@@ -3,6 +3,10 @@ - #include <errno.h> - #include <string.h> - #include "../../../config.h" -+#if defined(MUSL_LIBC) -+#include <syscall.h> -+#include <unistd.h> -+#endif - - - /* Stuff from Wine. */ diff --git a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb similarity index 98% rename from meta/recipes-devtools/valgrind/valgrind_3.21.0.bb rename to meta/recipes-devtools/valgrind/valgrind_3.22.0.bb index 67a197c5097..85b29ca54db 100644 --- a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb +++ b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb @@ -36,9 +36,8 @@ SRC_URI = "https://sourceware.org/pub/valgrind/valgrind-${PV}.tar.bz2 \ file://0001-none-tests-fdleak_cmsg.stderr.exp-adjust-tmp-paths.patch \ file://0001-memcheck-tests-Fix-timerfd-syscall-test.patch \ file://0001-docs-Disable-manual-validation.patch \ - file://0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch \ " -SRC_URI[sha256sum] = "10ce1618bb3e33fad16eb79552b0a3e1211762448a0d7fce11c8a6243b9ac971" +SRC_URI[sha256sum] = "c811db5add2c5f729944caf47c4e7a65dcaabb9461e472b578765dd7bf6d2d4c" UPSTREAM_CHECK_REGEX = "valgrind-(?P<pver>\d+(\.\d+)+)\.tar" COMPATIBLE_HOST = '(i.86|x86_64|arm|aarch64|mips|powerpc|powerpc64).*-linux'
Changes are summarised in Release announcement [1] [1] https://sourceforge.net/p/valgrind/mailman/message/50323635/ Signed-off-by: Khem Raj <raj.khem@gmail.com> --- ...inux-seg_override.c-add-missing-incl.patch | 30 ------------------- ...{valgrind_3.21.0.bb => valgrind_3.22.0.bb} | 3 +- 2 files changed, 1 insertion(+), 32 deletions(-) delete mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch rename meta/recipes-devtools/valgrind/{valgrind_3.21.0.bb => valgrind_3.22.0.bb} (98%)