| Message ID | 20240131183243.30223-1-petr.vorel@gmail.com |
|---|---|
| State | Accepted, archived |
| Commit | b2867cac5ac58862469f0c6c056607abeca0b0d0 |
| Headers | show |
| Series | [1/1] ltp: Update to 20240129 | expand |
On 31/01/2024 19:32:43+0100, Petr Vorel wrote: > Removed patch accepted upstream as > 8c53cc947 ("testcases/kernel/syscalls/fcntl: define _LARGEFILE64_SOURCE") > > Rebase runtest/mm patch. > > Signed-off-by: Petr Vorel <petr.vorel@gmail.com> > --- > Hi Richard, Daniel, Khem, > > could anybody please test this update if build (it should). > > Also, it'd be good nice to rerun proc01 -m 128 and report me with the > details, maybe we can fix it. If still problematic, it'd be nice to turn > disable_hanging_tests.patch into proper git patch (makes rebasing patch > on new LTP version easier). This fails on the autobuilders: https://autobuilder.yoctoproject.org/typhoon/#/builders/95/builds/5957/steps/12/logs/stdio https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/5917/steps/12/logs/stdio > > Kind regards, > Petr > > ...001-Remove-OOM-tests-from-runtest-mm.patch | 6 ++-- > ...-syscalls-fcntl-define-_LARGEFILE64_.patch | 28 ------------------- > .../ltp/{ltp_20230929.bb => ltp_20240129.bb} | 3 +- > 3 files changed, 4 insertions(+), 33 deletions(-) > delete mode 100644 meta/recipes-extended/ltp/ltp/0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch > rename meta/recipes-extended/ltp/{ltp_20230929.bb => ltp_20240129.bb} (97%) > > diff --git a/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch > index 6d945700be..cc98079651 100644 > --- a/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch > +++ b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch > @@ -14,10 +14,10 @@ Signed-off-by: Petr Vorel <petr.vorel@gmail.com> > 1 file changed, 6 deletions(-) > > diff --git a/runtest/mm b/runtest/mm > -index 6537666a9..e5a091a5a 100644 > +index d859b331c..3c2962f44 100644 > --- a/runtest/mm > +++ b/runtest/mm > -@@ -73,12 +73,6 @@ ksm06_2 ksm06 -n 8000 > +@@ -74,12 +74,6 @@ ksm07 ksm07 > > cpuset01 cpuset01 > > @@ -31,5 +31,5 @@ index 6537666a9..e5a091a5a 100644 > > thp01 thp01 -I 120 > -- > -2.33.0 > +2.43.0 > > diff --git a/meta/recipes-extended/ltp/ltp/0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch b/meta/recipes-extended/ltp/ltp/0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch > deleted file mode 100644 > index dbe63f2170..0000000000 > --- a/meta/recipes-extended/ltp/ltp/0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch > +++ /dev/null > @@ -1,28 +0,0 @@ > -From f4f75ce9218b469d91b536218de3323977edc529 Mon Sep 17 00:00:00 2001 > -From: Alexander Kanavin <alex@linutronix.de> > -Date: Tue, 13 Jun 2023 15:10:33 +0200 > -Subject: [PATCH] testcases/kernel/syscalls/fcntl: define _LARGEFILE64_SOURCE > - > -This is required for off64_t to be available on musl systems. > - > -Upstream-Status: Submitted [https://github.com/linux-test-project/ltp/pull/1047] > -Signed-off-by: Alexander Kanavin <alex@linutronix.de> > ---- > - testcases/kernel/syscalls/fcntl/Makefile | 2 +- > - 1 file changed, 1 insertion(+), 1 deletion(-) > - > -diff --git a/testcases/kernel/syscalls/fcntl/Makefile b/testcases/kernel/syscalls/fcntl/Makefile > -index df663a50a..aac774111 100644 > ---- a/testcases/kernel/syscalls/fcntl/Makefile > -+++ b/testcases/kernel/syscalls/fcntl/Makefile > -@@ -17,6 +17,6 @@ include $(abs_srcdir)/../utils/newer_64.mk > - > - %_64: CPPFLAGS += -D_FILE_OFFSET_BITS=64 > - > --CPPFLAGS += -D_GNU_SOURCE > -+CPPFLAGS += -D_GNU_SOURCE -D_LARGEFILE64_SOURCE > - > - include $(top_srcdir)/include/mk/generic_leaf_target.mk > --- > -2.30.2 > - > diff --git a/meta/recipes-extended/ltp/ltp_20230929.bb b/meta/recipes-extended/ltp/ltp_20240129.bb > similarity index 97% > rename from meta/recipes-extended/ltp/ltp_20230929.bb > rename to meta/recipes-extended/ltp/ltp_20240129.bb > index 5c43346883..5cd33bb6a3 100644 > --- a/meta/recipes-extended/ltp/ltp_20230929.bb > +++ b/meta/recipes-extended/ltp/ltp_20240129.bb > @@ -24,12 +24,11 @@ TUNE_CCARGS:remove:x86-64 = "-mfpmath=sse" > > CFLAGS:append:powerpc64 = " -D__SANE_USERSPACE_TYPES__" > CFLAGS:append:mipsarchn64 = " -D__SANE_USERSPACE_TYPES__" > -SRCREV = "110d3be6a9c58674de3e366b96a70f0129a5d299" > +SRCREV = "68737d20556d37364c95776044b1119c0912a36a" > > SRC_URI = "git://github.com/linux-test-project/ltp.git;branch=master;protocol=https \ > file://0001-Remove-OOM-tests-from-runtest-mm.patch \ > file://disable_hanging_tests.patch \ > - file://0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch \ > " > > S = "${WORKDIR}/git" > -- > 2.43.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#194532): https://lists.openembedded.org/g/openembedded-core/message/194532 > Mute This Topic: https://lists.openembedded.org/mt/104081044/3617179 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Hi Alexandre, all, > On 31/01/2024 19:32:43+0100, Petr Vorel wrote: > > Removed patch accepted upstream as > > 8c53cc947 ("testcases/kernel/syscalls/fcntl: define _LARGEFILE64_SOURCE") > > Rebase runtest/mm patch. > > Signed-off-by: Petr Vorel <petr.vorel@gmail.com> > > --- > > Hi Richard, Daniel, Khem, > > could anybody please test this update if build (it should). > > Also, it'd be good nice to rerun proc01 -m 128 and report me with the > > details, maybe we can fix it. If still problematic, it'd be nice to turn > > disable_hanging_tests.patch into proper git patch (makes rebasing patch > > on new LTP version easier). > This fails on the autobuilders: > https://autobuilder.yoctoproject.org/typhoon/#/builders/95/builds/5957/steps/12/logs/stdio > https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/5917/steps/12/logs/stdio Thanks for testing this, you probably mean the warning before python stack trace: scp: /opt/ltp/results/connectors: No such file or directory WARNING: core-image-sato-1.0-r0 do_testimage: File could not be copied. Output: scp: /opt/ltp/results/connectors: No such file or directory The problem is not due packaging, but simply runtest/connectors was removed [1], thus your tooling has to be fixed not to expect it (not trying to run it). I'm sorry, we sometimes do cleanup which brings incompatibility issue (here it did not make sense to start SUT just for single test, thus we moved the test to runtest/kernel_misc). Kind regards, Petr [1] https://github.com/linux-test-project/ltp/commit/9b642d89c0bcf5885b051c2d5768fa94b61d86cb > > Kind regards, > > Petr > > ...001-Remove-OOM-tests-from-runtest-mm.patch | 6 ++-- > > ...-syscalls-fcntl-define-_LARGEFILE64_.patch | 28 ------------------- > > .../ltp/{ltp_20230929.bb => ltp_20240129.bb} | 3 +- > > 3 files changed, 4 insertions(+), 33 deletions(-) > > delete mode 100644 meta/recipes-extended/ltp/ltp/0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch > > rename meta/recipes-extended/ltp/{ltp_20230929.bb => ltp_20240129.bb} (97%) > > diff --git a/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch > > index 6d945700be..cc98079651 100644 > > --- a/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch > > +++ b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch > > @@ -14,10 +14,10 @@ Signed-off-by: Petr Vorel <petr.vorel@gmail.com> > > 1 file changed, 6 deletions(-) > > diff --git a/runtest/mm b/runtest/mm > > -index 6537666a9..e5a091a5a 100644 > > +index d859b331c..3c2962f44 100644 > > --- a/runtest/mm > > +++ b/runtest/mm > > -@@ -73,12 +73,6 @@ ksm06_2 ksm06 -n 8000 > > +@@ -74,12 +74,6 @@ ksm07 ksm07 > > cpuset01 cpuset01 > > @@ -31,5 +31,5 @@ index 6537666a9..e5a091a5a 100644 > > thp01 thp01 -I 120 > > -- > > -2.33.0 > > +2.43.0 > > diff --git a/meta/recipes-extended/ltp/ltp/0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch b/meta/recipes-extended/ltp/ltp/0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch > > deleted file mode 100644 > > index dbe63f2170..0000000000 > > --- a/meta/recipes-extended/ltp/ltp/0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch > > +++ /dev/null > > @@ -1,28 +0,0 @@ > > -From f4f75ce9218b469d91b536218de3323977edc529 Mon Sep 17 00:00:00 2001 > > -From: Alexander Kanavin <alex@linutronix.de> > > -Date: Tue, 13 Jun 2023 15:10:33 +0200 > > -Subject: [PATCH] testcases/kernel/syscalls/fcntl: define _LARGEFILE64_SOURCE > > - > > -This is required for off64_t to be available on musl systems. > > - > > -Upstream-Status: Submitted [https://github.com/linux-test-project/ltp/pull/1047] > > -Signed-off-by: Alexander Kanavin <alex@linutronix.de> > > ---- > > - testcases/kernel/syscalls/fcntl/Makefile | 2 +- > > - 1 file changed, 1 insertion(+), 1 deletion(-) > > - > > -diff --git a/testcases/kernel/syscalls/fcntl/Makefile b/testcases/kernel/syscalls/fcntl/Makefile > > -index df663a50a..aac774111 100644 > > ---- a/testcases/kernel/syscalls/fcntl/Makefile > > -+++ b/testcases/kernel/syscalls/fcntl/Makefile > > -@@ -17,6 +17,6 @@ include $(abs_srcdir)/../utils/newer_64.mk > > - > > - %_64: CPPFLAGS += -D_FILE_OFFSET_BITS=64 > > - > > --CPPFLAGS += -D_GNU_SOURCE > > -+CPPFLAGS += -D_GNU_SOURCE -D_LARGEFILE64_SOURCE > > - > > - include $(top_srcdir)/include/mk/generic_leaf_target.mk > > --- > > -2.30.2 > > - > > diff --git a/meta/recipes-extended/ltp/ltp_20230929.bb b/meta/recipes-extended/ltp/ltp_20240129.bb > > similarity index 97% > > rename from meta/recipes-extended/ltp/ltp_20230929.bb > > rename to meta/recipes-extended/ltp/ltp_20240129.bb > > index 5c43346883..5cd33bb6a3 100644 > > --- a/meta/recipes-extended/ltp/ltp_20230929.bb > > +++ b/meta/recipes-extended/ltp/ltp_20240129.bb > > @@ -24,12 +24,11 @@ TUNE_CCARGS:remove:x86-64 = "-mfpmath=sse" > > CFLAGS:append:powerpc64 = " -D__SANE_USERSPACE_TYPES__" > > CFLAGS:append:mipsarchn64 = " -D__SANE_USERSPACE_TYPES__" > > -SRCREV = "110d3be6a9c58674de3e366b96a70f0129a5d299" > > +SRCREV = "68737d20556d37364c95776044b1119c0912a36a" > > SRC_URI = "git://github.com/linux-test-project/ltp.git;branch=master;protocol=https \ > > file://0001-Remove-OOM-tests-from-runtest-mm.patch \ > > file://disable_hanging_tests.patch \ > > - file://0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch \ > > " > > S = "${WORKDIR}/git" > > -- > > 2.43.0 > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#194532): https://lists.openembedded.org/g/openembedded-core/message/194532 > > Mute This Topic: https://lists.openembedded.org/mt/104081044/3617179 > > Group Owner: openembedded-core+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > > -=-=-=-=-=-=-=-=-=-=-=-
Hi Petr, On Sun, 2024-02-04 at 00:52 +0100, Petr Vorel wrote: > Hi Alexandre, all, > > > On 31/01/2024 19:32:43+0100, Petr Vorel wrote: > > > Removed patch accepted upstream as > > > 8c53cc947 ("testcases/kernel/syscalls/fcntl: define _LARGEFILE64_SOURCE") > > > > Rebase runtest/mm patch. > > > > Signed-off-by: Petr Vorel <petr.vorel@gmail.com> > > > --- > > > Hi Richard, Daniel, Khem, > > > > could anybody please test this update if build (it should). > > > > Also, it'd be good nice to rerun proc01 -m 128 and report me with the > > > details, maybe we can fix it. If still problematic, it'd be nice to turn > > > disable_hanging_tests.patch into proper git patch (makes rebasing patch > > > on new LTP version easier). > > > This fails on the autobuilders: > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/95/builds/5957/steps/12/logs/stdio > > https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/5917/steps/12/logs/stdio > > > Thanks for testing this, you probably mean the warning before python stack trace: > > scp: /opt/ltp/results/connectors: No such file or directory > WARNING: core-image-sato-1.0-r0 do_testimage: File could not be copied. Output: scp: /opt/ltp/results/connectors: No such file or directory > > The problem is not due packaging, but simply runtest/connectors was removed [1], > thus your tooling has to be fixed not to expect it (not trying to run it). > I'm sorry, we sometimes do cleanup which brings incompatibility issue > (here it did not make sense to start SUT just for single test, thus we moved the > test to runtest/kernel_misc). I did try again with that removed: https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/5929/steps/12/logs/stdio https://autobuilder.yoctoproject.org/typhoon/#/builders/95/builds/5968/steps/12/logs/stdio which comes down to: scp: /opt/ltp/results/fsx: No such file or directory so I'll remove that and try again. Are there any additions we should be considering too? This all feels a little fragile so I'm wondering if we should be reworking the way we handle this? Cheers, Richard
> Hi Petr, > On Sun, 2024-02-04 at 00:52 +0100, Petr Vorel wrote: > > Hi Alexandre, all, > > > On 31/01/2024 19:32:43+0100, Petr Vorel wrote: > > > > Removed patch accepted upstream as > > > > 8c53cc947 ("testcases/kernel/syscalls/fcntl: define _LARGEFILE64_SOURCE") > > > > Rebase runtest/mm patch. > > > > Signed-off-by: Petr Vorel <petr.vorel@gmail.com> > > > > --- > > > > Hi Richard, Daniel, Khem, > > > > could anybody please test this update if build (it should). > > > > Also, it'd be good nice to rerun proc01 -m 128 and report me with the > > > > details, maybe we can fix it. If still problematic, it'd be nice to turn > > > > disable_hanging_tests.patch into proper git patch (makes rebasing patch > > > > on new LTP version easier). > > > This fails on the autobuilders: > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/95/builds/5957/steps/12/logs/stdio > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/5917/steps/12/logs/stdio > > Thanks for testing this, you probably mean the warning before python stack trace: > > scp: /opt/ltp/results/connectors: No such file or directory > > WARNING: core-image-sato-1.0-r0 do_testimage: File could not be copied. Output: scp: /opt/ltp/results/connectors: No such file or directory > > The problem is not due packaging, but simply runtest/connectors was removed [1], > > thus your tooling has to be fixed not to expect it (not trying to run it). > > I'm sorry, we sometimes do cleanup which brings incompatibility issue > > (here it did not make sense to start SUT just for single test, thus we moved the > > test to runtest/kernel_misc). > I did try again with that removed: > https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/5929/steps/12/logs/stdio > https://autobuilder.yoctoproject.org/typhoon/#/builders/95/builds/5968/steps/12/logs/stdio > which comes down to: > scp: /opt/ltp/results/fsx: No such file or directory > so I'll remove that and try again. > Are there any additions we should be considering too? This all feels a > little fragile so I'm wondering if we should be reworking the way we > handle this? I forget that also this one was removed in fb2b6a0b3 ("fs: Remove fsx runtest suite") [1], therefore not a real error. Kind regards, Petr [1] https://github.com/linux-test-project/ltp/commit/fb2b6a0b3c840aa80229acf4360b7bdc3ced5edb > Cheers, > Richard
On Mon, 2024-02-05 at 11:43 +0100, Petr Vorel wrote: > > Hi Petr, > > > On Sun, 2024-02-04 at 00:52 +0100, Petr Vorel wrote: > > > Hi Alexandre, all, > > > > > On 31/01/2024 19:32:43+0100, Petr Vorel wrote: > > > > > Removed patch accepted upstream as > > > > > 8c53cc947 ("testcases/kernel/syscalls/fcntl: define _LARGEFILE64_SOURCE") > > > > > > Rebase runtest/mm patch. > > > > > > Signed-off-by: Petr Vorel <petr.vorel@gmail.com> > > > > > --- > > > > > Hi Richard, Daniel, Khem, > > > > > > could anybody please test this update if build (it should). > > > > > > Also, it'd be good nice to rerun proc01 -m 128 and report me with the > > > > > details, maybe we can fix it. If still problematic, it'd be nice to turn > > > > > disable_hanging_tests.patch into proper git patch (makes rebasing patch > > > > > on new LTP version easier). > > > > > This fails on the autobuilders: > > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/95/builds/5957/steps/12/logs/stdio > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/5917/steps/12/logs/stdio > > > > > Thanks for testing this, you probably mean the warning before python stack trace: > > > > scp: /opt/ltp/results/connectors: No such file or directory > > > WARNING: core-image-sato-1.0-r0 do_testimage: File could not be copied. Output: scp: /opt/ltp/results/connectors: No such file or directory > > > > The problem is not due packaging, but simply runtest/connectors was removed [1], > > > thus your tooling has to be fixed not to expect it (not trying to run it). > > > I'm sorry, we sometimes do cleanup which brings incompatibility issue > > > (here it did not make sense to start SUT just for single test, thus we moved the > > > test to runtest/kernel_misc). > > > I did try again with that removed: > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/5929/steps/12/logs/stdio > > https://autobuilder.yoctoproject.org/typhoon/#/builders/95/builds/5968/steps/12/logs/stdio > > > which comes down to: > > > scp: /opt/ltp/results/fsx: No such file or directory > > > so I'll remove that and try again. > > > Are there any additions we should be considering too? This all feels a > > little fragile so I'm wondering if we should be reworking the way we > > handle this? > > I forget that also this one was removed in fb2b6a0b3 ("fs: Remove fsx runtest > suite") [1], therefore not a real error. Thanks, with that removed we had successful runs so I've merged it. I appreciate we need to try and re-enable that test that was hanging but I'm a bit stretched with other issues at the moment to dive into that one unfortunately. Cheers, Richard
> On Mon, 2024-02-05 at 11:43 +0100, Petr Vorel wrote: > > > Hi Petr, > > > On Sun, 2024-02-04 at 00:52 +0100, Petr Vorel wrote: > > > > Hi Alexandre, all, > > > > > On 31/01/2024 19:32:43+0100, Petr Vorel wrote: > > > > > > Removed patch accepted upstream as > > > > > > 8c53cc947 ("testcases/kernel/syscalls/fcntl: define _LARGEFILE64_SOURCE") > > > > > > Rebase runtest/mm patch. > > > > > > Signed-off-by: Petr Vorel <petr.vorel@gmail.com> > > > > > > --- > > > > > > Hi Richard, Daniel, Khem, > > > > > > could anybody please test this update if build (it should). > > > > > > Also, it'd be good nice to rerun proc01 -m 128 and report me with the > > > > > > details, maybe we can fix it. If still problematic, it'd be nice to turn > > > > > > disable_hanging_tests.patch into proper git patch (makes rebasing patch > > > > > > on new LTP version easier). > > > > > This fails on the autobuilders: > > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/95/builds/5957/steps/12/logs/stdio > > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/5917/steps/12/logs/stdio > > > > Thanks for testing this, you probably mean the warning before python stack trace: > > > > scp: /opt/ltp/results/connectors: No such file or directory > > > > WARNING: core-image-sato-1.0-r0 do_testimage: File could not be copied. Output: scp: /opt/ltp/results/connectors: No such file or directory > > > > The problem is not due packaging, but simply runtest/connectors was removed [1], > > > > thus your tooling has to be fixed not to expect it (not trying to run it). > > > > I'm sorry, we sometimes do cleanup which brings incompatibility issue > > > > (here it did not make sense to start SUT just for single test, thus we moved the > > > > test to runtest/kernel_misc). > > > I did try again with that removed: > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/5929/steps/12/logs/stdio > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/95/builds/5968/steps/12/logs/stdio > > > which comes down to: > > > scp: /opt/ltp/results/fsx: No such file or directory > > > so I'll remove that and try again. > > > Are there any additions we should be considering too? This all feels a > > > little fragile so I'm wondering if we should be reworking the way we > > > handle this? > > I forget that also this one was removed in fb2b6a0b3 ("fs: Remove fsx runtest > > suite") [1], therefore not a real error. > Thanks, with that removed we had successful runs so I've merged it. Thank you for testing and fixing these groups in meta/lib/oeqa/runtime/cases/ltp.py, I completely overlooked this file. BTW there are move groups which could be added to ltp_groups: cve, crypto, ima, net.nfs, net_stress.ipsec_icmp, net.ipv6, numa, uevent, ltp-aiodio.part1, ltp-aiodio.part2, ltp-aiodio.part3, ltp-aiodio.part4 (There are more, thus list mostly the most important ones) > I appreciate we need to try and re-enable that test that was hanging > but I'm a bit stretched with other issues at the moment to dive into > that one unfortunately. Understand. Test has been rewritten to new API in 2017, I would expect they would work properly. But the patchset removal was done in 2020. https://bugzilla.yoctoproject.org/show_bug.cgi?id=13802 But looking at https://git.yoctoproject.org/poky/commit/?id=529bb922c786f1acd041ff9a8d2b675d067e2ae3 linked via: https://bugzilla.yoctoproject.org/show_bug.cgi?id=13802#c68 The tests found a real bug https://lore.kernel.org/lkml/20210616125157.438837-1-paul.gortmaker@windriver.com/ While I understand the pain when test breaks whole testing, removing valid tests means the functionality is not tested and we blindly believe kernel works. Kind regards, Petr > Cheers, > Richard
diff --git a/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch index 6d945700be..cc98079651 100644 --- a/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch +++ b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch @@ -14,10 +14,10 @@ Signed-off-by: Petr Vorel <petr.vorel@gmail.com> 1 file changed, 6 deletions(-) diff --git a/runtest/mm b/runtest/mm -index 6537666a9..e5a091a5a 100644 +index d859b331c..3c2962f44 100644 --- a/runtest/mm +++ b/runtest/mm -@@ -73,12 +73,6 @@ ksm06_2 ksm06 -n 8000 +@@ -74,12 +74,6 @@ ksm07 ksm07 cpuset01 cpuset01 @@ -31,5 +31,5 @@ index 6537666a9..e5a091a5a 100644 thp01 thp01 -I 120 -- -2.33.0 +2.43.0 diff --git a/meta/recipes-extended/ltp/ltp/0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch b/meta/recipes-extended/ltp/ltp/0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch deleted file mode 100644 index dbe63f2170..0000000000 --- a/meta/recipes-extended/ltp/ltp/0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch +++ /dev/null @@ -1,28 +0,0 @@ -From f4f75ce9218b469d91b536218de3323977edc529 Mon Sep 17 00:00:00 2001 -From: Alexander Kanavin <alex@linutronix.de> -Date: Tue, 13 Jun 2023 15:10:33 +0200 -Subject: [PATCH] testcases/kernel/syscalls/fcntl: define _LARGEFILE64_SOURCE - -This is required for off64_t to be available on musl systems. - -Upstream-Status: Submitted [https://github.com/linux-test-project/ltp/pull/1047] -Signed-off-by: Alexander Kanavin <alex@linutronix.de> ---- - testcases/kernel/syscalls/fcntl/Makefile | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/testcases/kernel/syscalls/fcntl/Makefile b/testcases/kernel/syscalls/fcntl/Makefile -index df663a50a..aac774111 100644 ---- a/testcases/kernel/syscalls/fcntl/Makefile -+++ b/testcases/kernel/syscalls/fcntl/Makefile -@@ -17,6 +17,6 @@ include $(abs_srcdir)/../utils/newer_64.mk - - %_64: CPPFLAGS += -D_FILE_OFFSET_BITS=64 - --CPPFLAGS += -D_GNU_SOURCE -+CPPFLAGS += -D_GNU_SOURCE -D_LARGEFILE64_SOURCE - - include $(top_srcdir)/include/mk/generic_leaf_target.mk --- -2.30.2 - diff --git a/meta/recipes-extended/ltp/ltp_20230929.bb b/meta/recipes-extended/ltp/ltp_20240129.bb similarity index 97% rename from meta/recipes-extended/ltp/ltp_20230929.bb rename to meta/recipes-extended/ltp/ltp_20240129.bb index 5c43346883..5cd33bb6a3 100644 --- a/meta/recipes-extended/ltp/ltp_20230929.bb +++ b/meta/recipes-extended/ltp/ltp_20240129.bb @@ -24,12 +24,11 @@ TUNE_CCARGS:remove:x86-64 = "-mfpmath=sse" CFLAGS:append:powerpc64 = " -D__SANE_USERSPACE_TYPES__" CFLAGS:append:mipsarchn64 = " -D__SANE_USERSPACE_TYPES__" -SRCREV = "110d3be6a9c58674de3e366b96a70f0129a5d299" +SRCREV = "68737d20556d37364c95776044b1119c0912a36a" SRC_URI = "git://github.com/linux-test-project/ltp.git;branch=master;protocol=https \ file://0001-Remove-OOM-tests-from-runtest-mm.patch \ file://disable_hanging_tests.patch \ - file://0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch \ " S = "${WORKDIR}/git"
Removed patch accepted upstream as 8c53cc947 ("testcases/kernel/syscalls/fcntl: define _LARGEFILE64_SOURCE") Rebase runtest/mm patch. Signed-off-by: Petr Vorel <petr.vorel@gmail.com> --- Hi Richard, Daniel, Khem, could anybody please test this update if build (it should). Also, it'd be good nice to rerun proc01 -m 128 and report me with the details, maybe we can fix it. If still problematic, it'd be nice to turn disable_hanging_tests.patch into proper git patch (makes rebasing patch on new LTP version easier). Kind regards, Petr ...001-Remove-OOM-tests-from-runtest-mm.patch | 6 ++-- ...-syscalls-fcntl-define-_LARGEFILE64_.patch | 28 ------------------- .../ltp/{ltp_20230929.bb => ltp_20240129.bb} | 3 +- 3 files changed, 4 insertions(+), 33 deletions(-) delete mode 100644 meta/recipes-extended/ltp/ltp/0001-testcases-kernel-syscalls-fcntl-define-_LARGEFILE64_.patch rename meta/recipes-extended/ltp/{ltp_20230929.bb => ltp_20240129.bb} (97%)