diff mbox series

tune-core2: Update qemu cpu to supported model

Message ID 20240116204558.7726-1-simone.p.weiss@posteo.com
State Accepted, archived
Commit f2383a2bff3eb756740ecaf48147bea89303e443
Headers show
Series tune-core2: Update qemu cpu to supported model | expand

Commit Message

Simone Weiß Jan. 16, 2024, 8:45 p.m. UTC
From: Simone Weiß <simone.p.weiss@posteo.com>

Fixes [YOCTO #12388]

QEMUs documentation does recommend to not use n270 and core2duo as
an argument to -cpu anymore. Update therefore the QEMU cpu option for
the core2duo tune to Nehalam. Tested it locally with QEMU and KVM.

Signed-off-by: Simone Weiß <simone.p.weiss@posteo.com>
---
 meta/conf/machine/include/x86/tune-core2.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Alexander Kanavin Jan. 17, 2024, 3:37 a.m. UTC | #1
Please provide a link to the documentation in the commit message, and not
just the claim.

Alex

On Tue 16. Jan 2024 at 21.46, Simone Weiß <simone.p.weiss@posteo.com> wrote:

> From: Simone Weiß <simone.p.weiss@posteo.com>
>
> Fixes [YOCTO #12388]
>
> QEMUs documentation does recommend to not use n270 and core2duo as
> an argument to -cpu anymore. Update therefore the QEMU cpu option for
> the core2duo tune to Nehalam. Tested it locally with QEMU and KVM.
>
> Signed-off-by: Simone Weiß <simone.p.weiss@posteo.com>
> ---
>  meta/conf/machine/include/x86/tune-core2.inc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/conf/machine/include/x86/tune-core2.inc
> b/meta/conf/machine/include/x86/tune-core2.inc
> index 97b7c1b188..082fd4efc3 100644
> --- a/meta/conf/machine/include/x86/tune-core2.inc
> +++ b/meta/conf/machine/include/x86/tune-core2.inc
> @@ -21,18 +21,18 @@ TUNE_FEATURES:tune-core2-32 =
> "${TUNE_FEATURES:tune-x86} core2"
>  BASE_LIB:tune-core2-32 = "lib"
>  TUNE_PKGARCH:tune-core2-32 = "core2-32"
>  PACKAGE_EXTRA_ARCHS:tune-core2-32 = "${PACKAGE_EXTRA_ARCHS:tune-i686}
> core2-32"
> -QEMU_EXTRAOPTIONS_core2-32 = " -cpu n270"
> +QEMU_EXTRAOPTIONS_core2-32 = " -cpu Nehalem,check=false"
>
>  AVAILTUNES += "core2-64"
>  TUNE_FEATURES:tune-core2-64 = "${TUNE_FEATURES:tune-x86-64} core2"
>  BASE_LIB:tune-core2-64 = "lib64"
>  TUNE_PKGARCH:tune-core2-64 = "core2-64"
>  PACKAGE_EXTRA_ARCHS:tune-core2-64 = "${PACKAGE_EXTRA_ARCHS:tune-x86-64}
> core2-64"
> -QEMU_EXTRAOPTIONS_core2-64 = " -cpu core2duo"
> +QEMU_EXTRAOPTIONS_core2-64 = " -cpu Nehalem,check=false"
>
>  AVAILTUNES += "core2-64-x32"
>  TUNE_FEATURES:tune-core2-64-x32 = "${TUNE_FEATURES:tune-x86-64-x32} core2"
>  BASE_LIB:tune-core2-64-x32 = "libx32"
>  TUNE_PKGARCH:tune-core2-64-x32 = "core2-64-x32"
>  PACKAGE_EXTRA_ARCHS:tune-core2-64-x32 =
> "${PACKAGE_EXTRA_ARCHS:tune-x86-64-x32} core2-64-x32"
> -QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu core2duo"
> +QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu Nehalem,check=false"
> --
> 2.39.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#193874):
> https://lists.openembedded.org/g/openembedded-core/message/193874
> Mute This Topic: https://lists.openembedded.org/mt/103771791/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Khem Raj Jan. 17, 2024, 3:47 a.m. UTC | #2
On Tue, Jan 16, 2024 at 7:37 PM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> Please provide a link to the documentation in the commit message, and not just the claim.
>

Perhaps add this link to commit msg
https://qemu-project.gitlab.io/qemu/system/qemu-cpu-models.html#other-non-recommended-x86-cpus

> Alex
>
> On Tue 16. Jan 2024 at 21.46, Simone Weiß <simone.p.weiss@posteo.com> wrote:
>>
>> From: Simone Weiß <simone.p.weiss@posteo.com>
>>
>> Fixes [YOCTO #12388]
>>
>> QEMUs documentation does recommend to not use n270 and core2duo as
>> an argument to -cpu anymore. Update therefore the QEMU cpu option for
>> the core2duo tune to Nehalam. Tested it locally with QEMU and KVM.
>>
>> Signed-off-by: Simone Weiß <simone.p.weiss@posteo.com>
>> ---
>>  meta/conf/machine/include/x86/tune-core2.inc | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/conf/machine/include/x86/tune-core2.inc b/meta/conf/machine/include/x86/tune-core2.inc
>> index 97b7c1b188..082fd4efc3 100644
>> --- a/meta/conf/machine/include/x86/tune-core2.inc
>> +++ b/meta/conf/machine/include/x86/tune-core2.inc
>> @@ -21,18 +21,18 @@ TUNE_FEATURES:tune-core2-32 = "${TUNE_FEATURES:tune-x86} core2"
>>  BASE_LIB:tune-core2-32 = "lib"
>>  TUNE_PKGARCH:tune-core2-32 = "core2-32"
>>  PACKAGE_EXTRA_ARCHS:tune-core2-32 = "${PACKAGE_EXTRA_ARCHS:tune-i686} core2-32"
>> -QEMU_EXTRAOPTIONS_core2-32 = " -cpu n270"
>> +QEMU_EXTRAOPTIONS_core2-32 = " -cpu Nehalem,check=false"
>>
>>  AVAILTUNES += "core2-64"
>>  TUNE_FEATURES:tune-core2-64 = "${TUNE_FEATURES:tune-x86-64} core2"
>>  BASE_LIB:tune-core2-64 = "lib64"
>>  TUNE_PKGARCH:tune-core2-64 = "core2-64"
>>  PACKAGE_EXTRA_ARCHS:tune-core2-64 = "${PACKAGE_EXTRA_ARCHS:tune-x86-64} core2-64"
>> -QEMU_EXTRAOPTIONS_core2-64 = " -cpu core2duo"
>> +QEMU_EXTRAOPTIONS_core2-64 = " -cpu Nehalem,check=false"
>>
>>  AVAILTUNES += "core2-64-x32"
>>  TUNE_FEATURES:tune-core2-64-x32 = "${TUNE_FEATURES:tune-x86-64-x32} core2"
>>  BASE_LIB:tune-core2-64-x32 = "libx32"
>>  TUNE_PKGARCH:tune-core2-64-x32 = "core2-64-x32"
>>  PACKAGE_EXTRA_ARCHS:tune-core2-64-x32 = "${PACKAGE_EXTRA_ARCHS:tune-x86-64-x32} core2-64-x32"
>> -QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu core2duo"
>> +QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu Nehalem,check=false"
>> --
>> 2.39.2
>>
>>
>>
>>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#193886): https://lists.openembedded.org/g/openembedded-core/message/193886
> Mute This Topic: https://lists.openembedded.org/mt/103771791/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/conf/machine/include/x86/tune-core2.inc b/meta/conf/machine/include/x86/tune-core2.inc
index 97b7c1b188..082fd4efc3 100644
--- a/meta/conf/machine/include/x86/tune-core2.inc
+++ b/meta/conf/machine/include/x86/tune-core2.inc
@@ -21,18 +21,18 @@  TUNE_FEATURES:tune-core2-32 = "${TUNE_FEATURES:tune-x86} core2"
 BASE_LIB:tune-core2-32 = "lib"
 TUNE_PKGARCH:tune-core2-32 = "core2-32"
 PACKAGE_EXTRA_ARCHS:tune-core2-32 = "${PACKAGE_EXTRA_ARCHS:tune-i686} core2-32"
-QEMU_EXTRAOPTIONS_core2-32 = " -cpu n270"
+QEMU_EXTRAOPTIONS_core2-32 = " -cpu Nehalem,check=false"
 
 AVAILTUNES += "core2-64"
 TUNE_FEATURES:tune-core2-64 = "${TUNE_FEATURES:tune-x86-64} core2"
 BASE_LIB:tune-core2-64 = "lib64"
 TUNE_PKGARCH:tune-core2-64 = "core2-64"
 PACKAGE_EXTRA_ARCHS:tune-core2-64 = "${PACKAGE_EXTRA_ARCHS:tune-x86-64} core2-64"
-QEMU_EXTRAOPTIONS_core2-64 = " -cpu core2duo"
+QEMU_EXTRAOPTIONS_core2-64 = " -cpu Nehalem,check=false"
 
 AVAILTUNES += "core2-64-x32"
 TUNE_FEATURES:tune-core2-64-x32 = "${TUNE_FEATURES:tune-x86-64-x32} core2"
 BASE_LIB:tune-core2-64-x32 = "libx32"
 TUNE_PKGARCH:tune-core2-64-x32 = "core2-64-x32"
 PACKAGE_EXTRA_ARCHS:tune-core2-64-x32 = "${PACKAGE_EXTRA_ARCHS:tune-x86-64-x32} core2-64-x32"
-QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu core2duo"
+QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu Nehalem,check=false"