| Message ID | 20231208140349.3576-3-alex.kiernan@gmail.com |
|---|---|
| State | Accepted, archived |
| Commit | ad4369d7901c1239e5f07473b1f2517edc4a23ea |
| Headers | show |
| Series | [1/7] rust: Disable rust oe-selftest | expand |
On Fri, 2023-12-08 at 14:03 +0000, Alex Kiernan wrote: > https://blog.rust-lang.org/2023/08/03/Rust-1.71.1.html > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> > --- > > meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} | 0 > .../rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} | 0 > ...t-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} | 0 > .../rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} | 0 > meta/recipes-devtools/rust/rust-source.inc | 2 +- > meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} | 0 > 6 files changed, 1 insertion(+), 1 deletion(-) > rename meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} (100%) > rename meta/recipes-devtools/rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} (100%) > rename meta/recipes-devtools/rust/{rust-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} (100%) > rename meta/recipes-devtools/rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} (100%) > rename meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} (100%) > > diff --git a/meta/recipes-devtools/rust/cargo_1.71.0.bb b/meta/recipes-devtools/rust/cargo_1.71.1.bb > similarity index 100% > rename from meta/recipes-devtools/rust/cargo_1.71.0.bb > rename to meta/recipes-devtools/rust/cargo_1.71.1.bb > diff --git a/meta/recipes-devtools/rust/libstd-rs_1.71.0.bb b/meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > similarity index 100% > rename from meta/recipes-devtools/rust/libstd-rs_1.71.0.bb > rename to meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > diff --git a/meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb b/meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb > similarity index 100% > rename from meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb > rename to meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb > diff --git a/meta/recipes-devtools/rust/rust-llvm_1.71.0.bb b/meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > similarity index 100% > rename from meta/recipes-devtools/rust/rust-llvm_1.71.0.bb > rename to meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > diff --git a/meta/recipes-devtools/rust/rust-source.inc b/meta/recipes-devtools/rust/rust-source.inc > index 3a192e42db7d..0729db6f0b45 100644 > --- a/meta/recipes-devtools/rust/rust-source.inc > +++ b/meta/recipes-devtools/rust/rust-source.inc > @@ -7,7 +7,7 @@ SRC_URI += "https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n > file://zlib-off64_t.patch;patchdir=${RUSTSRC} \ > file://0001-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} \ > " > -SRC_URI[rust.sha256sum] = "5814699031aafdcc2e2f71fc9b389678cd7042350d1583da061463d8e88681c7" > +SRC_URI[rust.sha256sum] = "371af0fbe04051e20a74dbea6d4e4e548f10f15309c49cae2688afb882b6c7f1" > > RUSTSRC = "${WORKDIR}/rustc-${RUST_VERSION}-src" > > diff --git a/meta/recipes-devtools/rust/rust_1.71.0.bb b/meta/recipes-devtools/rust/rust_1.71.1.bb > similarity index 100% > rename from meta/recipes-devtools/rust/rust_1.71.0.bb > rename to meta/recipes-devtools/rust/rust_1.71.1.bb I ran some testing and it looks like we could merge up to 1.71.1 without autobuilder failures in this series. Beyond that we have the reproducibility and zvariant issues. Cheers, Richard
On Sun, Dec 10, 2023 at 7:39 PM Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > > On Fri, 2023-12-08 at 14:03 +0000, Alex Kiernan wrote: > > https://blog.rust-lang.org/2023/08/03/Rust-1.71.1.html > > > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> > > --- > > > > meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} | 0 > > .../rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} | 0 > > ...t-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} | 0 > > .../rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} | 0 > > meta/recipes-devtools/rust/rust-source.inc | 2 +- > > meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} | 0 > > 6 files changed, 1 insertion(+), 1 deletion(-) > > rename meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} (100%) > > rename meta/recipes-devtools/rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} (100%) > > rename meta/recipes-devtools/rust/{rust-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} (100%) > > rename meta/recipes-devtools/rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} (100%) > > rename meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} (100%) > > > > diff --git a/meta/recipes-devtools/rust/cargo_1.71.0.bb b/meta/recipes-devtools/rust/cargo_1.71.1.bb > > similarity index 100% > > rename from meta/recipes-devtools/rust/cargo_1.71.0.bb > > rename to meta/recipes-devtools/rust/cargo_1.71.1.bb > > diff --git a/meta/recipes-devtools/rust/libstd-rs_1.71.0.bb b/meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > > similarity index 100% > > rename from meta/recipes-devtools/rust/libstd-rs_1.71.0.bb > > rename to meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > > diff --git a/meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb b/meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb > > similarity index 100% > > rename from meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb > > rename to meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb > > diff --git a/meta/recipes-devtools/rust/rust-llvm_1.71.0.bb b/meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > > similarity index 100% > > rename from meta/recipes-devtools/rust/rust-llvm_1.71.0.bb > > rename to meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > > diff --git a/meta/recipes-devtools/rust/rust-source.inc b/meta/recipes-devtools/rust/rust-source.inc > > index 3a192e42db7d..0729db6f0b45 100644 > > --- a/meta/recipes-devtools/rust/rust-source.inc > > +++ b/meta/recipes-devtools/rust/rust-source.inc > > @@ -7,7 +7,7 @@ SRC_URI += "https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n > > file://zlib-off64_t.patch;patchdir=${RUSTSRC} \ > > file://0001-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} \ > > " > > -SRC_URI[rust.sha256sum] = "5814699031aafdcc2e2f71fc9b389678cd7042350d1583da061463d8e88681c7" > > +SRC_URI[rust.sha256sum] = "371af0fbe04051e20a74dbea6d4e4e548f10f15309c49cae2688afb882b6c7f1" > > > > RUSTSRC = "${WORKDIR}/rustc-${RUST_VERSION}-src" > > > > diff --git a/meta/recipes-devtools/rust/rust_1.71.0.bb b/meta/recipes-devtools/rust/rust_1.71.1.bb > > similarity index 100% > > rename from meta/recipes-devtools/rust/rust_1.71.0.bb > > rename to meta/recipes-devtools/rust/rust_1.71.1.bb > > I ran some testing and it looks like we could merge up to 1.71.1 > without autobuilder failures in this series. Beyond that we have the > reproducibility and zvariant issues. > Thanks. Was the failure at that point reproducibility or the zvariant trait failure? I just posted an update for zvariant which doesn't see the trait recursion failure, but at the same time it no longer exercises crates pulled from git which looked like it was the main purpose it was fulfilling for testing.
On Sun, 2023-12-10 at 20:28 +0000, Alex Kiernan wrote: > On Sun, Dec 10, 2023 at 7:39 PM Richard Purdie > <richard.purdie@linuxfoundation.org> wrote: > > > > On Fri, 2023-12-08 at 14:03 +0000, Alex Kiernan wrote: > > > https://blog.rust-lang.org/2023/08/03/Rust-1.71.1.html > > > > > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> > > > --- > > > > > > meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} | 0 > > > .../rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} | 0 > > > ...t-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} | 0 > > > .../rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} | 0 > > > meta/recipes-devtools/rust/rust-source.inc | 2 +- > > > meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} | 0 > > > 6 files changed, 1 insertion(+), 1 deletion(-) > > > rename meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} (100%) > > > rename meta/recipes-devtools/rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} (100%) > > > rename meta/recipes-devtools/rust/{rust-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} (100%) > > > rename meta/recipes-devtools/rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} (100%) > > > rename meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} (100%) > > > > > > diff --git a/meta/recipes-devtools/rust/cargo_1.71.0.bb b/meta/recipes-devtools/rust/cargo_1.71.1.bb > > > similarity index 100% > > > rename from meta/recipes-devtools/rust/cargo_1.71.0.bb > > > rename to meta/recipes-devtools/rust/cargo_1.71.1.bb > > > diff --git a/meta/recipes-devtools/rust/libstd-rs_1.71.0.bb b/meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > > > similarity index 100% > > > rename from meta/recipes-devtools/rust/libstd-rs_1.71.0.bb > > > rename to meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > > > diff --git a/meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb b/meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb > > > similarity index 100% > > > rename from meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb > > > rename to meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb > > > diff --git a/meta/recipes-devtools/rust/rust-llvm_1.71.0.bb b/meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > > > similarity index 100% > > > rename from meta/recipes-devtools/rust/rust-llvm_1.71.0.bb > > > rename to meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > > > diff --git a/meta/recipes-devtools/rust/rust-source.inc b/meta/recipes-devtools/rust/rust-source.inc > > > index 3a192e42db7d..0729db6f0b45 100644 > > > --- a/meta/recipes-devtools/rust/rust-source.inc > > > +++ b/meta/recipes-devtools/rust/rust-source.inc > > > @@ -7,7 +7,7 @@ SRC_URI += "https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n > > > file://zlib-off64_t.patch;patchdir=${RUSTSRC} \ > > > file://0001-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} \ > > > " > > > -SRC_URI[rust.sha256sum] = "5814699031aafdcc2e2f71fc9b389678cd7042350d1583da061463d8e88681c7" > > > +SRC_URI[rust.sha256sum] = "371af0fbe04051e20a74dbea6d4e4e548f10f15309c49cae2688afb882b6c7f1" > > > > > > RUSTSRC = "${WORKDIR}/rustc-${RUST_VERSION}-src" > > > > > > diff --git a/meta/recipes-devtools/rust/rust_1.71.0.bb b/meta/recipes-devtools/rust/rust_1.71.1.bb > > > similarity index 100% > > > rename from meta/recipes-devtools/rust/rust_1.71.0.bb > > > rename to meta/recipes-devtools/rust/rust_1.71.1.bb > > > > I ran some testing and it looks like we could merge up to 1.71.1 > > without autobuilder failures in this series. Beyond that we have the > > reproducibility and zvariant issues. > > > > Thanks. > > Was the failure at that point reproducibility or the zvariant trait > failure? I just posted an update for zvariant which doesn't see the > trait recursion failure, but at the same time it no longer exercises > crates pulled from git which looked like it was the main purpose it > was fulfilling for testing. Both I think and yes, the argument for zvariant was that it allowed us the crate testing :/. Cheers, Richard
On Sun, 10 Dec 2023 at 21:28, Alex Kiernan <alex.kiernan@gmail.com> wrote: > On Sun, Dec 10, 2023 at 7:39 PM Richard Purdie > <richard.purdie@linuxfoundation.org> wrote: > > > > On Fri, 2023-12-08 at 14:03 +0000, Alex Kiernan wrote: > > > https://blog.rust-lang.org/2023/08/03/Rust-1.71.1.html > > > > > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> > > > --- > > > > > > meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} | 0 > > > .../rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} | 0 > > > ...t-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} | 0 > > > .../rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} | 0 > > > meta/recipes-devtools/rust/rust-source.inc | 2 +- > > > meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} | 0 > > > 6 files changed, 1 insertion(+), 1 deletion(-) > > > rename meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} > (100%) > > > rename meta/recipes-devtools/rust/{libstd-rs_1.71.0.bb => > libstd-rs_1.71.1.bb} (100%) > > > rename meta/recipes-devtools/rust/{rust-cross-canadian_1.71.0.bb => > rust-cross-canadian_1.71.1.bb} (100%) > > > rename meta/recipes-devtools/rust/{rust-llvm_1.71.0.bb => > rust-llvm_1.71.1.bb} (100%) > > > rename meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} > (100%) > > > > > > diff --git a/meta/recipes-devtools/rust/cargo_1.71.0.bb > b/meta/recipes-devtools/rust/cargo_1.71.1.bb > > > similarity index 100% > > > rename from meta/recipes-devtools/rust/cargo_1.71.0.bb > > > rename to meta/recipes-devtools/rust/cargo_1.71.1.bb > > > diff --git a/meta/recipes-devtools/rust/libstd-rs_1.71.0.bb > b/meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > > > similarity index 100% > > > rename from meta/recipes-devtools/rust/libstd-rs_1.71.0.bb > > > rename to meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > > > diff --git a/meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb > b/meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb > > > similarity index 100% > > > rename from meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb > > > rename to meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb > > > diff --git a/meta/recipes-devtools/rust/rust-llvm_1.71.0.bb > b/meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > > > similarity index 100% > > > rename from meta/recipes-devtools/rust/rust-llvm_1.71.0.bb > > > rename to meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > > > diff --git a/meta/recipes-devtools/rust/rust-source.inc > b/meta/recipes-devtools/rust/rust-source.inc > > > index 3a192e42db7d..0729db6f0b45 100644 > > > --- a/meta/recipes-devtools/rust/rust-source.inc > > > +++ b/meta/recipes-devtools/rust/rust-source.inc > > > @@ -7,7 +7,7 @@ SRC_URI += " > https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n > > > file://zlib-off64_t.patch;patchdir=${RUSTSRC} \ > > > > file://0001-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} > \ > > > " > > > -SRC_URI[rust.sha256sum] = > "5814699031aafdcc2e2f71fc9b389678cd7042350d1583da061463d8e88681c7" > > > +SRC_URI[rust.sha256sum] = > "371af0fbe04051e20a74dbea6d4e4e548f10f15309c49cae2688afb882b6c7f1" > > > > > > RUSTSRC = "${WORKDIR}/rustc-${RUST_VERSION}-src" > > > > > > diff --git a/meta/recipes-devtools/rust/rust_1.71.0.bb > b/meta/recipes-devtools/rust/rust_1.71.1.bb > > > similarity index 100% > > > rename from meta/recipes-devtools/rust/rust_1.71.0.bb > > > rename to meta/recipes-devtools/rust/rust_1.71.1.bb > > > > I ran some testing and it looks like we could merge up to 1.71.1 > > without autobuilder failures in this series. Beyond that we have the > > reproducibility and zvariant issues. > > > > Thanks. > > Was the failure at that point reproducibility or the zvariant trait > failure? I just posted an update for zvariant which doesn't see the > trait recursion failure, but at the same time it no longer exercises > crates pulled from git which looked like it was the main purpose it > was fulfilling for testing. > > I didn't follow issues about this upgrade, but yes, the zvariant recipe was a demonstration on how to handle crates dependencies that come from git. (there is a specific crate fetcher url parameter: 'git-dependency') If, for some reason, this is no more possible, the whole recipe can be removed (unless there is a direct dependency to zvariant in some other recipes) > -- > Alex Kiernan > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#192125): > https://lists.openembedded.org/g/openembedded-core/message/192125 > Mute This Topic: https://lists.openembedded.org/mt/103055164/6213388 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > frederic.martinsons@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Mon, Dec 11, 2023 at 7:15 AM Frédéric Martinsons <frederic.martinsons@gmail.com> wrote: > > > > On Sun, 10 Dec 2023 at 21:28, Alex Kiernan <alex.kiernan@gmail.com> wrote: >> >> On Sun, Dec 10, 2023 at 7:39 PM Richard Purdie >> <richard.purdie@linuxfoundation.org> wrote: >> > >> > On Fri, 2023-12-08 at 14:03 +0000, Alex Kiernan wrote: >> > > https://blog.rust-lang.org/2023/08/03/Rust-1.71.1.html >> > > >> > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> >> > > --- >> > > >> > > meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} | 0 >> > > .../rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} | 0 >> > > ...t-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} | 0 >> > > .../rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} | 0 >> > > meta/recipes-devtools/rust/rust-source.inc | 2 +- >> > > meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} | 0 >> > > 6 files changed, 1 insertion(+), 1 deletion(-) >> > > rename meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} (100%) >> > > rename meta/recipes-devtools/rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} (100%) >> > > rename meta/recipes-devtools/rust/{rust-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} (100%) >> > > rename meta/recipes-devtools/rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} (100%) >> > > rename meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} (100%) >> > > >> > > diff --git a/meta/recipes-devtools/rust/cargo_1.71.0.bb b/meta/recipes-devtools/rust/cargo_1.71.1.bb >> > > similarity index 100% >> > > rename from meta/recipes-devtools/rust/cargo_1.71.0.bb >> > > rename to meta/recipes-devtools/rust/cargo_1.71.1.bb >> > > diff --git a/meta/recipes-devtools/rust/libstd-rs_1.71.0.bb b/meta/recipes-devtools/rust/libstd-rs_1.71.1.bb >> > > similarity index 100% >> > > rename from meta/recipes-devtools/rust/libstd-rs_1.71.0.bb >> > > rename to meta/recipes-devtools/rust/libstd-rs_1.71.1.bb >> > > diff --git a/meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb b/meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb >> > > similarity index 100% >> > > rename from meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb >> > > rename to meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb >> > > diff --git a/meta/recipes-devtools/rust/rust-llvm_1.71.0.bb b/meta/recipes-devtools/rust/rust-llvm_1.71.1.bb >> > > similarity index 100% >> > > rename from meta/recipes-devtools/rust/rust-llvm_1.71.0.bb >> > > rename to meta/recipes-devtools/rust/rust-llvm_1.71.1.bb >> > > diff --git a/meta/recipes-devtools/rust/rust-source.inc b/meta/recipes-devtools/rust/rust-source.inc >> > > index 3a192e42db7d..0729db6f0b45 100644 >> > > --- a/meta/recipes-devtools/rust/rust-source.inc >> > > +++ b/meta/recipes-devtools/rust/rust-source.inc >> > > @@ -7,7 +7,7 @@ SRC_URI += "https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n >> > > file://zlib-off64_t.patch;patchdir=${RUSTSRC} \ >> > > file://0001-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} \ >> > > " >> > > -SRC_URI[rust.sha256sum] = "5814699031aafdcc2e2f71fc9b389678cd7042350d1583da061463d8e88681c7" >> > > +SRC_URI[rust.sha256sum] = "371af0fbe04051e20a74dbea6d4e4e548f10f15309c49cae2688afb882b6c7f1" >> > > >> > > RUSTSRC = "${WORKDIR}/rustc-${RUST_VERSION}-src" >> > > >> > > diff --git a/meta/recipes-devtools/rust/rust_1.71.0.bb b/meta/recipes-devtools/rust/rust_1.71.1.bb >> > > similarity index 100% >> > > rename from meta/recipes-devtools/rust/rust_1.71.0.bb >> > > rename to meta/recipes-devtools/rust/rust_1.71.1.bb >> > >> > I ran some testing and it looks like we could merge up to 1.71.1 >> > without autobuilder failures in this series. Beyond that we have the >> > reproducibility and zvariant issues. >> > >> >> Thanks. >> >> Was the failure at that point reproducibility or the zvariant trait >> failure? I just posted an update for zvariant which doesn't see the >> trait recursion failure, but at the same time it no longer exercises >> crates pulled from git which looked like it was the main purpose it >> was fulfilling for testing. >> > I didn't follow issues about this upgrade, but yes, the zvariant recipe > was a demonstration on how to handle crates dependencies that come from git. > (there is a specific crate fetcher url parameter: 'git-dependency') > 3.12 (which was what we had) exploded with unbounded recursion inside a trait on later compilers, upgrading to 3.15 fixes it, but they've dropped the git dependency crate and just used upstream crates: commit 9e34dd510bf1a50f5168d5164578ebe8958928e3 Author: Zeeshan Ali Khan <zeeshanak@gnome.org> Date: Wed May 10 20:45:26 2023 +0200 zv: Swtich glib from git to latest released version We don't need the git version and cargo caching action doesn't help with cloning of git repos so the build takes longer in the CI than it needs to. > If, for some reason, this is no more possible, the whole recipe can be removed > (unless there is a direct dependency to zvariant in some other recipes) > Sounds like just deleting it might be the thing to do. I did go on a search for something else which had git dependency crates and didn't find anything (and I suspect even if we did, we might well be back here in 6 months if upstream churn deletes it). Maybe we just need something synthetic which is used here?
On Mon, 11 Dec 2023 at 10:17, Alex Kiernan <alex.kiernan@gmail.com> wrote: > On Mon, Dec 11, 2023 at 7:15 AM Frédéric Martinsons > <frederic.martinsons@gmail.com> wrote: > > > > > > > > On Sun, 10 Dec 2023 at 21:28, Alex Kiernan <alex.kiernan@gmail.com> > wrote: > >> > >> On Sun, Dec 10, 2023 at 7:39 PM Richard Purdie > >> <richard.purdie@linuxfoundation.org> wrote: > >> > > >> > On Fri, 2023-12-08 at 14:03 +0000, Alex Kiernan wrote: > >> > > https://blog.rust-lang.org/2023/08/03/Rust-1.71.1.html > >> > > > >> > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> > >> > > --- > >> > > > >> > > meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} | > 0 > >> > > .../rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} | > 0 > >> > > ...t-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} | > 0 > >> > > .../rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} | > 0 > >> > > meta/recipes-devtools/rust/rust-source.inc | > 2 +- > >> > > meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} | > 0 > >> > > 6 files changed, 1 insertion(+), 1 deletion(-) > >> > > rename meta/recipes-devtools/rust/{cargo_1.71.0.bb => > cargo_1.71.1.bb} (100%) > >> > > rename meta/recipes-devtools/rust/{libstd-rs_1.71.0.bb => > libstd-rs_1.71.1.bb} (100%) > >> > > rename meta/recipes-devtools/rust/{rust-cross-canadian_1.71.0.bb > => rust-cross-canadian_1.71.1.bb} (100%) > >> > > rename meta/recipes-devtools/rust/{rust-llvm_1.71.0.bb => > rust-llvm_1.71.1.bb} (100%) > >> > > rename meta/recipes-devtools/rust/{rust_1.71.0.bb => > rust_1.71.1.bb} (100%) > >> > > > >> > > diff --git a/meta/recipes-devtools/rust/cargo_1.71.0.bb > b/meta/recipes-devtools/rust/cargo_1.71.1.bb > >> > > similarity index 100% > >> > > rename from meta/recipes-devtools/rust/cargo_1.71.0.bb > >> > > rename to meta/recipes-devtools/rust/cargo_1.71.1.bb > >> > > diff --git a/meta/recipes-devtools/rust/libstd-rs_1.71.0.bb > b/meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > >> > > similarity index 100% > >> > > rename from meta/recipes-devtools/rust/libstd-rs_1.71.0.bb > >> > > rename to meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > >> > > diff --git a/meta/recipes-devtools/rust/ > rust-cross-canadian_1.71.0.bb b/meta/recipes-devtools/rust/ > rust-cross-canadian_1.71.1.bb > >> > > similarity index 100% > >> > > rename from meta/recipes-devtools/rust/ > rust-cross-canadian_1.71.0.bb > >> > > rename to meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb > >> > > diff --git a/meta/recipes-devtools/rust/rust-llvm_1.71.0.bb > b/meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > >> > > similarity index 100% > >> > > rename from meta/recipes-devtools/rust/rust-llvm_1.71.0.bb > >> > > rename to meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > >> > > diff --git a/meta/recipes-devtools/rust/rust-source.inc > b/meta/recipes-devtools/rust/rust-source.inc > >> > > index 3a192e42db7d..0729db6f0b45 100644 > >> > > --- a/meta/recipes-devtools/rust/rust-source.inc > >> > > +++ b/meta/recipes-devtools/rust/rust-source.inc > >> > > @@ -7,7 +7,7 @@ SRC_URI += " > https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n > >> > > file://zlib-off64_t.patch;patchdir=${RUSTSRC} \ > >> > > > file://0001-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} > \ > >> > > " > >> > > -SRC_URI[rust.sha256sum] = > "5814699031aafdcc2e2f71fc9b389678cd7042350d1583da061463d8e88681c7" > >> > > +SRC_URI[rust.sha256sum] = > "371af0fbe04051e20a74dbea6d4e4e548f10f15309c49cae2688afb882b6c7f1" > >> > > > >> > > RUSTSRC = "${WORKDIR}/rustc-${RUST_VERSION}-src" > >> > > > >> > > diff --git a/meta/recipes-devtools/rust/rust_1.71.0.bb > b/meta/recipes-devtools/rust/rust_1.71.1.bb > >> > > similarity index 100% > >> > > rename from meta/recipes-devtools/rust/rust_1.71.0.bb > >> > > rename to meta/recipes-devtools/rust/rust_1.71.1.bb > >> > > >> > I ran some testing and it looks like we could merge up to 1.71.1 > >> > without autobuilder failures in this series. Beyond that we have the > >> > reproducibility and zvariant issues. > >> > > >> > >> Thanks. > >> > >> Was the failure at that point reproducibility or the zvariant trait > >> failure? I just posted an update for zvariant which doesn't see the > >> trait recursion failure, but at the same time it no longer exercises > >> crates pulled from git which looked like it was the main purpose it > >> was fulfilling for testing. > >> > > I didn't follow issues about this upgrade, but yes, the zvariant recipe > > was a demonstration on how to handle crates dependencies that come from > git. > > (there is a specific crate fetcher url parameter: 'git-dependency') > > > > 3.12 (which was what we had) exploded with unbounded recursion inside > a trait on later compilers, upgrading to 3.15 fixes it, but they've > dropped the git dependency crate and just used upstream crates: > > commit 9e34dd510bf1a50f5168d5164578ebe8958928e3 > Author: Zeeshan Ali Khan <zeeshanak@gnome.org> > Date: Wed May 10 20:45:26 2023 +0200 > > zv: Swtich glib from git to latest released version > > We don't need the git version and cargo caching action doesn't help > with > cloning of git repos so the build takes longer in the CI than it needs > to. > > > If, for some reason, this is no more possible, the whole recipe can be > removed > > (unless there is a direct dependency to zvariant in some other recipes) > > > > Sounds like just deleting it might be the thing to do. I did go on a > search for something else which had git dependency crates and didn't > find anything (and I suspect even if we did, we might well be back > here in 6 months if upstream churn deletes it). Maybe we just need > something synthetic which is used here? > I can come up with a simple recipe which will have sources locally and a dependencies to some of crates fetched by git if you think it would be useful. I have lot of these kind (git crate dependency) because we have internally a lot of unpublished (private) crates in our git repo. > -- > Alex Kiernan >
On Mon, Dec 11, 2023 at 10:01 AM Frédéric Martinsons <frederic.martinsons@gmail.com> wrote: > > > > On Mon, 11 Dec 2023 at 10:17, Alex Kiernan <alex.kiernan@gmail.com> wrote: >> >> On Mon, Dec 11, 2023 at 7:15 AM Frédéric Martinsons >> <frederic.martinsons@gmail.com> wrote: >> > >> > >> > >> > On Sun, 10 Dec 2023 at 21:28, Alex Kiernan <alex.kiernan@gmail.com> wrote: >> >> >> >> On Sun, Dec 10, 2023 at 7:39 PM Richard Purdie >> >> <richard.purdie@linuxfoundation.org> wrote: >> >> > >> >> > On Fri, 2023-12-08 at 14:03 +0000, Alex Kiernan wrote: >> >> > > https://blog.rust-lang.org/2023/08/03/Rust-1.71.1.html >> >> > > >> >> > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> >> >> > > --- >> >> > > >> >> > > meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} | 0 >> >> > > .../rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} | 0 >> >> > > ...t-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} | 0 >> >> > > .../rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} | 0 >> >> > > meta/recipes-devtools/rust/rust-source.inc | 2 +- >> >> > > meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} | 0 >> >> > > 6 files changed, 1 insertion(+), 1 deletion(-) >> >> > > rename meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} (100%) >> >> > > rename meta/recipes-devtools/rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} (100%) >> >> > > rename meta/recipes-devtools/rust/{rust-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} (100%) >> >> > > rename meta/recipes-devtools/rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} (100%) >> >> > > rename meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} (100%) >> >> > > >> >> > > diff --git a/meta/recipes-devtools/rust/cargo_1.71.0.bb b/meta/recipes-devtools/rust/cargo_1.71.1.bb >> >> > > similarity index 100% >> >> > > rename from meta/recipes-devtools/rust/cargo_1.71.0.bb >> >> > > rename to meta/recipes-devtools/rust/cargo_1.71.1.bb >> >> > > diff --git a/meta/recipes-devtools/rust/libstd-rs_1.71.0.bb b/meta/recipes-devtools/rust/libstd-rs_1.71.1.bb >> >> > > similarity index 100% >> >> > > rename from meta/recipes-devtools/rust/libstd-rs_1.71.0.bb >> >> > > rename to meta/recipes-devtools/rust/libstd-rs_1.71.1.bb >> >> > > diff --git a/meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb b/meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb >> >> > > similarity index 100% >> >> > > rename from meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb >> >> > > rename to meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb >> >> > > diff --git a/meta/recipes-devtools/rust/rust-llvm_1.71.0.bb b/meta/recipes-devtools/rust/rust-llvm_1.71.1.bb >> >> > > similarity index 100% >> >> > > rename from meta/recipes-devtools/rust/rust-llvm_1.71.0.bb >> >> > > rename to meta/recipes-devtools/rust/rust-llvm_1.71.1.bb >> >> > > diff --git a/meta/recipes-devtools/rust/rust-source.inc b/meta/recipes-devtools/rust/rust-source.inc >> >> > > index 3a192e42db7d..0729db6f0b45 100644 >> >> > > --- a/meta/recipes-devtools/rust/rust-source.inc >> >> > > +++ b/meta/recipes-devtools/rust/rust-source.inc >> >> > > @@ -7,7 +7,7 @@ SRC_URI += "https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n >> >> > > file://zlib-off64_t.patch;patchdir=${RUSTSRC} \ >> >> > > file://0001-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} \ >> >> > > " >> >> > > -SRC_URI[rust.sha256sum] = "5814699031aafdcc2e2f71fc9b389678cd7042350d1583da061463d8e88681c7" >> >> > > +SRC_URI[rust.sha256sum] = "371af0fbe04051e20a74dbea6d4e4e548f10f15309c49cae2688afb882b6c7f1" >> >> > > >> >> > > RUSTSRC = "${WORKDIR}/rustc-${RUST_VERSION}-src" >> >> > > >> >> > > diff --git a/meta/recipes-devtools/rust/rust_1.71.0.bb b/meta/recipes-devtools/rust/rust_1.71.1.bb >> >> > > similarity index 100% >> >> > > rename from meta/recipes-devtools/rust/rust_1.71.0.bb >> >> > > rename to meta/recipes-devtools/rust/rust_1.71.1.bb >> >> > >> >> > I ran some testing and it looks like we could merge up to 1.71.1 >> >> > without autobuilder failures in this series. Beyond that we have the >> >> > reproducibility and zvariant issues. >> >> > >> >> >> >> Thanks. >> >> >> >> Was the failure at that point reproducibility or the zvariant trait >> >> failure? I just posted an update for zvariant which doesn't see the >> >> trait recursion failure, but at the same time it no longer exercises >> >> crates pulled from git which looked like it was the main purpose it >> >> was fulfilling for testing. >> >> >> > I didn't follow issues about this upgrade, but yes, the zvariant recipe >> > was a demonstration on how to handle crates dependencies that come from git. >> > (there is a specific crate fetcher url parameter: 'git-dependency') >> > >> >> 3.12 (which was what we had) exploded with unbounded recursion inside >> a trait on later compilers, upgrading to 3.15 fixes it, but they've >> dropped the git dependency crate and just used upstream crates: >> >> commit 9e34dd510bf1a50f5168d5164578ebe8958928e3 >> Author: Zeeshan Ali Khan <zeeshanak@gnome.org> >> Date: Wed May 10 20:45:26 2023 +0200 >> >> zv: Swtich glib from git to latest released version >> >> We don't need the git version and cargo caching action doesn't help with >> cloning of git repos so the build takes longer in the CI than it needs >> to. >> >> > If, for some reason, this is no more possible, the whole recipe can be removed >> > (unless there is a direct dependency to zvariant in some other recipes) >> > >> >> Sounds like just deleting it might be the thing to do. I did go on a >> search for something else which had git dependency crates and didn't >> find anything (and I suspect even if we did, we might well be back >> here in 6 months if upstream churn deletes it). Maybe we just need >> something synthetic which is used here? > > > I can come up with a simple recipe which will have sources locally > and a dependencies to some of crates fetched by git if you think > it would be useful. > > I have lot of these kind (git crate dependency) because we have internally a lot of unpublished (private) > crates in our git repo. > Just discovered we have one in meta-oe - thin-provisioning-tools uses a git dep. Though for test purposes in oe-core, I think I'd still lean towards something synthetic which we know won't move.
On Mon, 11 Dec 2023 at 12:44, Alex Kiernan <alex.kiernan@gmail.com> wrote: > On Mon, Dec 11, 2023 at 10:01 AM Frédéric Martinsons > <frederic.martinsons@gmail.com> wrote: > > > > > > > > On Mon, 11 Dec 2023 at 10:17, Alex Kiernan <alex.kiernan@gmail.com> > wrote: > >> > >> On Mon, Dec 11, 2023 at 7:15 AM Frédéric Martinsons > >> <frederic.martinsons@gmail.com> wrote: > >> > > >> > > >> > > >> > On Sun, 10 Dec 2023 at 21:28, Alex Kiernan <alex.kiernan@gmail.com> > wrote: > >> >> > >> >> On Sun, Dec 10, 2023 at 7:39 PM Richard Purdie > >> >> <richard.purdie@linuxfoundation.org> wrote: > >> >> > > >> >> > On Fri, 2023-12-08 at 14:03 +0000, Alex Kiernan wrote: > >> >> > > https://blog.rust-lang.org/2023/08/03/Rust-1.71.1.html > >> >> > > > >> >> > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> > >> >> > > --- > >> >> > > > >> >> > > meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} > | 0 > >> >> > > .../rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} > | 0 > >> >> > > ...t-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} > | 0 > >> >> > > .../rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} > | 0 > >> >> > > meta/recipes-devtools/rust/rust-source.inc > | 2 +- > >> >> > > meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} > | 0 > >> >> > > 6 files changed, 1 insertion(+), 1 deletion(-) > >> >> > > rename meta/recipes-devtools/rust/{cargo_1.71.0.bb => > cargo_1.71.1.bb} (100%) > >> >> > > rename meta/recipes-devtools/rust/{libstd-rs_1.71.0.bb => > libstd-rs_1.71.1.bb} (100%) > >> >> > > rename meta/recipes-devtools/rust/{ > rust-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} (100%) > >> >> > > rename meta/recipes-devtools/rust/{rust-llvm_1.71.0.bb => > rust-llvm_1.71.1.bb} (100%) > >> >> > > rename meta/recipes-devtools/rust/{rust_1.71.0.bb => > rust_1.71.1.bb} (100%) > >> >> > > > >> >> > > diff --git a/meta/recipes-devtools/rust/cargo_1.71.0.bb > b/meta/recipes-devtools/rust/cargo_1.71.1.bb > >> >> > > similarity index 100% > >> >> > > rename from meta/recipes-devtools/rust/cargo_1.71.0.bb > >> >> > > rename to meta/recipes-devtools/rust/cargo_1.71.1.bb > >> >> > > diff --git a/meta/recipes-devtools/rust/libstd-rs_1.71.0.bb > b/meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > >> >> > > similarity index 100% > >> >> > > rename from meta/recipes-devtools/rust/libstd-rs_1.71.0.bb > >> >> > > rename to meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > >> >> > > diff --git a/meta/recipes-devtools/rust/ > rust-cross-canadian_1.71.0.bb b/meta/recipes-devtools/rust/ > rust-cross-canadian_1.71.1.bb > >> >> > > similarity index 100% > >> >> > > rename from meta/recipes-devtools/rust/ > rust-cross-canadian_1.71.0.bb > >> >> > > rename to meta/recipes-devtools/rust/ > rust-cross-canadian_1.71.1.bb > >> >> > > diff --git a/meta/recipes-devtools/rust/rust-llvm_1.71.0.bb > b/meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > >> >> > > similarity index 100% > >> >> > > rename from meta/recipes-devtools/rust/rust-llvm_1.71.0.bb > >> >> > > rename to meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > >> >> > > diff --git a/meta/recipes-devtools/rust/rust-source.inc > b/meta/recipes-devtools/rust/rust-source.inc > >> >> > > index 3a192e42db7d..0729db6f0b45 100644 > >> >> > > --- a/meta/recipes-devtools/rust/rust-source.inc > >> >> > > +++ b/meta/recipes-devtools/rust/rust-source.inc > >> >> > > @@ -7,7 +7,7 @@ SRC_URI += " > https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n > >> >> > > file://zlib-off64_t.patch;patchdir=${RUSTSRC} \ > >> >> > > > file://0001-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} > \ > >> >> > > " > >> >> > > -SRC_URI[rust.sha256sum] = > "5814699031aafdcc2e2f71fc9b389678cd7042350d1583da061463d8e88681c7" > >> >> > > +SRC_URI[rust.sha256sum] = > "371af0fbe04051e20a74dbea6d4e4e548f10f15309c49cae2688afb882b6c7f1" > >> >> > > > >> >> > > RUSTSRC = "${WORKDIR}/rustc-${RUST_VERSION}-src" > >> >> > > > >> >> > > diff --git a/meta/recipes-devtools/rust/rust_1.71.0.bb > b/meta/recipes-devtools/rust/rust_1.71.1.bb > >> >> > > similarity index 100% > >> >> > > rename from meta/recipes-devtools/rust/rust_1.71.0.bb > >> >> > > rename to meta/recipes-devtools/rust/rust_1.71.1.bb > >> >> > > >> >> > I ran some testing and it looks like we could merge up to 1.71.1 > >> >> > without autobuilder failures in this series. Beyond that we have > the > >> >> > reproducibility and zvariant issues. > >> >> > > >> >> > >> >> Thanks. > >> >> > >> >> Was the failure at that point reproducibility or the zvariant trait > >> >> failure? I just posted an update for zvariant which doesn't see the > >> >> trait recursion failure, but at the same time it no longer exercises > >> >> crates pulled from git which looked like it was the main purpose it > >> >> was fulfilling for testing. > >> >> > >> > I didn't follow issues about this upgrade, but yes, the zvariant > recipe > >> > was a demonstration on how to handle crates dependencies that come > from git. > >> > (there is a specific crate fetcher url parameter: 'git-dependency') > >> > > >> > >> 3.12 (which was what we had) exploded with unbounded recursion inside > >> a trait on later compilers, upgrading to 3.15 fixes it, but they've > >> dropped the git dependency crate and just used upstream crates: > >> > >> commit 9e34dd510bf1a50f5168d5164578ebe8958928e3 > >> Author: Zeeshan Ali Khan <zeeshanak@gnome.org> > >> Date: Wed May 10 20:45:26 2023 +0200 > >> > >> zv: Swtich glib from git to latest released version > >> > >> We don't need the git version and cargo caching action doesn't help > with > >> cloning of git repos so the build takes longer in the CI than it > needs > >> to. > >> > >> > If, for some reason, this is no more possible, the whole recipe can > be removed > >> > (unless there is a direct dependency to zvariant in some other > recipes) > >> > > >> > >> Sounds like just deleting it might be the thing to do. I did go on a > >> search for something else which had git dependency crates and didn't > >> find anything (and I suspect even if we did, we might well be back > >> here in 6 months if upstream churn deletes it). Maybe we just need > >> something synthetic which is used here? > > > > > > I can come up with a simple recipe which will have sources locally > > and a dependencies to some of crates fetched by git if you think > > it would be useful. > > > > I have lot of these kind (git crate dependency) because we have > internally a lot of unpublished (private) > > crates in our git repo. > > > > Just discovered we have one in meta-oe - thin-provisioning-tools uses > a git dep. Though for test purposes in oe-core, I think I'd still lean > towards something synthetic which we know won't move. > ok , great. > -- > Alex Kiernan >
On Sun, Dec 10, 2023 at 7:39 PM Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > > On Fri, 2023-12-08 at 14:03 +0000, Alex Kiernan wrote: > > https://blog.rust-lang.org/2023/08/03/Rust-1.71.1.html > > > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> > > --- > > > > meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} | 0 > > .../rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} | 0 > > ...t-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} | 0 > > .../rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} | 0 > > meta/recipes-devtools/rust/rust-source.inc | 2 +- > > meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} | 0 > > 6 files changed, 1 insertion(+), 1 deletion(-) > > rename meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} (100%) > > rename meta/recipes-devtools/rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} (100%) > > rename meta/recipes-devtools/rust/{rust-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} (100%) > > rename meta/recipes-devtools/rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} (100%) > > rename meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} (100%) > > > > diff --git a/meta/recipes-devtools/rust/cargo_1.71.0.bb b/meta/recipes-devtools/rust/cargo_1.71.1.bb > > similarity index 100% > > rename from meta/recipes-devtools/rust/cargo_1.71.0.bb > > rename to meta/recipes-devtools/rust/cargo_1.71.1.bb > > diff --git a/meta/recipes-devtools/rust/libstd-rs_1.71.0.bb b/meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > > similarity index 100% > > rename from meta/recipes-devtools/rust/libstd-rs_1.71.0.bb > > rename to meta/recipes-devtools/rust/libstd-rs_1.71.1.bb > > diff --git a/meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb b/meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb > > similarity index 100% > > rename from meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb > > rename to meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb > > diff --git a/meta/recipes-devtools/rust/rust-llvm_1.71.0.bb b/meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > > similarity index 100% > > rename from meta/recipes-devtools/rust/rust-llvm_1.71.0.bb > > rename to meta/recipes-devtools/rust/rust-llvm_1.71.1.bb > > diff --git a/meta/recipes-devtools/rust/rust-source.inc b/meta/recipes-devtools/rust/rust-source.inc > > index 3a192e42db7d..0729db6f0b45 100644 > > --- a/meta/recipes-devtools/rust/rust-source.inc > > +++ b/meta/recipes-devtools/rust/rust-source.inc > > @@ -7,7 +7,7 @@ SRC_URI += "https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n > > file://zlib-off64_t.patch;patchdir=${RUSTSRC} \ > > file://0001-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} \ > > " > > -SRC_URI[rust.sha256sum] = "5814699031aafdcc2e2f71fc9b389678cd7042350d1583da061463d8e88681c7" > > +SRC_URI[rust.sha256sum] = "371af0fbe04051e20a74dbea6d4e4e548f10f15309c49cae2688afb882b6c7f1" > > > > RUSTSRC = "${WORKDIR}/rustc-${RUST_VERSION}-src" > > > > diff --git a/meta/recipes-devtools/rust/rust_1.71.0.bb b/meta/recipes-devtools/rust/rust_1.71.1.bb > > similarity index 100% > > rename from meta/recipes-devtools/rust/rust_1.71.0.bb > > rename to meta/recipes-devtools/rust/rust_1.71.1.bb > > I ran some testing and it looks like we could merge up to 1.71.1 > without autobuilder failures in this series. Beyond that we have the > reproducibility and zvariant issues. > https://github.com/rust-lang/cargo/issues/8140 looks possibly relevant. I wonder if we're just getting lucky somehow.
diff --git a/meta/recipes-devtools/rust/cargo_1.71.0.bb b/meta/recipes-devtools/rust/cargo_1.71.1.bb similarity index 100% rename from meta/recipes-devtools/rust/cargo_1.71.0.bb rename to meta/recipes-devtools/rust/cargo_1.71.1.bb diff --git a/meta/recipes-devtools/rust/libstd-rs_1.71.0.bb b/meta/recipes-devtools/rust/libstd-rs_1.71.1.bb similarity index 100% rename from meta/recipes-devtools/rust/libstd-rs_1.71.0.bb rename to meta/recipes-devtools/rust/libstd-rs_1.71.1.bb diff --git a/meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb b/meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb similarity index 100% rename from meta/recipes-devtools/rust/rust-cross-canadian_1.71.0.bb rename to meta/recipes-devtools/rust/rust-cross-canadian_1.71.1.bb diff --git a/meta/recipes-devtools/rust/rust-llvm_1.71.0.bb b/meta/recipes-devtools/rust/rust-llvm_1.71.1.bb similarity index 100% rename from meta/recipes-devtools/rust/rust-llvm_1.71.0.bb rename to meta/recipes-devtools/rust/rust-llvm_1.71.1.bb diff --git a/meta/recipes-devtools/rust/rust-source.inc b/meta/recipes-devtools/rust/rust-source.inc index 3a192e42db7d..0729db6f0b45 100644 --- a/meta/recipes-devtools/rust/rust-source.inc +++ b/meta/recipes-devtools/rust/rust-source.inc @@ -7,7 +7,7 @@ SRC_URI += "https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n file://zlib-off64_t.patch;patchdir=${RUSTSRC} \ file://0001-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} \ " -SRC_URI[rust.sha256sum] = "5814699031aafdcc2e2f71fc9b389678cd7042350d1583da061463d8e88681c7" +SRC_URI[rust.sha256sum] = "371af0fbe04051e20a74dbea6d4e4e548f10f15309c49cae2688afb882b6c7f1" RUSTSRC = "${WORKDIR}/rustc-${RUST_VERSION}-src" diff --git a/meta/recipes-devtools/rust/rust_1.71.0.bb b/meta/recipes-devtools/rust/rust_1.71.1.bb similarity index 100% rename from meta/recipes-devtools/rust/rust_1.71.0.bb rename to meta/recipes-devtools/rust/rust_1.71.1.bb
https://blog.rust-lang.org/2023/08/03/Rust-1.71.1.html Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> --- meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} | 0 .../rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} | 0 ...t-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} | 0 .../rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} | 0 meta/recipes-devtools/rust/rust-source.inc | 2 +- meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} | 0 6 files changed, 1 insertion(+), 1 deletion(-) rename meta/recipes-devtools/rust/{cargo_1.71.0.bb => cargo_1.71.1.bb} (100%) rename meta/recipes-devtools/rust/{libstd-rs_1.71.0.bb => libstd-rs_1.71.1.bb} (100%) rename meta/recipes-devtools/rust/{rust-cross-canadian_1.71.0.bb => rust-cross-canadian_1.71.1.bb} (100%) rename meta/recipes-devtools/rust/{rust-llvm_1.71.0.bb => rust-llvm_1.71.1.bb} (100%) rename meta/recipes-devtools/rust/{rust_1.71.0.bb => rust_1.71.1.bb} (100%)