| Message ID | 20231208104800.4175679-2-Yash.Shinde@windriver.com |
|---|---|
| State | Accepted, archived |
| Commit | fa2d3cda8f7f932c0ed5c534c4bc820af2761cd5 |
| Headers | show |
| Series | [1/2] rust: Upgrade 1.70.0 -> 1.73.0 | expand |
On 2023-12-08 5:48 a.m., Yash.Shinde@windriver.com wrote: > From: Yash Shinde<Yash.Shinde@windriver.com> > > After rust is upgraded to 1.71 and later versions, the rust oe-selftest gives > build errors due to unstable nightly options(see the error mentioned below). Thus, disable the test suite > until the issue is fixed > > error: the option `Z` is only accepted on the nightly compiler > thread 'main' panicked at 'failed to gather the target spec for x86_64-poky-linux-gnu', synthetic_targets.rs:66:9 > > Following issues are created in Yocto bugzilla and rust upstream to track this issue- > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=15275 > https://github.com/rust-lang/rust/issues/115642 > https://users.rust-lang.org/t/does-rust-test-suite-supports-nightly-options-during-bootstrapping-in-rust/103108 > https://users.rust-lang.org/t/unable-to-read-target-specs-when-rust-1-73-is-bootstrapped-in-yocto-poky/102959 > > Signed-off-by: Yash Shinde<Yash.Shinde@windriver.com> > --- > meta/lib/oeqa/selftest/cases/rust.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta/lib/oeqa/selftest/cases/rust.py b/meta/lib/oeqa/selftest/cases/rust.py > index 7d148142fc..6dbc517006 100644 > --- a/meta/lib/oeqa/selftest/cases/rust.py > +++ b/meta/lib/oeqa/selftest/cases/rust.py > @@ -39,6 +39,9 @@ def parse_results(filename): > @OETestTag("runqemu") > class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase): > def test_rust(self, *args, **kwargs): > + # Disable Rust Oe-selftest > + self.skipTest("The Rust Oe-selftest is disabled.") > + > # build remote-test-server before image build > recipe = "rust" > start_time = time.time() Thanks for the Rust update Yash and it's unfortunate that we haven't resolved the problems with the test suite. We decided to diskable the tests and do the update because some changes were blocked waiting for a newer version of Rust according to Tim. Yash, It would be better to disable (skip) the test suite first so that there isn't a commit with the testsuite broken. Alex, the commits are independent, will you please re-order them before merging? ../Randy
On 08/12/2023 09:05:51-0500, Randy MacLeod wrote: > On 2023-12-08 5:48 a.m., Yash.Shinde@windriver.com wrote: > > From: Yash Shinde<Yash.Shinde@windriver.com> > > > > After rust is upgraded to 1.71 and later versions, the rust oe-selftest gives > > build errors due to unstable nightly options(see the error mentioned below). Thus, disable the test suite > > until the issue is fixed > > > > error: the option `Z` is only accepted on the nightly compiler > > thread 'main' panicked at 'failed to gather the target spec for x86_64-poky-linux-gnu', synthetic_targets.rs:66:9 > > > > Following issues are created in Yocto bugzilla and rust upstream to track this issue- > > > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=15275 > > https://github.com/rust-lang/rust/issues/115642 > > https://users.rust-lang.org/t/does-rust-test-suite-supports-nightly-options-during-bootstrapping-in-rust/103108 > > https://users.rust-lang.org/t/unable-to-read-target-specs-when-rust-1-73-is-bootstrapped-in-yocto-poky/102959 > > > > Signed-off-by: Yash Shinde<Yash.Shinde@windriver.com> > > --- > > meta/lib/oeqa/selftest/cases/rust.py | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/meta/lib/oeqa/selftest/cases/rust.py b/meta/lib/oeqa/selftest/cases/rust.py > > index 7d148142fc..6dbc517006 100644 > > --- a/meta/lib/oeqa/selftest/cases/rust.py > > +++ b/meta/lib/oeqa/selftest/cases/rust.py > > @@ -39,6 +39,9 @@ def parse_results(filename): > > @OETestTag("runqemu") > > class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase): > > def test_rust(self, *args, **kwargs): > > + # Disable Rust Oe-selftest > > + self.skipTest("The Rust Oe-selftest is disabled.") > > + > > # build remote-test-server before image build > > recipe = "rust" > > start_time = time.time() > > Thanks for the Rust update Yash and it's unfortunate that we haven't > resolved the problems > with the test suite. We decided to diskable the tests and do the update > because some changes > were blocked waiting for a newer version of Rust according to Tim. > > Yash, > It would be better to disable (skip) the test suite first so that there > isn't a commit with the testsuite > broken. > > Alex, the commits are independent, will you please re-order them before > merging? Sure! > > ../Randy > > -- > # Randy MacLeod > # Wind River Linux
On 2023-12-08 9:46 a.m., Alexandre Belloni wrote: > On 08/12/2023 09:05:51-0500, Randy MacLeod wrote: >> On 2023-12-08 5:48 a.m.,Yash.Shinde@windriver.com wrote: >>> From: Yash Shinde<Yash.Shinde@windriver.com> >>> >>> After rust is upgraded to 1.71 and later versions, the rust oe-selftest gives >>> build errors due to unstable nightly options(see the error mentioned below). Thus, disable the test suite >>> until the issue is fixed >>> >>> error: the option `Z` is only accepted on the nightly compiler >>> thread 'main' panicked at 'failed to gather the target spec for x86_64-poky-linux-gnu', synthetic_targets.rs:66:9 >>> >>> Following issues are created in Yocto bugzilla and rust upstream to track this issue- >>> >>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=15275 >>> https://github.com/rust-lang/rust/issues/115642 >>> https://users.rust-lang.org/t/does-rust-test-suite-supports-nightly-options-during-bootstrapping-in-rust/103108 >>> https://users.rust-lang.org/t/unable-to-read-target-specs-when-rust-1-73-is-bootstrapped-in-yocto-poky/102959 >>> >>> Signed-off-by: Yash Shinde<Yash.Shinde@windriver.com> >>> --- >>> meta/lib/oeqa/selftest/cases/rust.py | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/meta/lib/oeqa/selftest/cases/rust.py b/meta/lib/oeqa/selftest/cases/rust.py >>> index 7d148142fc..6dbc517006 100644 >>> --- a/meta/lib/oeqa/selftest/cases/rust.py >>> +++ b/meta/lib/oeqa/selftest/cases/rust.py >>> @@ -39,6 +39,9 @@ def parse_results(filename): >>> @OETestTag("runqemu") >>> class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase): >>> def test_rust(self, *args, **kwargs): >>> + # Disable Rust Oe-selftest >>> + self.skipTest("The Rust Oe-selftest is disabled.") >>> + >>> # build remote-test-server before image build >>> recipe = "rust" >>> start_time = time.time() >> Thanks for the Rust update Yash and it's unfortunate that we haven't >> resolved the problems >> with the test suite. We decided to diskable the tests and do the update >> because some changes >> were blocked waiting for a newer version of Rust according to Tim. >> >> Yash, >> It would be better to disable (skip) the test suite first so that there >> isn't a commit with the testsuite >> broken. >> >> Alex, the commits are independent, will you please re-order them before >> merging? > Sure! In case anyone doesn't read the other thread/messages, we're going with Alex Kiernan's patchset that starts with Yash's patch: [OE-Core][PATCH 1/7] rust: Disable rust oe-selftest ../Randy > >> ../Randy >> >> -- >> # Randy MacLeod >> # Wind River Linux
diff --git a/meta/lib/oeqa/selftest/cases/rust.py b/meta/lib/oeqa/selftest/cases/rust.py index 7d148142fc..6dbc517006 100644 --- a/meta/lib/oeqa/selftest/cases/rust.py +++ b/meta/lib/oeqa/selftest/cases/rust.py @@ -39,6 +39,9 @@ def parse_results(filename): @OETestTag("runqemu") class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase): def test_rust(self, *args, **kwargs): + # Disable Rust Oe-selftest + self.skipTest("The Rust Oe-selftest is disabled.") + # build remote-test-server before image build recipe = "rust" start_time = time.time()