| Message ID | 20231201151924.874316-1-JPEWhacker@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | classes-global/insane: Skip sstate creation for do_image_qa | expand |
Please see my latest comment in the bug, I don't think recipe_qa is to blame, and it's not going to solve the issue. Also, we do plan to actually register the outcome of recipe_qa into sstate, that's why there's a placeholder for it Alex On Fri, 1 Dec 2023 at 16:19, Joshua Watt <jpewhacker@gmail.com> wrote: > > do_image_qa doens't produce any actual sstate output, so it should skip > the sstate creation (similar to do_image_qa) > > [YOCTO #15289] > > Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> > --- > meta/classes-global/insane.bbclass | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass > index b78bb6f445d..5ce4216f3e0 100644 > --- a/meta/classes-global/insane.bbclass > +++ b/meta/classes-global/insane.bbclass > @@ -1556,6 +1556,7 @@ python do_recipe_qa() { > addtask do_recipe_qa before do_fetch do_package_qa do_build > > SSTATETASKS += "do_recipe_qa" > +SSTATE_SKIP_CREATION:task-recipe-qa = '1' > do_recipe_qa[sstate-inputdirs] = "" > do_recipe_qa[sstate-outputdirs] = "" > python do_recipe_qa_setscene () { > -- > 2.34.1 >
On Fri, 2023-12-01 at 08:19 -0700, Joshua Watt wrote: > do_image_qa doens't produce any actual sstate output, so it should skip > the sstate creation (similar to do_image_qa) > > [YOCTO #15289] > > Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> > --- > meta/classes-global/insane.bbclass | 1 + > 1 file changed, 1 insertion(+) The fact it has run and exists is a marker in itself even if there is no content (package_qa is similar) so I'm not convinced this patch is right. Cheers, Richard
diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index b78bb6f445d..5ce4216f3e0 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -1556,6 +1556,7 @@ python do_recipe_qa() { addtask do_recipe_qa before do_fetch do_package_qa do_build SSTATETASKS += "do_recipe_qa" +SSTATE_SKIP_CREATION:task-recipe-qa = '1' do_recipe_qa[sstate-inputdirs] = "" do_recipe_qa[sstate-outputdirs] = "" python do_recipe_qa_setscene () {
do_image_qa doens't produce any actual sstate output, so it should skip the sstate creation (similar to do_image_qa) [YOCTO #15289] Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> --- meta/classes-global/insane.bbclass | 1 + 1 file changed, 1 insertion(+)