| Message ID | 20231115215256.867653-1-p.lobacz@welotec.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] curl-native: add missing ca-certificates-native dependency | expand |
On Wed, 2023-11-15 at 22:52 +0100, Piotr Łobacz wrote: > By default curl is being configured with: > > --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt > > which causes an issue for native build, when calling > curl-native command, as certificates file is missing. > > Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com> > --- > meta/recipes-support/curl/curl_8.4.0.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/recipes-support/curl/curl_8.4.0.bb b/meta/recipes-support/curl/curl_8.4.0.bb > index 5f97730bf4..f0e09868f6 100644 > --- a/meta/recipes-support/curl/curl_8.4.0.bb > +++ b/meta/recipes-support/curl/curl_8.4.0.bb > @@ -130,6 +130,7 @@ PACKAGES =+ "lib${BPN}" > > FILES:lib${BPN} = "${libdir}/lib*.so.*" > RRECOMMENDS:lib${BPN} += "ca-certificates" > +DEPENDS:append:class-native = " ca-certificates-native" > > FILES:${PN} += "${datadir}/zsh" > I think this can be an RDEPENDS:${PN}:append:class-native which would have the advantage of not blocking the build of curl-native on ca-certs and only require it at runtime for running it? I suspect bitbake is struggling to "see" the RRECOMENDS on a non-PN package for the native recipe extension. Cheers, Richard
Dnia środa, 15 listopada 2023 23:17:40 CET Richard Purdie pisze: > On Wed, 2023-11-15 at 22:52 +0100, Piotr Łobacz wrote: > > By default curl is being configured with: > > > > --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt > > > > which causes an issue for native build, when calling > > curl-native command, as certificates file is missing. > > > > Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com> > > --- > > > > meta/recipes-support/curl/curl_8.4.0.bb | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/meta/recipes-support/curl/curl_8.4.0.bb > > b/meta/recipes-support/curl/curl_8.4.0.bb index 5f97730bf4..f0e09868f6 > > 100644 > > --- a/meta/recipes-support/curl/curl_8.4.0.bb > > +++ b/meta/recipes-support/curl/curl_8.4.0.bb > > @@ -130,6 +130,7 @@ PACKAGES =+ "lib${BPN}" > > > > FILES:lib${BPN} = "${libdir}/lib*.so.*" > > RRECOMMENDS:lib${BPN} += "ca-certificates" > > > > +DEPENDS:append:class-native = " ca-certificates-native" > > > > FILES:${PN} += "${datadir}/zsh" > > I think this can be an RDEPENDS:${PN}:append:class-native which would > have the advantage of not blocking the build of curl-native on ca-certs > and only require it at runtime for running it? I can test it and get back to you with answer if it is working for me > > I suspect bitbake is struggling to "see" the RRECOMENDS on a non-PN > package for the native recipe extension. curl-native has already RRECOMMENDS:lib${BPN} += "ca-certificates" but it was not working for me without DEPENDS:append:class-native = " ca-certificates- native" > > Cheers, > > Richard BR Piotr
On 15 Nov 2023, at 21:52, Piotr Łobacz via lists.openembedded.org <p.lobacz=welotec.com@lists.openembedded.org> wrote: > > By default curl is being configured with: > > --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt > > which causes an issue for native build, when calling > curl-native command, as certificates file is missing. I still don’t think this is the correct fix and simply works for you in testing as the curl-native build tree exists. What’s your reproducer for the bug you’re seeing? Ross
Dnia środa, 15 listopada 2023 23:43:06 CET Piotr Łobacz via lists.openembedded.org pisze: > Dnia środa, 15 listopada 2023 23:17:40 CET Richard Purdie pisze: > > On Wed, 2023-11-15 at 22:52 +0100, Piotr Łobacz wrote: > > > By default curl is being configured with: > > > > > > --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt > > > > > > which causes an issue for native build, when calling > > > curl-native command, as certificates file is missing. > > > > > > Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com> > > > --- > > > > > > meta/recipes-support/curl/curl_8.4.0.bb | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/meta/recipes-support/curl/curl_8.4.0.bb > > > b/meta/recipes-support/curl/curl_8.4.0.bb index 5f97730bf4..f0e09868f6 > > > 100644 > > > --- a/meta/recipes-support/curl/curl_8.4.0.bb > > > +++ b/meta/recipes-support/curl/curl_8.4.0.bb > > > @@ -130,6 +130,7 @@ PACKAGES =+ "lib${BPN}" > > > > > > FILES:lib${BPN} = "${libdir}/lib*.so.*" > > > RRECOMMENDS:lib${BPN} += "ca-certificates" > > > > > > +DEPENDS:append:class-native = " ca-certificates-native" > > > > > > FILES:${PN} += "${datadir}/zsh" > > > > I think this can be an RDEPENDS:${PN}:append:class-native which would > > have the advantage of not blocking the build of curl-native on ca-certs > > and only require it at runtime for running it? > > I can test it and get back to you with answer if it is working for me OK this will not work as I expected, because as written in patch's comment, the --with-ca-bundle is being set to: ${sysconfdir}/ssl/certs/ca-certificates.crt and this expands on native to: build/tmp-glibc/work/x86_64-linux/curl-native/7.82.0-r0/recipe-sysroot-native/ etc/ssl/certs/ca-certificates.crt So in general I need to use DEPENDS instead of RDEPENDS or just set --with-ca- bundle with different path in case of EXTRA_OECONF::class-native. Unfortunately as I already checked the ${sysconfdir} in --with-ca-bundle is being converted to value before passing to --with-ca-bundle and thus it always equals: build/tmp-glibc/work/x86_64-linux/curl-native/7.82.0-r0/recipe-sysroot-native/ etc meaning that even if I run curl-native from different recipe sysroot native it is already set with it and searches for it in that path. The other option is to unset --with-ca-bundle for native and than it will search for it in common places set in the source code, which works but still it may/will use ca-certificate.crt stored not in recipe sysroot native but from the host system which is obviously not the way we want it to. My propousal would be to somehow pass a different variable than ${sysconfdir} into --with-ca-bundle which will be set in sysroot native instead of bitbake and when curl-native is being run expanded to proper path, but I dunno if there is such? BR Piotr > > > I suspect bitbake is struggling to "see" the RRECOMENDS on a non-PN > > package for the native recipe extension. > > curl-native has already RRECOMMENDS:lib${BPN} += "ca-certificates" but it > was not working for me without DEPENDS:append:class-native = " > ca-certificates- native" > > > Cheers, > > > > Richard > > BR > Piotr
diff --git a/meta/recipes-support/curl/curl_8.4.0.bb b/meta/recipes-support/curl/curl_8.4.0.bb index 5f97730bf4..f0e09868f6 100644 --- a/meta/recipes-support/curl/curl_8.4.0.bb +++ b/meta/recipes-support/curl/curl_8.4.0.bb @@ -130,6 +130,7 @@ PACKAGES =+ "lib${BPN}" FILES:lib${BPN} = "${libdir}/lib*.so.*" RRECOMMENDS:lib${BPN} += "ca-certificates" +DEPENDS:append:class-native = " ca-certificates-native" FILES:${PN} += "${datadir}/zsh"
By default curl is being configured with: --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt which causes an issue for native build, when calling curl-native command, as certificates file is missing. Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com> --- meta/recipes-support/curl/curl_8.4.0.bb | 1 + 1 file changed, 1 insertion(+)