diff mbox series

[v2] perf: add jevents PACKAGECONFIG item

Message ID 20231107092557.3843789-1-rasmus.villemoes@prevas.dk
State Accepted, archived
Commit df1905294690682496d8f8e8284964ab897f0cd4
Headers show
Series [v2] perf: add jevents PACKAGECONFIG item | expand

Commit Message

Rasmus Villemoes Nov. 7, 2023, 9:25 a.m. UTC
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>

Building for an arm64 target, e.g. qemuarm64 or a raspberrypi3,
without "python" in PACKAGECONFIG, results in

| Makefile.config:892: *** ERROR: No python interpreter needed for jevents generation. Install python or build with NO_JEVENTS=1..  Stop.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
v2: add comment on (non-)relationship to 'python' PC item.

 meta/recipes-kernel/perf/perf.bb | 3 +++
 1 file changed, 3 insertions(+)

Comments

Bruce Ashfield Nov. 7, 2023, 1:06 p.m. UTC | #1
On Tue, Nov 7, 2023 at 4:26 AM Rasmus Villemoes
<rasmus.villemoes@prevas.dk> wrote:
>
> From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
>
> Building for an arm64 target, e.g. qemuarm64 or a raspberrypi3,
> without "python" in PACKAGECONFIG, results in
>
> | Makefile.config:892: *** ERROR: No python interpreter needed for jevents generation. Install python or build with NO_JEVENTS=1..  Stop.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> ---
> v2: add comment on (non-)relationship to 'python' PC item.
>

v2 looks good to me.

Bruce

>  meta/recipes-kernel/perf/perf.bb | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index a392166e73..5672f7d338 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -28,6 +28,9 @@ PACKAGECONFIG[audit] = ",NO_LIBAUDIT=1,audit"
>  PACKAGECONFIG[manpages] = ",,xmlto-native asciidoc-native"
>  PACKAGECONFIG[cap] = ",,libcap"
>  PACKAGECONFIG[libtraceevent] = ",NO_LIBTRACEEVENT=1,libtraceevent"
> +# jevents requires host python for generating a .c file, but is
> +# unrelated to the python item.
> +PACKAGECONFIG[jevents] = ",NO_JEVENTS=1,python3-native"
>  # Arm CoreSight
>  PACKAGECONFIG[coresight] = "CORESIGHT=1,,opencsd"
>  PACKAGECONFIG[pfm4] = ",NO_LIBPFM4=1,libpfm4"
> --
> 2.40.1.1.g1c60b9335d
>
diff mbox series

Patch

diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index a392166e73..5672f7d338 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -28,6 +28,9 @@  PACKAGECONFIG[audit] = ",NO_LIBAUDIT=1,audit"
 PACKAGECONFIG[manpages] = ",,xmlto-native asciidoc-native"
 PACKAGECONFIG[cap] = ",,libcap"
 PACKAGECONFIG[libtraceevent] = ",NO_LIBTRACEEVENT=1,libtraceevent"
+# jevents requires host python for generating a .c file, but is
+# unrelated to the python item.
+PACKAGECONFIG[jevents] = ",NO_JEVENTS=1,python3-native"
 # Arm CoreSight
 PACKAGECONFIG[coresight] = "CORESIGHT=1,,opencsd"
 PACKAGECONFIG[pfm4] = ",NO_LIBPFM4=1,libpfm4"