diff mbox series

scripts/contrib/patchreview: fix commit identification

Message ID 20231030114839.421272-1-ross.burton@arm.com
State Accepted, archived
Commit 3c04747b681cf6090ba9c77752f6c2f304dbbe17
Headers show
Series scripts/contrib/patchreview: fix commit identification | expand

Commit Message

Ross Burton Oct. 30, 2023, 11:48 a.m. UTC 
From: Ross Burton <ross.burton@arm.com>

git show-ref looks at the _remote_ ref called HEAD, which is fine when it
matches the local HEAD but problematic when you're iterating a series of
commits.

Use rev-parse to resolve the local name to a proper hash.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 scripts/contrib/patchreview.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/scripts/contrib/patchreview.py b/scripts/contrib/patchreview.py
index f95cadab0c6..bceae06561c 100755
--- a/scripts/contrib/patchreview.py
+++ b/scripts/contrib/patchreview.py
@@ -257,7 +257,7 @@  if __name__ == "__main__":
         row = collections.Counter()
         row["total"] = len(results)
         row["date"] = subprocess.check_output(["git", "-C", args.directory, "show", "-s", "--pretty=format:%cd", "--date=format:%s"], universal_newlines=True).strip()
-        row["commit"] = subprocess.check_output(["git", "-C", args.directory, "show-ref", "--hash", "HEAD"], universal_newlines=True).strip()
+        row["commit"] = subprocess.check_output(["git", "-C", args.directory, "rev-parse", "HEAD"], universal_newlines=True).strip()
         row['commit_count'] = subprocess.check_output(["git", "-C", args.directory, "rev-list", "--count", "HEAD"], universal_newlines=True).strip()
         row['recipe_count'] = count_recipes(layers)