| Message ID | 20231010123653.166806-3-ross.burton@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/5] oeqa/selftest: don't skip test_read_only_image on qemuarm64 | expand |
Greetings, On 10.10.23 at 14:36, Ross Burton wrote: > From: Ross Burton <ross.burton@arm.com> > > There's no need for this variable anymore, as all consoles listed in > SERIAL_CONSOLES are checked for their existence before a getty is > started. > --- > meta-yocto-bsp/conf/machine/beaglebone-yocto.conf | 1 - > meta-yocto-bsp/conf/machine/genericx86-64.conf | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf b/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf > index 8b67cefef70..9f389711b3b 100644 > --- a/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf > +++ b/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf > @@ -18,7 +18,6 @@ MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-image kernel-devicetree" > do_image_wic[depends] += "mtools-native:do_populate_sysroot dosfstools-native:do_populate_sysroot virtual/bootloader:do_deploy" > > SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyO0 115200;ttyAMA0" > -SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}" > > PREFERRED_PROVIDER_virtual/kernel ?= "linux-yocto" > PREFERRED_VERSION_linux-yocto ?= "6.1%" > diff --git a/meta-yocto-bsp/conf/machine/genericx86-64.conf b/meta-yocto-bsp/conf/machine/genericx86-64.conf > index 14913ea1f15..f19a1c1527c 100644 > --- a/meta-yocto-bsp/conf/machine/genericx86-64.conf > +++ b/meta-yocto-bsp/conf/machine/genericx86-64.conf > @@ -6,6 +6,5 @@ DEFAULTTUNE ?= "core2-64" > require conf/machine/include/x86/tune-core2.inc > require conf/machine/include/genericx86-common.inc > > -SERIAL_CONSOLES_CHECK = "ttyS0" > #For runqemu > QB_SYSTEM_NAME = "qemu-system-x86_64" Oops, this patch hasn't been taken yet in poky-contrib. Any reason why? Getting rid of SERIAL_CONSOLES_CHECK for good would allow me to remove it from the documentation. Cheers Michael.
Hi Ross, On Tue, Oct 10, 2023 at 9:37 AM Ross Burton <ross.burton@arm.com> wrote: > > From: Ross Burton <ross.burton@arm.com> > > There's no need for this variable anymore, as all consoles listed in > SERIAL_CONSOLES are checked for their existence before a getty is > started. > --- Your Signed-off-by tag is missing.
diff --git a/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf b/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf index 8b67cefef70..9f389711b3b 100644 --- a/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf +++ b/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf @@ -18,7 +18,6 @@ MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-image kernel-devicetree" do_image_wic[depends] += "mtools-native:do_populate_sysroot dosfstools-native:do_populate_sysroot virtual/bootloader:do_deploy" SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyO0 115200;ttyAMA0" -SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}" PREFERRED_PROVIDER_virtual/kernel ?= "linux-yocto" PREFERRED_VERSION_linux-yocto ?= "6.1%" diff --git a/meta-yocto-bsp/conf/machine/genericx86-64.conf b/meta-yocto-bsp/conf/machine/genericx86-64.conf index 14913ea1f15..f19a1c1527c 100644 --- a/meta-yocto-bsp/conf/machine/genericx86-64.conf +++ b/meta-yocto-bsp/conf/machine/genericx86-64.conf @@ -6,6 +6,5 @@ DEFAULTTUNE ?= "core2-64" require conf/machine/include/x86/tune-core2.inc require conf/machine/include/genericx86-common.inc -SERIAL_CONSOLES_CHECK = "ttyS0" #For runqemu QB_SYSTEM_NAME = "qemu-system-x86_64"
From: Ross Burton <ross.burton@arm.com> There's no need for this variable anymore, as all consoles listed in SERIAL_CONSOLES are checked for their existence before a getty is started. --- meta-yocto-bsp/conf/machine/beaglebone-yocto.conf | 1 - meta-yocto-bsp/conf/machine/genericx86-64.conf | 1 - 2 files changed, 2 deletions(-)