diff mbox series

[v2,3/3] common-musl: Disable error_at_line detection for musl

Message ID 20230920220935.970957-3-raj.khem@gmail.com
State New
Headers show
Series [v2,1/3] bsd-headers: Define __CONCAT and __STRING | expand

Commit Message

Khem Raj Sept. 20, 2023, 10:09 p.m. UTC
bsd-headers provide error.h file and static functions to implement error
API and related functions, which confuses gnulib provided functions. So
lets prefer gnulib provided functions if they are used by a package

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/site/common-musl | 3 +++
 1 file changed, 3 insertions(+)

Comments

Richard Purdie Sept. 21, 2023, 2:20 p.m. UTC | #1
On Wed, 2023-09-20 at 15:09 -0700, Khem Raj wrote:
> bsd-headers provide error.h file and static functions to implement error
> API and related functions, which confuses gnulib provided functions. So
> lets prefer gnulib provided functions if they are used by a package
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/site/common-musl | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/site/common-musl b/meta/site/common-musl
> index 0fd0413819e..003e46b51dc 100644
> --- a/meta/site/common-musl
> +++ b/meta/site/common-musl
> @@ -54,3 +54,6 @@ ac_cv_func_posix_getpwnam_r=${ac_cv_func_posix_getpwnam_r=yes}
>  
>  # Xorg
>  xorg_cv_malloc0_returns_null=${xorg_cv_malloc0_returns_null=yes}
> +
> +# gnulib error
> +ac_cv_lib_error_at_line=${ac_cv_lib_error_at_line=no}

This is better but our on target cpio build test is failing:

https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/7826/steps/13/logs/stdio

probably as it doesn't see the site cache entry on target.

Cheers,

Richard
Khem Raj Sept. 21, 2023, 2:52 p.m. UTC | #2
On Thu, Sep 21, 2023 at 7:20 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Wed, 2023-09-20 at 15:09 -0700, Khem Raj wrote:
> > bsd-headers provide error.h file and static functions to implement error
> > API and related functions, which confuses gnulib provided functions. So
> > lets prefer gnulib provided functions if they are used by a package
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/site/common-musl | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/meta/site/common-musl b/meta/site/common-musl
> > index 0fd0413819e..003e46b51dc 100644
> > --- a/meta/site/common-musl
> > +++ b/meta/site/common-musl
> > @@ -54,3 +54,6 @@ ac_cv_func_posix_getpwnam_r=${ac_cv_func_posix_getpwnam_r=yes}
> >
> >  # Xorg
> >  xorg_cv_malloc0_returns_null=${xorg_cv_malloc0_returns_null=yes}
> > +
> > +# gnulib error
> > +ac_cv_lib_error_at_line=${ac_cv_lib_error_at_line=no}
>
> This is better but our on target cpio build test is failing:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/7826/steps/13/logs/stdio
>
> probably as it doesn't see the site cache entry on target.

Right. We need to fix the testcase to pass it via configure or env.
Let me take a look

>
> Cheers,
>
> Richard
diff mbox series

Patch

diff --git a/meta/site/common-musl b/meta/site/common-musl
index 0fd0413819e..003e46b51dc 100644
--- a/meta/site/common-musl
+++ b/meta/site/common-musl
@@ -54,3 +54,6 @@  ac_cv_func_posix_getpwnam_r=${ac_cv_func_posix_getpwnam_r=yes}
 
 # Xorg
 xorg_cv_malloc0_returns_null=${xorg_cv_malloc0_returns_null=yes}
+
+# gnulib error
+ac_cv_lib_error_at_line=${ac_cv_lib_error_at_line=no}