diff mbox series

[v2,5/5] mdadm: re-add mdadm-ptest to PTESTS_SLOW

Message ID 20230704073919.1593400-5-ovidiu.panait@windriver.com
State Accepted, archived
Commit dfefff63c547adb1add0c8e3a308b2d0bd6cfc8c
Headers show
Series [v2,1/5] mdadm: fix util-linux ptest dependency | expand

Commit Message

Ovidiu Panait July 4, 2023, 7:39 a.m. UTC 
From: Ovidiu Panait <ovidiu.panait@windriver.com>

The ptest problems reported in e21021dc00ec ("mdadm: drop from PTESTS_SLOW")
should now be fixed, so mdadm can be added back to PTESTS_SLOW (a qemux86-64
test run takes about ~12 minutes to execute with kvm).

root@qemux86-64:~# ptest-runner mdadm
START: ptest-runner
2023-06-30T08:25
BEGIN: /usr/lib/mdadm/ptest
PASS: /usr/lib/mdadm/ptest/tests/00linear
PASS: /usr/lib/mdadm/ptest/tests/00multipath
...
PASS: /usr/lib/mdadm/ptest/tests/19repair-does-not-destroy
PASS: /usr/lib/mdadm/ptest/tests/20raid5journal
PASS: /usr/lib/mdadm/ptest/tests/21raid5cache
DURATION: 723
END: /usr/lib/mdadm/ptest
2023-06-30T09:16
STOP: ptest-runner
TOTAL: 1 FAIL: 0

For the testcases to run correctly, there must be enough rootfs space to create
13 loop devices. Similar to strace and lttng-tools, add a new
IMAGE_ROOTFS_EXTRA_SPACE entry for mdadm-ptest.

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
 meta/conf/distro/include/ptest-packagelists.inc | 3 +--
 meta/recipes-core/images/core-image-ptest.bb    | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Alexandre Belloni July 11, 2023, 10:57 a.m. UTC | #1 
Hello,

I opened https://bugzilla.yoctoproject.org/show_bug.cgi?id=15159 aswe
had an intermittent failure, can you have a look at what caused it?

On 04/07/2023 10:39:19+0300, Ovidiu Panait via lists.openembedded.org wrote:
> From: Ovidiu Panait <ovidiu.panait@windriver.com>
> 
> The ptest problems reported in e21021dc00ec ("mdadm: drop from PTESTS_SLOW")
> should now be fixed, so mdadm can be added back to PTESTS_SLOW (a qemux86-64
> test run takes about ~12 minutes to execute with kvm).
> 
> root@qemux86-64:~# ptest-runner mdadm
> START: ptest-runner
> 2023-06-30T08:25
> BEGIN: /usr/lib/mdadm/ptest
> PASS: /usr/lib/mdadm/ptest/tests/00linear
> PASS: /usr/lib/mdadm/ptest/tests/00multipath
> ...
> PASS: /usr/lib/mdadm/ptest/tests/19repair-does-not-destroy
> PASS: /usr/lib/mdadm/ptest/tests/20raid5journal
> PASS: /usr/lib/mdadm/ptest/tests/21raid5cache
> DURATION: 723
> END: /usr/lib/mdadm/ptest
> 2023-06-30T09:16
> STOP: ptest-runner
> TOTAL: 1 FAIL: 0
> 
> For the testcases to run correctly, there must be enough rootfs space to create
> 13 loop devices. Similar to strace and lttng-tools, add a new
> IMAGE_ROOTFS_EXTRA_SPACE entry for mdadm-ptest.
> 
> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
> ---
>  meta/conf/distro/include/ptest-packagelists.inc | 3 +--
>  meta/recipes-core/images/core-image-ptest.bb    | 1 +
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
> index da9153b998..6250cf081e 100644
> --- a/meta/conf/distro/include/ptest-packagelists.inc
> +++ b/meta/conf/distro/include/ptest-packagelists.inc
> @@ -99,6 +99,7 @@ PTESTS_SLOW = "\
>      libgcrypt \
>      libmodule-build-perl \
>      lttng-tools \
> +    mdadm \
>      openssh \
>      openssl \
>      parted \
> @@ -122,7 +123,6 @@ PTESTS_PROBLEMS:append:x86 = " valgrind"
>  #    rt-tests \ # Needs to be checked whether it runs at all
>  #    bash \ # Test outcomes are non-deterministic by design
>  #    ifupdown \ # Tested separately in lib/oeqa/selftest/cases/imagefeatures.py
> -#    mdadm \ # Tests rely on non-deterministic sleep() amounts
>  #    libinput \ # Tests need an unloaded system to be reliable
>  #    libpam \ # Needs pam DISTRO_FEATURE
>  #    numactl \ # qemu not (yet) configured for numa; all tests are skipped
> @@ -134,7 +134,6 @@ PTESTS_PROBLEMS = "\
>      rt-tests \
>      bash \
>      ifupdown \
> -    mdadm \
>      libinput \
>      libpam \
>      libseccomp \
> diff --git a/meta/recipes-core/images/core-image-ptest.bb b/meta/recipes-core/images/core-image-ptest.bb
> index 90c26641ba..ddc56c8f9f 100644
> --- a/meta/recipes-core/images/core-image-ptest.bb
> +++ b/meta/recipes-core/images/core-image-ptest.bb
> @@ -19,6 +19,7 @@ BBCLASSEXTEND = "${@' '.join(['mcextend:'+x for x in d.getVar('PTESTS').split()]
>  # strace-ptest in particular needs more than 500MB
>  IMAGE_OVERHEAD_FACTOR = "1.0"
>  IMAGE_ROOTFS_EXTRA_SPACE = "324288"
> +IMAGE_ROOTFS_EXTRA_SPACE:virtclass-mcextend-mdadm = "1524288"
>  IMAGE_ROOTFS_EXTRA_SPACE:virtclass-mcextend-strace = "1024288"
>  IMAGE_ROOTFS_EXTRA_SPACE:virtclass-mcextend-lttng-tools = "1524288"
>  
> -- 
> 2.39.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#183817): https://lists.openembedded.org/g/openembedded-core/message/183817
> Mute This Topic: https://lists.openembedded.org/mt/99942490/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
index da9153b998..6250cf081e 100644
--- a/meta/conf/distro/include/ptest-packagelists.inc
+++ b/meta/conf/distro/include/ptest-packagelists.inc
@@ -99,6 +99,7 @@  PTESTS_SLOW = "\
     libgcrypt \
     libmodule-build-perl \
     lttng-tools \
+    mdadm \
     openssh \
     openssl \
     parted \
@@ -122,7 +123,6 @@  PTESTS_PROBLEMS:append:x86 = " valgrind"
 #    rt-tests \ # Needs to be checked whether it runs at all
 #    bash \ # Test outcomes are non-deterministic by design
 #    ifupdown \ # Tested separately in lib/oeqa/selftest/cases/imagefeatures.py
-#    mdadm \ # Tests rely on non-deterministic sleep() amounts
 #    libinput \ # Tests need an unloaded system to be reliable
 #    libpam \ # Needs pam DISTRO_FEATURE
 #    numactl \ # qemu not (yet) configured for numa; all tests are skipped
@@ -134,7 +134,6 @@  PTESTS_PROBLEMS = "\
     rt-tests \
     bash \
     ifupdown \
-    mdadm \
     libinput \
     libpam \
     libseccomp \
diff --git a/meta/recipes-core/images/core-image-ptest.bb b/meta/recipes-core/images/core-image-ptest.bb
index 90c26641ba..ddc56c8f9f 100644
--- a/meta/recipes-core/images/core-image-ptest.bb
+++ b/meta/recipes-core/images/core-image-ptest.bb
@@ -19,6 +19,7 @@  BBCLASSEXTEND = "${@' '.join(['mcextend:'+x for x in d.getVar('PTESTS').split()]
 # strace-ptest in particular needs more than 500MB
 IMAGE_OVERHEAD_FACTOR = "1.0"
 IMAGE_ROOTFS_EXTRA_SPACE = "324288"
+IMAGE_ROOTFS_EXTRA_SPACE:virtclass-mcextend-mdadm = "1524288"
 IMAGE_ROOTFS_EXTRA_SPACE:virtclass-mcextend-strace = "1024288"
 IMAGE_ROOTFS_EXTRA_SPACE:virtclass-mcextend-lttng-tools = "1524288"