| Message ID | 20230627101644.881715-5-jose.quaresma@foundries.io |
|---|---|
| State | New |
| Headers | show |
| Series | [1/5] kernel: config modules directories are handled by kernel-module-split | expand |
On Tue, 2023-06-27 at 10:16 +0000, Jose Quaresma wrote: > Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io> > --- > > v5: introduced in v5 > > meta/conf/distro/include/init-manager-systemd.inc | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/meta/conf/distro/include/init-manager-systemd.inc b/meta/conf/distro/include/init-manager-systemd.inc > index 7867d90028..4989b93502 100644 > --- a/meta/conf/distro/include/init-manager-systemd.inc > +++ b/meta/conf/distro/include/init-manager-systemd.inc > @@ -5,3 +5,7 @@ VIRTUAL-RUNTIME_init_manager ??= "systemd" > VIRTUAL-RUNTIME_initscripts ??= "systemd-compat-units" > VIRTUAL-RUNTIME_login_manager ??= "shadow-base" > VIRTUAL-RUNTIME_dev_manager ??= "systemd" > + > +# Use modules-load and modprobe config path distribution specific > +modulesloaddir ?= "${libdir}/modules-load.d" > +modprobedir ?= "${nonarch_base_libdir}/modprobe.d" Not everyone uses INIT_MANAGER and we don't really want these set in every recipe. I think this should be in the bbclass based upon some conditional, not here... Cheers, Richard
Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia quarta, 28/06/2023 à(s) 23:03: > On Tue, 2023-06-27 at 10:16 +0000, Jose Quaresma wrote: > > Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io> > > --- > > > > v5: introduced in v5 > > > > meta/conf/distro/include/init-manager-systemd.inc | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/meta/conf/distro/include/init-manager-systemd.inc > b/meta/conf/distro/include/init-manager-systemd.inc > > index 7867d90028..4989b93502 100644 > > --- a/meta/conf/distro/include/init-manager-systemd.inc > > +++ b/meta/conf/distro/include/init-manager-systemd.inc > > @@ -5,3 +5,7 @@ VIRTUAL-RUNTIME_init_manager ??= "systemd" > > VIRTUAL-RUNTIME_initscripts ??= "systemd-compat-units" > > VIRTUAL-RUNTIME_login_manager ??= "shadow-base" > > VIRTUAL-RUNTIME_dev_manager ??= "systemd" > > + > > +# Use modules-load and modprobe config path distribution specific > > +modulesloaddir ?= "${libdir}/modules-load.d" > > +modprobedir ?= "${nonarch_base_libdir}/modprobe.d" > > Not everyone uses INIT_MANAGER and we don't really want these set in > every recipe. I think this should be in the bbclass based upon some > conditional, not here... > > Cheers, > > Richard > Sure, I will add it to the kernel-module-split bbclass conditioned to systemd dsitro feature. That is something I have been thinking about in the first versions.
diff --git a/meta/conf/distro/include/init-manager-systemd.inc b/meta/conf/distro/include/init-manager-systemd.inc index 7867d90028..4989b93502 100644 --- a/meta/conf/distro/include/init-manager-systemd.inc +++ b/meta/conf/distro/include/init-manager-systemd.inc @@ -5,3 +5,7 @@ VIRTUAL-RUNTIME_init_manager ??= "systemd" VIRTUAL-RUNTIME_initscripts ??= "systemd-compat-units" VIRTUAL-RUNTIME_login_manager ??= "shadow-base" VIRTUAL-RUNTIME_dev_manager ??= "systemd" + +# Use modules-load and modprobe config path distribution specific +modulesloaddir ?= "${libdir}/modules-load.d" +modprobedir ?= "${nonarch_base_libdir}/modprobe.d"
Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io> --- v5: introduced in v5 meta/conf/distro/include/init-manager-systemd.inc | 4 ++++ 1 file changed, 4 insertions(+)