| Message ID | 20230619144746.2672706-2-richard.purdie@linuxfoundation.org |
|---|---|
| State | Accepted, archived |
| Commit | 4c6d0f3ddbb76bde7f35edeb280fe56a9a00f91b |
| Headers | show |
| Series | [1/2] scripts/runqemu-ifup: Fix extra parameter issue | expand |
diff --git a/scripts/runqemu-ifup b/scripts/runqemu-ifup index e3aa16c97df..5dc765dee82 100755 --- a/scripts/runqemu-ifup +++ b/scripts/runqemu-ifup @@ -38,7 +38,7 @@ USERID="-u $1" GROUP="-g $2" if taps=$(ip tuntap list 2>/dev/null); then - tap_no=$(( $(echo "$taps" |sort -r |sed 's/^tap//; s/:.*//; q') + 1 )) + tap_no=$(( $(echo "$taps" |cut -f 1 -d ":" | sed 's/tap//g' | sort -rn | head -n 1) + 1 )) ip tuntap add tap$tap_no mode tap group $2 && TAP=tap$tap_no fi
The use of sort means that tap10 and tap1 don't sort correctly. Tweak the shell expression to correctly handle numbers of tap devices of 10 or more. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> --- scripts/runqemu-ifup | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)