diff mbox series

attr: Package attr, getfattr, and setfattr into attr-tools

Message ID 20230520022553.3768155-1-stefanb@linux.ibm.com
State New
Headers show
Series attr: Package attr, getfattr, and setfattr into attr-tools | expand

Commit Message

Stefan Berger May 20, 2023, 2:25 a.m. UTC
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
 meta/recipes-support/attr/attr.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ross Burton May 23, 2023, 4:46 p.m. UTC | #1
What’s the rationale for this?

attr:
	/etc/xattr.conf
	/usr/bin/attr
	/usr/bin/getfattr
	/usr/bin/setfattr.attr

libattr:
	/usr/lib/libattr.so.1
	/usr/lib/libattr.so.1.1.2501

The library is already split out so what does this gain?

Also, the idiom for library packages which have binaries is to inherit lib_package.

Ross
Stefan Berger May 23, 2023, 6:48 p.m. UTC | #2
On 5/23/23 12:46, Ross Burton wrote:
> What’s the rationale for this?
> 
> attr:
> 	/etc/xattr.conf
> 	/usr/bin/attr
> 	/usr/bin/getfattr
> 	/usr/bin/setfattr.attr
> 
> libattr:
> 	/usr/lib/libattr.so.1
> 	/usr/lib/libattr.so.1.1.2501
> 
> The library is already split out so what does this gain?

I must have missed that attr package already exists.So, I am dropping this patch.

    Stefan

> 
> Also, the idiom for library packages which have binaries is to inherit lib_package.
> 
> Ross
diff mbox series

Patch

diff --git a/meta/recipes-support/attr/attr.inc b/meta/recipes-support/attr/attr.inc
index 8ba865a74a..2d2ff0912e 100644
--- a/meta/recipes-support/attr/attr.inc
+++ b/meta/recipes-support/attr/attr.inc
@@ -20,9 +20,10 @@  SRC_URI = "${SAVANNAH_GNU_MIRROR}/attr/${BP}.tar.gz \
 
 inherit ptest update-alternatives autotools gettext
 
-PACKAGES =+ "lib${BPN}"
+PACKAGES =+ "lib${BPN} ${BPN}-tools"
 
 FILES:lib${BPN} = "${libdir}/lib*${SOLIBS}"
+FILES:${BPN}-tools = "${bindir}/*attr*"
 
 ALTERNATIVE_PRIORITY = "100"
 ALTERNATIVE:${PN} = "setfattr"