| Message ID | 20230426095036.2632847-11-alex@linutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [01/11] binutils: backport a patch to address failures when time64.inc is in use | expand |
Hi Alex, On Wed, 26 Apr 2023 11:50:36 +0200 "Alexander Kanavin" <alex.kanavin@gmail.com> wrote: > Signed-off-by: Alexander Kanavin <alex@linutronix.de> > --- > meta/classes-global/insane.bbclass | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass > index 8788f58fc5b..38126d89a58 100644 > --- a/meta/classes-global/insane.bbclass > +++ b/meta/classes-global/insane.bbclass > @@ -44,7 +44,7 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ > already-stripped installed-vs-shipped ldflags compile-host-path \ > install-host-path pn-overrides unknown-configure-option \ > useless-rpaths rpaths staticdev empty-dirs \ > - patch-fuzz patch-status-core\ > + patch-fuzz patch-status-core 32bit-time \ This line conflicted with another patch you sent earlier and which is on my branch. You may want to double check whether lucaceresoli/master-next is still consistent with what you had in mind. Best regards, Luca
On Wed, 26 Apr 2023 at 23:18, Luca Ceresoli <luca.ceresoli@bootlin.com> wrote: > > already-stripped installed-vs-shipped ldflags compile-host-path \ > > install-host-path pn-overrides unknown-configure-option \ > > useless-rpaths rpaths staticdev empty-dirs \ > > - patch-fuzz patch-status-core\ > > + patch-fuzz patch-status-core 32bit-time \ > > This line conflicted with another patch you sent earlier and which is > on my branch. You may want to double check whether > lucaceresoli/master-next is still consistent with what you had in mind. The patchsets independently add entries to this list, so yes the correct resolution is to add them both in any order. I'll send a newer version of the other patchset now (with recipe metadata tests). Alex
I see this error triggering for meta-openembedded builds qemuarm - https://errors.yoctoproject.org/Errors/Build/163136/ On Wed, Apr 26, 2023 at 2:50 AM Alexander Kanavin <alex.kanavin@gmail.com> wrote: > > Signed-off-by: Alexander Kanavin <alex@linutronix.de> > --- > meta/classes-global/insane.bbclass | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass > index 8788f58fc5b..38126d89a58 100644 > --- a/meta/classes-global/insane.bbclass > +++ b/meta/classes-global/insane.bbclass > @@ -44,7 +44,7 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ > already-stripped installed-vs-shipped ldflags compile-host-path \ > install-host-path pn-overrides unknown-configure-option \ > useless-rpaths rpaths staticdev empty-dirs \ > - patch-fuzz patch-status-core\ > + patch-fuzz patch-status-core 32bit-time \ > " > # Add usrmerge QA check based on distro feature > ERROR_QA:append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}" > @@ -512,6 +512,11 @@ def check_32bit_symbols(path, packagename, d, elf, messages): > """ > Check that ELF files do not use any 32 bit time APIs from glibc. > """ > + thirtytwo_bit_time_archs = set(('arm','armeb','mipsarcho32','powerpc','x86')) > + overrides = set(d.getVar('OVERRIDES').split(':')) > + if not(thirtytwo_bit_time_archs & overrides): > + return > + > import re > # This list is manually constructed by searching the image folder of the > # glibc recipe for __USE_TIME_BITS64. There is no good way to do this > -- > 2.30.2 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#180429): https://lists.openembedded.org/g/openembedded-core/message/180429 > Mute This Topic: https://lists.openembedded.org/mt/98511413/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
They all need INSANE_SKIP = "32bit-time". I'll send patches. Alex On Fri, 28 Apr 2023 at 05:20, Khem Raj <raj.khem@gmail.com> wrote: > > I see this error triggering for meta-openembedded builds > > qemuarm - https://errors.yoctoproject.org/Errors/Build/163136/ > > On Wed, Apr 26, 2023 at 2:50 AM Alexander Kanavin > <alex.kanavin@gmail.com> wrote: > > > > Signed-off-by: Alexander Kanavin <alex@linutronix.de> > > --- > > meta/classes-global/insane.bbclass | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass > > index 8788f58fc5b..38126d89a58 100644 > > --- a/meta/classes-global/insane.bbclass > > +++ b/meta/classes-global/insane.bbclass > > @@ -44,7 +44,7 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ > > already-stripped installed-vs-shipped ldflags compile-host-path \ > > install-host-path pn-overrides unknown-configure-option \ > > useless-rpaths rpaths staticdev empty-dirs \ > > - patch-fuzz patch-status-core\ > > + patch-fuzz patch-status-core 32bit-time \ > > " > > # Add usrmerge QA check based on distro feature > > ERROR_QA:append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}" > > @@ -512,6 +512,11 @@ def check_32bit_symbols(path, packagename, d, elf, messages): > > """ > > Check that ELF files do not use any 32 bit time APIs from glibc. > > """ > > + thirtytwo_bit_time_archs = set(('arm','armeb','mipsarcho32','powerpc','x86')) > > + overrides = set(d.getVar('OVERRIDES').split(':')) > > + if not(thirtytwo_bit_time_archs & overrides): > > + return > > + > > import re > > # This list is manually constructed by searching the image folder of the > > # glibc recipe for __USE_TIME_BITS64. There is no good way to do this > > -- > > 2.30.2 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#180429): https://lists.openembedded.org/g/openembedded-core/message/180429 > > Mute This Topic: https://lists.openembedded.org/mt/98511413/1997914 > > Group Owner: openembedded-core+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > >
Come to think of it, let's downgrade this check to WARN_QA. It's not a critical error, not yet :) Alex On Fri, 28 Apr 2023 at 09:05, Alexander Kanavin via lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org> wrote: > > They all need INSANE_SKIP = "32bit-time". > > I'll send patches. > > Alex > > On Fri, 28 Apr 2023 at 05:20, Khem Raj <raj.khem@gmail.com> wrote: > > > > I see this error triggering for meta-openembedded builds > > > > qemuarm - https://errors.yoctoproject.org/Errors/Build/163136/ > > > > On Wed, Apr 26, 2023 at 2:50 AM Alexander Kanavin > > <alex.kanavin@gmail.com> wrote: > > > > > > Signed-off-by: Alexander Kanavin <alex@linutronix.de> > > > --- > > > meta/classes-global/insane.bbclass | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass > > > index 8788f58fc5b..38126d89a58 100644 > > > --- a/meta/classes-global/insane.bbclass > > > +++ b/meta/classes-global/insane.bbclass > > > @@ -44,7 +44,7 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ > > > already-stripped installed-vs-shipped ldflags compile-host-path \ > > > install-host-path pn-overrides unknown-configure-option \ > > > useless-rpaths rpaths staticdev empty-dirs \ > > > - patch-fuzz patch-status-core\ > > > + patch-fuzz patch-status-core 32bit-time \ > > > " > > > # Add usrmerge QA check based on distro feature > > > ERROR_QA:append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}" > > > @@ -512,6 +512,11 @@ def check_32bit_symbols(path, packagename, d, elf, messages): > > > """ > > > Check that ELF files do not use any 32 bit time APIs from glibc. > > > """ > > > + thirtytwo_bit_time_archs = set(('arm','armeb','mipsarcho32','powerpc','x86')) > > > + overrides = set(d.getVar('OVERRIDES').split(':')) > > > + if not(thirtytwo_bit_time_archs & overrides): > > > + return > > > + > > > import re > > > # This list is manually constructed by searching the image folder of the > > > # glibc recipe for __USE_TIME_BITS64. There is no good way to do this > > > -- > > > 2.30.2 > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#180508): https://lists.openembedded.org/g/openembedded-core/message/180508 > Mute This Topic: https://lists.openembedded.org/mt/98511413/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index 8788f58fc5b..38126d89a58 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -44,7 +44,7 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ already-stripped installed-vs-shipped ldflags compile-host-path \ install-host-path pn-overrides unknown-configure-option \ useless-rpaths rpaths staticdev empty-dirs \ - patch-fuzz patch-status-core\ + patch-fuzz patch-status-core 32bit-time \ " # Add usrmerge QA check based on distro feature ERROR_QA:append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}" @@ -512,6 +512,11 @@ def check_32bit_symbols(path, packagename, d, elf, messages): """ Check that ELF files do not use any 32 bit time APIs from glibc. """ + thirtytwo_bit_time_archs = set(('arm','armeb','mipsarcho32','powerpc','x86')) + overrides = set(d.getVar('OVERRIDES').split(':')) + if not(thirtytwo_bit_time_archs & overrides): + return + import re # This list is manually constructed by searching the image folder of the # glibc recipe for __USE_TIME_BITS64. There is no good way to do this
Signed-off-by: Alexander Kanavin <alex@linutronix.de> --- meta/classes-global/insane.bbclass | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)