| Message ID | 20230107000831.1253334-1-raj.khem@gmail.com |
|---|---|
| State | Accepted, archived |
| Commit | 09b3e8417d362b75f3b43a5a97b47700f97bf643 |
| Headers | show |
| Series | site/common-musl: Set ac_cv_sys_file_offset_bits default to 64 | expand |
On Sat, Jan 7, 2023 at 1:08 AM Khem Raj <raj.khem@gmail.com> wrote: > off_t is always 64bit on musl regardless of 32bit or 64bit > architectures. autoconf has AC_SYS_LARGEFILE to detect correct off_t > size but it only work with glibc since it defines feature macros > _FILE_OFFSET_BITS=64 and _LARGEFILE_SOURCE but these macros are > not used on musl headers. > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > Cc: Nicolas Dechesne <nicolas.dechesne@linaro.org> > Thanks. It fixes the build issue in e2fsprog I reported earlier. > --- > meta/site/common-musl | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta/site/common-musl b/meta/site/common-musl > index 86aed4a38c..23e50ef749 100644 > --- a/meta/site/common-musl > +++ b/meta/site/common-musl > @@ -15,6 +15,8 @@ > ac_cv_func_posix_getgrgid_r=${ac_cv_func_posix_getgrgid_r=yes} > ac_cv_func_getaddrinfo=${ac_cv_func_getaddrinfo=yes} > ac_cv_func_mmap_fixed_mapped=${ac_cv_func_mmap_fixed_mapped=yes} > ac_cv_func_strtod=${ac_cv_func_strtod=yes} > +# off_t is always 64bit on musl systems > +ac_cv_sys_file_offset_bits=${ac_cv_sys_file_offset_bits=64} > > # glib > glib_cv_strlcpy=${glib_cv_strlcpy=no} > -- > 2.39.0 > >
On Fri, 2023-01-06 at 16:08 -0800, Khem Raj wrote: > off_t is always 64bit on musl regardless of 32bit or 64bit > architectures. autoconf has AC_SYS_LARGEFILE to detect correct off_t > size but it only work with glibc since it defines feature macros > _FILE_OFFSET_BITS=64 and _LARGEFILE_SOURCE but these macros are > not used on musl headers. > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > Cc: Nicolas Dechesne <nicolas.dechesne@linaro.org> > --- > meta/site/common-musl | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta/site/common-musl b/meta/site/common-musl > index 86aed4a38c..23e50ef749 100644 > --- a/meta/site/common-musl > +++ b/meta/site/common-musl > @@ -15,6 +15,8 @@ ac_cv_func_posix_getgrgid_r=${ac_cv_func_posix_getgrgid_r=yes} > ac_cv_func_getaddrinfo=${ac_cv_func_getaddrinfo=yes} > ac_cv_func_mmap_fixed_mapped=${ac_cv_func_mmap_fixed_mapped=yes} > ac_cv_func_strtod=${ac_cv_func_strtod=yes} > +# off_t is always 64bit on musl systems > +ac_cv_sys_file_offset_bits=${ac_cv_sys_file_offset_bits=64} > Not sure if this failure might be related to this change: https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/6496/steps/12/logs/stdio Cheers, Richard
On Sat, Jan 7, 2023 at 12:13 PM Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > > On Fri, 2023-01-06 at 16:08 -0800, Khem Raj wrote: > > off_t is always 64bit on musl regardless of 32bit or 64bit > > architectures. autoconf has AC_SYS_LARGEFILE to detect correct off_t > > size but it only work with glibc since it defines feature macros > > _FILE_OFFSET_BITS=64 and _LARGEFILE_SOURCE but these macros are > > not used on musl headers. > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > Cc: Nicolas Dechesne <nicolas.dechesne@linaro.org> > > --- > > meta/site/common-musl | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/meta/site/common-musl b/meta/site/common-musl > > index 86aed4a38c..23e50ef749 100644 > > --- a/meta/site/common-musl > > +++ b/meta/site/common-musl > > @@ -15,6 +15,8 @@ ac_cv_func_posix_getgrgid_r=${ac_cv_func_posix_getgrgid_r=yes} > > ac_cv_func_getaddrinfo=${ac_cv_func_getaddrinfo=yes} > > ac_cv_func_mmap_fixed_mapped=${ac_cv_func_mmap_fixed_mapped=yes} > > ac_cv_func_strtod=${ac_cv_func_strtod=yes} > > +# off_t is always 64bit on musl systems > > +ac_cv_sys_file_offset_bits=${ac_cv_sys_file_offset_bits=64} > > > > Not sure if this failure might be related to this change: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/6496/steps/12/logs/stdio > Yes its a side effect of this. We should have added --disable-lfs-alias always. sending a patch for this package > Cheers, > > Richard
diff --git a/meta/site/common-musl b/meta/site/common-musl index 86aed4a38c..23e50ef749 100644 --- a/meta/site/common-musl +++ b/meta/site/common-musl @@ -15,6 +15,8 @@ ac_cv_func_posix_getgrgid_r=${ac_cv_func_posix_getgrgid_r=yes} ac_cv_func_getaddrinfo=${ac_cv_func_getaddrinfo=yes} ac_cv_func_mmap_fixed_mapped=${ac_cv_func_mmap_fixed_mapped=yes} ac_cv_func_strtod=${ac_cv_func_strtod=yes} +# off_t is always 64bit on musl systems +ac_cv_sys_file_offset_bits=${ac_cv_sys_file_offset_bits=64} # glib glib_cv_strlcpy=${glib_cv_strlcpy=no}
off_t is always 64bit on musl regardless of 32bit or 64bit architectures. autoconf has AC_SYS_LARGEFILE to detect correct off_t size but it only work with glibc since it defines feature macros _FILE_OFFSET_BITS=64 and _LARGEFILE_SOURCE but these macros are not used on musl headers. Signed-off-by: Khem Raj <raj.khem@gmail.com> Cc: Nicolas Dechesne <nicolas.dechesne@linaro.org> --- meta/site/common-musl | 2 ++ 1 file changed, 2 insertions(+)