diff mbox series

[1/2] scripts/oe-check-sstate: cleanup

Message ID 20221019203808.2275846-1-ross.burton@arm.com
State Accepted, archived
Commit 663aa284adf312eb5c8a471e5dbff2634e87897d
Headers show
Series [1/2] scripts/oe-check-sstate: cleanup | expand

Commit Message

Ross Burton Oct. 19, 2022, 8:38 p.m. UTC 
The scriptutils import isn't used, there's no need to run bitbake
in a shell environment, and invoke bitbake as a list instead of a
string.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 scripts/oe-check-sstate | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
diff mbox series

Patch

diff --git a/scripts/oe-check-sstate b/scripts/oe-check-sstate
index f4cc5869de4..7f9f835da4c 100755
--- a/scripts/oe-check-sstate
+++ b/scripts/oe-check-sstate
@@ -18,7 +18,6 @@  import re
 scripts_path = os.path.dirname(os.path.realpath(__file__))
 lib_path = scripts_path + '/lib'
 sys.path = sys.path + [lib_path]
-import scriptutils
 import scriptpath
 scriptpath.add_bitbake_lib_path()
 import argparse_oe
@@ -51,11 +50,8 @@  def check(args):
             env['TMPDIR:forcevariable'] = tmpdir
 
         try:
-            output = subprocess.check_output(
-                    'bitbake -n %s' % ' '.join(args.target),
-                    stderr=subprocess.STDOUT,
-                    env=env,
-                    shell=True)
+            cmd = ['bitbake', '--dry-run'] + args.target
+            output = subprocess.check_output(cmd, stderr=subprocess.STDOUT, env=env)
 
             task_re = re.compile('NOTE: Running setscene task [0-9]+ of [0-9]+ \(([^)]+)\)')
             tasks = []