diff mbox series

python3-manifest.json: Move urllib to netclient

Message ID 20221011111028.590084-1-leon.anavi@konsulko.com
State Accepted, archived
Commit e74ab2c144042b0a9f788b1b15f11b2800e2c7a1
Headers show
Series python3-manifest.json: Move urllib to netclient | expand

Commit Message

Leon Anavi Oct. 11, 2022, 11:10 a.m. UTC
Move urllib from core to netclient because it imports base64.

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
---
 .../python/python3/python3-manifest.json               | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Leon Anavi Oct. 25, 2022, 8:41 a.m. UTC | #1
Hi,

It has been 2 weeks since I submitted this patch for openembedded-core. 
I am wondering if it will be merged in master/master-next. Please let me 
know if any changes are needed. Is the patch OK?

Thanks,
Leon

On 11.10.22 г. 14:10 ч., Leon Anavi wrote:
> Move urllib from core to netclient because it imports base64.
>
> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> ---
>   .../python/python3/python3-manifest.json               | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json b/meta/recipes-devtools/python/python3/python3-manifest.json
> index 2205cf2d2d..02c918d6e5 100644
> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
> @@ -315,8 +315,6 @@
>               "${libdir}/python${PYTHON_MAJMIN}/traceback.py",
>               "${libdir}/python${PYTHON_MAJMIN}/types.py",
>               "${libdir}/python${PYTHON_MAJMIN}/typing.py",
> -            "${libdir}/python${PYTHON_MAJMIN}/urllib",
> -            "${libdir}/python${PYTHON_MAJMIN}/urllib/parse.py",
>               "${libdir}/python${PYTHON_MAJMIN}/warnings.py",
>               "${libdir}/python${PYTHON_MAJMIN}/weakref.py",
>               "${prefix}/lib/python${PYTHON_MAJMIN}/config*/*[!.a]"
> @@ -402,9 +400,7 @@
>               "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__",
>               "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__/abc.*.pyc",
>               "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__/machinery.*.pyc",
> -            "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__/util.*.pyc",
> -            "${libdir}/python${PYTHON_MAJMIN}/urllib/__pycache__",
> -            "${libdir}/python${PYTHON_MAJMIN}/urllib/__pycache__/parse.*.pyc"
> +            "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__/util.*.pyc"
>           ]
>       },
>       "crypt": {
> @@ -876,6 +872,8 @@
>               "${libdir}/python${PYTHON_MAJMIN}/secrets.py",
>               "${libdir}/python${PYTHON_MAJMIN}/smtplib.py",
>               "${libdir}/python${PYTHON_MAJMIN}/telnetlib.py",
> +            "${libdir}/python${PYTHON_MAJMIN}/urllib",
> +            "${libdir}/python${PYTHON_MAJMIN}/urllib/parse.py",
>               "${libdir}/python${PYTHON_MAJMIN}/uuid.py"
>           ],
>           "cached": [
> @@ -888,6 +886,8 @@
>               "${libdir}/python${PYTHON_MAJMIN}/__pycache__/secrets.*.pyc",
>               "${libdir}/python${PYTHON_MAJMIN}/__pycache__/smtplib.*.pyc",
>               "${libdir}/python${PYTHON_MAJMIN}/__pycache__/telnetlib.*.pyc",
> +            "${libdir}/python${PYTHON_MAJMIN}/urllib/__pycache__",
> +            "${libdir}/python${PYTHON_MAJMIN}/urllib/__pycache__/parse.*.pyc",
>               "${libdir}/python${PYTHON_MAJMIN}/__pycache__/uuid.*.pyc"
>           ]
>       },
Alexander Kanavin Oct. 25, 2022, 9:13 a.m. UTC | #2
Patch merging is on hold now, please do read the weekly status update
emails when in doubt.

Alex


On Tue, 25 Oct 2022 at 10:41, Leon Anavi <leon.anavi@konsulko.com> wrote:
>
> Hi,
>
> It has been 2 weeks since I submitted this patch for openembedded-core.
> I am wondering if it will be merged in master/master-next. Please let me
> know if any changes are needed. Is the patch OK?
>
> Thanks,
> Leon
>
> On 11.10.22 г. 14:10 ч., Leon Anavi wrote:
> > Move urllib from core to netclient because it imports base64.
> >
> > Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> > ---
> >   .../python/python3/python3-manifest.json               | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json b/meta/recipes-devtools/python/python3/python3-manifest.json
> > index 2205cf2d2d..02c918d6e5 100644
> > --- a/meta/recipes-devtools/python/python3/python3-manifest.json
> > +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
> > @@ -315,8 +315,6 @@
> >               "${libdir}/python${PYTHON_MAJMIN}/traceback.py",
> >               "${libdir}/python${PYTHON_MAJMIN}/types.py",
> >               "${libdir}/python${PYTHON_MAJMIN}/typing.py",
> > -            "${libdir}/python${PYTHON_MAJMIN}/urllib",
> > -            "${libdir}/python${PYTHON_MAJMIN}/urllib/parse.py",
> >               "${libdir}/python${PYTHON_MAJMIN}/warnings.py",
> >               "${libdir}/python${PYTHON_MAJMIN}/weakref.py",
> >               "${prefix}/lib/python${PYTHON_MAJMIN}/config*/*[!.a]"
> > @@ -402,9 +400,7 @@
> >               "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__",
> >               "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__/abc.*.pyc",
> >               "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__/machinery.*.pyc",
> > -            "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__/util.*.pyc",
> > -            "${libdir}/python${PYTHON_MAJMIN}/urllib/__pycache__",
> > -            "${libdir}/python${PYTHON_MAJMIN}/urllib/__pycache__/parse.*.pyc"
> > +            "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__/util.*.pyc"
> >           ]
> >       },
> >       "crypt": {
> > @@ -876,6 +872,8 @@
> >               "${libdir}/python${PYTHON_MAJMIN}/secrets.py",
> >               "${libdir}/python${PYTHON_MAJMIN}/smtplib.py",
> >               "${libdir}/python${PYTHON_MAJMIN}/telnetlib.py",
> > +            "${libdir}/python${PYTHON_MAJMIN}/urllib",
> > +            "${libdir}/python${PYTHON_MAJMIN}/urllib/parse.py",
> >               "${libdir}/python${PYTHON_MAJMIN}/uuid.py"
> >           ],
> >           "cached": [
> > @@ -888,6 +886,8 @@
> >               "${libdir}/python${PYTHON_MAJMIN}/__pycache__/secrets.*.pyc",
> >               "${libdir}/python${PYTHON_MAJMIN}/__pycache__/smtplib.*.pyc",
> >               "${libdir}/python${PYTHON_MAJMIN}/__pycache__/telnetlib.*.pyc",
> > +            "${libdir}/python${PYTHON_MAJMIN}/urllib/__pycache__",
> > +            "${libdir}/python${PYTHON_MAJMIN}/urllib/__pycache__/parse.*.pyc",
> >               "${libdir}/python${PYTHON_MAJMIN}/__pycache__/uuid.*.pyc"
> >           ]
> >       },
>
> --
> Leon Anavi
> Software Engineer
> konsulko.com
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#172123): https://lists.openembedded.org/g/openembedded-core/message/172123
> Mute This Topic: https://lists.openembedded.org/mt/94256015/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json b/meta/recipes-devtools/python/python3/python3-manifest.json
index 2205cf2d2d..02c918d6e5 100644
--- a/meta/recipes-devtools/python/python3/python3-manifest.json
+++ b/meta/recipes-devtools/python/python3/python3-manifest.json
@@ -315,8 +315,6 @@ 
             "${libdir}/python${PYTHON_MAJMIN}/traceback.py",
             "${libdir}/python${PYTHON_MAJMIN}/types.py",
             "${libdir}/python${PYTHON_MAJMIN}/typing.py",
-            "${libdir}/python${PYTHON_MAJMIN}/urllib",
-            "${libdir}/python${PYTHON_MAJMIN}/urllib/parse.py",
             "${libdir}/python${PYTHON_MAJMIN}/warnings.py",
             "${libdir}/python${PYTHON_MAJMIN}/weakref.py",
             "${prefix}/lib/python${PYTHON_MAJMIN}/config*/*[!.a]"
@@ -402,9 +400,7 @@ 
             "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__",
             "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__/abc.*.pyc",
             "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__/machinery.*.pyc",
-            "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__/util.*.pyc",
-            "${libdir}/python${PYTHON_MAJMIN}/urllib/__pycache__",
-            "${libdir}/python${PYTHON_MAJMIN}/urllib/__pycache__/parse.*.pyc"
+            "${libdir}/python${PYTHON_MAJMIN}/importlib/__pycache__/util.*.pyc"
         ]
     },
     "crypt": {
@@ -876,6 +872,8 @@ 
             "${libdir}/python${PYTHON_MAJMIN}/secrets.py",
             "${libdir}/python${PYTHON_MAJMIN}/smtplib.py",
             "${libdir}/python${PYTHON_MAJMIN}/telnetlib.py",
+            "${libdir}/python${PYTHON_MAJMIN}/urllib",
+            "${libdir}/python${PYTHON_MAJMIN}/urllib/parse.py",
             "${libdir}/python${PYTHON_MAJMIN}/uuid.py"
         ],
         "cached": [
@@ -888,6 +886,8 @@ 
             "${libdir}/python${PYTHON_MAJMIN}/__pycache__/secrets.*.pyc",
             "${libdir}/python${PYTHON_MAJMIN}/__pycache__/smtplib.*.pyc",
             "${libdir}/python${PYTHON_MAJMIN}/__pycache__/telnetlib.*.pyc",
+            "${libdir}/python${PYTHON_MAJMIN}/urllib/__pycache__",
+            "${libdir}/python${PYTHON_MAJMIN}/urllib/__pycache__/parse.*.pyc",
             "${libdir}/python${PYTHON_MAJMIN}/__pycache__/uuid.*.pyc"
         ]
     },