diff mbox series

[master|langdale|kirkstone] qemu-native: Add PACKAGECONFIG option for jack

Message ID 20221010192655.3930156-1-jpuhlman@mvista.com
State New, archived
Headers show
Series [master|langdale|kirkstone] qemu-native: Add PACKAGECONFIG option for jack | expand

Commit Message

Jeremy Puhlman Oct. 10, 2022, 7:26 p.m. UTC
Source: MontaVista Software, LLC
MR: 122826
Type: Defect Fix
Disposition:  Needs submitting to poky
ChangeID: ecf4ddeb82db6fbb5c6c803e5e80c333587b9c9c
Description:

With libjack-devel or jack-audio-connection-kit-devel, qemu-native
detects the library/header and tries to build with it. Since its
missing from the sysroot, it fails to build.

 -O2 -fPIE -D_REENTRANT -Wno-undef -MD -MQ libcommon.fa.p/audio_jackaudio.c.o
-MF libcommon.fa.p/audio_jackaudio.c.o.d -o libcommon.fa.p/audio_jackaudio.c.o
-c ../qemu-6.2.0/audio/jackaudio.c
| ../qemu-6.2.0/audio/jackaudio.c:34:10: fatal error: jack/jack.h: No such file
or directory
|    34 | #include <jack/jack.h>
|       |          ^~~~~~~~~~~~~
| compilation terminated.

Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
---
 meta/recipes-devtools/qemu/qemu.inc | 1 +
 1 file changed, 1 insertion(+)

Comments

Khem Raj Oct. 10, 2022, 7:39 p.m. UTC | #1
On Mon, Oct 10, 2022 at 12:27 PM Jeremy Puhlman <jpuhlman@mvista.com> wrote:
>
> Source: MontaVista Software, LLC
> MR: 122826
> Type: Defect Fix
> Disposition:  Needs submitting to poky

Above seems out of context, since you are submitting it upstream here.

> ChangeID: ecf4ddeb82db6fbb5c6c803e5e80c333587b9c9c
> Description:
>
> With libjack-devel or jack-audio-connection-kit-devel, qemu-native
> detects the library/header and tries to build with it. Since its
> missing from the sysroot, it fails to build.
>
>  -O2 -fPIE -D_REENTRANT -Wno-undef -MD -MQ libcommon.fa.p/audio_jackaudio.c.o
> -MF libcommon.fa.p/audio_jackaudio.c.o.d -o libcommon.fa.p/audio_jackaudio.c.o
> -c ../qemu-6.2.0/audio/jackaudio.c
> | ../qemu-6.2.0/audio/jackaudio.c:34:10: fatal error: jack/jack.h: No such file
> or directory
> |    34 | #include <jack/jack.h>
> |       |          ^~~~~~~~~~~~~
> | compilation terminated.
>
> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
> ---
>  meta/recipes-devtools/qemu/qemu.inc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
> index 612abd240a..711982ba8d 100644
> --- a/meta/recipes-devtools/qemu/qemu.inc
> +++ b/meta/recipes-devtools/qemu/qemu.inc
> @@ -198,6 +198,7 @@ PACKAGECONFIG[rdma] = "--enable-rdma,--disable-rdma"
>  PACKAGECONFIG[vde] = "--enable-vde,--disable-vde"
>  PACKAGECONFIG[slirp] = "--enable-slirp=internal,--disable-slirp"
>  PACKAGECONFIG[brlapi] = "--enable-brlapi,--disable-brlapi"
> +PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack,"
>
>  INSANE_SKIP:${PN} = "arch"
>
> --
> 2.35.4
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171580): https://lists.openembedded.org/g/openembedded-core/message/171580
> Mute This Topic: https://lists.openembedded.org/mt/94244017/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Jeremy Puhlman Oct. 10, 2022, 7:51 p.m. UTC | #2
On 10/10/2022 12:39 PM, Khem Raj wrote:
> On Mon, Oct 10, 2022 at 12:27 PM Jeremy Puhlman <jpuhlman@mvista.com> wrote:
>> Source: MontaVista Software, LLC
>> MR: 122826
>> Type: Defect Fix
>> Disposition:  Needs submitting to poky
> Above seems out of context, since you are submitting it upstream here.
Well it was cherry picked from a bug in our system, and was pushing it 
to upstream, I can change it to something else.
>
>> ChangeID: ecf4ddeb82db6fbb5c6c803e5e80c333587b9c9c
>> Description:
>>
>> With libjack-devel or jack-audio-connection-kit-devel, qemu-native
>> detects the library/header and tries to build with it. Since its
>> missing from the sysroot, it fails to build.
>>
>>   -O2 -fPIE -D_REENTRANT -Wno-undef -MD -MQ libcommon.fa.p/audio_jackaudio.c.o
>> -MF libcommon.fa.p/audio_jackaudio.c.o.d -o libcommon.fa.p/audio_jackaudio.c.o
>> -c ../qemu-6.2.0/audio/jackaudio.c
>> | ../qemu-6.2.0/audio/jackaudio.c:34:10: fatal error: jack/jack.h: No such file
>> or directory
>> |    34 | #include <jack/jack.h>
>> |       |          ^~~~~~~~~~~~~
>> | compilation terminated.
>>
>> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
>> ---
>>   meta/recipes-devtools/qemu/qemu.inc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
>> index 612abd240a..711982ba8d 100644
>> --- a/meta/recipes-devtools/qemu/qemu.inc
>> +++ b/meta/recipes-devtools/qemu/qemu.inc
>> @@ -198,6 +198,7 @@ PACKAGECONFIG[rdma] = "--enable-rdma,--disable-rdma"
>>   PACKAGECONFIG[vde] = "--enable-vde,--disable-vde"
>>   PACKAGECONFIG[slirp] = "--enable-slirp=internal,--disable-slirp"
>>   PACKAGECONFIG[brlapi] = "--enable-brlapi,--disable-brlapi"
>> +PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack,"
>>
>>   INSANE_SKIP:${PN} = "arch"
>>
>> --
>> 2.35.4
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#171580): https://lists.openembedded.org/g/openembedded-core/message/171580
>> Mute This Topic: https://lists.openembedded.org/mt/94244017/1997914
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
diff mbox series

Patch

diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
index 612abd240a..711982ba8d 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -198,6 +198,7 @@  PACKAGECONFIG[rdma] = "--enable-rdma,--disable-rdma"
 PACKAGECONFIG[vde] = "--enable-vde,--disable-vde"
 PACKAGECONFIG[slirp] = "--enable-slirp=internal,--disable-slirp"
 PACKAGECONFIG[brlapi] = "--enable-brlapi,--disable-brlapi"
+PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack,"
 
 INSANE_SKIP:${PN} = "arch"