[v2] glibc: ptest: Fix glibc-tests package issue

Message ID 20220416075413.158057-1-pgowda.cve@gmail.com
State Accepted, archived
Commit 5555e7cf935b047a3dc3228d26bf0fd52eb425e5
Headers show
Series [v2] glibc: ptest: Fix glibc-tests package issue | expand

Commit Message

Pgowda April 16, 2022, 7:54 a.m. UTC
The current default DISTRO_FEATURES does not support ptest.
Hence, the following error is generated during "bitbake glibc-tests".
ERROR: glibc-tests-2.35-r0 do_package: QA Issue: glibc-tests:
Files/directories were installed but not shipped in any package
The issue is not reproduced with "DISTRO = Yocto" as DISTRO_FEATURES
in Yocto supports ptest. However, when we run "glibc-tests" using
Open-embedded master sources; it generates the error as default
DISTRO is used.

Signed-off-by: pgowda <pgowda.cve@gmail.com>
---
 meta/recipes-core/glibc/glibc-tests_2.35.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

Richard Purdie April 16, 2022, 8:09 a.m. UTC | #1
On Sat, 2022-04-16 at 00:54 -0700, pgowda wrote:
> The current default DISTRO_FEATURES does not support ptest.
> Hence, the following error is generated during "bitbake glibc-tests".
> ERROR: glibc-tests-2.35-r0 do_package: QA Issue: glibc-tests:
> Files/directories were installed but not shipped in any package
> The issue is not reproduced with "DISTRO = Yocto" as DISTRO_FEATURES
> in Yocto supports ptest. However, when we run "glibc-tests" using
> Open-embedded master sources; it generates the error as default
> DISTRO is used.
> 
> Signed-off-by: pgowda <pgowda.cve@gmail.com>
> ---
>  meta/recipes-core/glibc/glibc-tests_2.35.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-core/glibc/glibc-tests_2.35.bb b/meta/recipes-core/glibc/glibc-tests_2.35.bb
> index 8c7ecf89ba..fc6eee91ec 100644
> --- a/meta/recipes-core/glibc/glibc-tests_2.35.bb
> +++ b/meta/recipes-core/glibc/glibc-tests_2.35.bb
> @@ -29,6 +29,8 @@ RRECOMMENDS:${PN} = ""
>  RDEPENDS:${PN} = " glibc sed"
>  DEPENDS:append = " sed"
>  
> +DISTRO_FEATURES:append = " ptest"
> +
>  # Just build tests for target - do not run them
>  do_check:append () {
>  	oe_runmake -i check run-built-tests=no

This isn't what I meant. I meant something like:

REQUIRED_DISTRO_FEATURES = 'ptest'
inherit features_check

Cheers,

Richard

Patch

diff --git a/meta/recipes-core/glibc/glibc-tests_2.35.bb b/meta/recipes-core/glibc/glibc-tests_2.35.bb
index 8c7ecf89ba..fc6eee91ec 100644
--- a/meta/recipes-core/glibc/glibc-tests_2.35.bb
+++ b/meta/recipes-core/glibc/glibc-tests_2.35.bb
@@ -29,6 +29,8 @@  RRECOMMENDS:${PN} = ""
 RDEPENDS:${PN} = " glibc sed"
 DEPENDS:append = " sed"
 
+DISTRO_FEATURES:append = " ptest"
+
 # Just build tests for target - do not run them
 do_check:append () {
 	oe_runmake -i check run-built-tests=no