scripts/lnr: remove

Message ID 20211117172308.204731-1-ross.burton@arm.com
State Accepted, archived
Commit 723b6e40f5943426364bffce7c58ade65c4abbba
Headers show
Series scripts/lnr: remove | expand

Commit Message

Ross Burton Nov. 17, 2021, 5:23 p.m. UTC
lnr is a script that implements the same behaviour as 'ln --relative
--symlink', as at the time of creation --relative was only available in
coreutils 8.16 onwards which was too new for the older supported distros.

Now, however, everyone has a new enough coreutils, so we can remove this
script.

All users of lnr should be replaced with ln --relative --symbolic.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 scripts/lnr | 24 ------------------------
 1 file changed, 24 deletions(-)
 delete mode 100755 scripts/lnr

Comments

Ross Burton Nov. 19, 2021, 9:25 a.m. UTC | #1
On Wed, 17 Nov 2021 at 18:24, Quentin Schulz <foss+yocto@0leil.net> wrote:
> We could have a simple wrapper instead which would be a simple shell script:
>
> #!/bin/sh
>
> ln --relative --symbolic $1 $2
>
> To not require a change in layers?
> Not sure it's that important considering that one could do a simple sed across all layers? Anyway just thought about that so shared it.

The point was requiring the change in layers so we're using standard
tools and not pointless scripts.  I sent patches for some larger
layers already so the fallout shouldn't be *too* bad.

Ross

Patch

diff --git a/scripts/lnr b/scripts/lnr
deleted file mode 100755
index a2ac4fec0f..0000000000
--- a/scripts/lnr
+++ /dev/null
@@ -1,24 +0,0 @@ 
-#! /usr/bin/env python3
-#
-# SPDX-License-Identifier: GPL-2.0-only
-#
-
-# Create a *relative* symlink, just like ln --relative does but without needing
-# coreutils 8.16.
-
-import sys, os
-
-if len(sys.argv) != 3:
-   print("$ lnr TARGET LINK_NAME")
-   sys.exit(1)
-
-target = sys.argv[1]
-linkname = sys.argv[2]
-
-if os.path.isabs(target):
-   if not os.path.isabs(linkname):
-      linkname = os.path.abspath(linkname)
-   start = os.path.dirname(linkname)
-   target = os.path.relpath(target, start)
-
-os.symlink(target, linkname)