mbox series

[0/1] rng-tools: remove unneeded build time dependency

Message ID 20240108220903.4086110-1-david.zuhn@sonos.com
Headers show
Series rng-tools: remove unneeded build time dependency | expand

Message

david d zuhn Jan. 8, 2024, 10:09 p.m. UTC 
rng-tools used to depend on libsysfs, but has since been changed
to read directly from the /sys filesystem.  The build time
dependency on sysfsutils is no longer needed.

david d zuhn (1):
  rng-tools: remove obsolete build time dependency on sysfsutils

 meta/recipes-support/rng-tools/rng-tools_6.16.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mikko Rapeli Jan. 9, 2024, 6:56 a.m. UTC | #1 
Hi,

On Mon, Jan 08, 2024 at 04:09:02PM -0600, david zuhn via lists.openembedded.org wrote:
> rng-tools used to depend on libsysfs, but has since been changed
> to read directly from the /sys filesystem.  The build time
> dependency on sysfsutils is no longer needed.

This is a good change log entry but should be in the git commit directly
to be recorded in git history. No need for extra cover letter if change itself
documents everything.

Cheers,

-Mikko
Randy MacLeod Jan. 10, 2024, 4:25 a.m. UTC | #2 
Hello David and thanks for all the Sonos speakers!

I'm not at my computer right now but it looks like nothing in oe-core
depends on rng-tools anymore since the 5.6 kernel release:

https://wiki.archlinux.org/title/Rng-tools

And note:

http://layers.openembedded.org/layerindex/branch/master/recipes/?q=depends%3Arng-tools


If this is accurate, it's a good time to move rng-tools to meta-oe for
people who still want to run rndg as a service for some reason or for those
who want to run rng-test.

Does that make sense? And if so can you send the patches?

Randy

On Tue., Jan. 9, 2024, 01:56 Mikko Rapeli, <mikko.rapeli@linaro.org> wrote:

> Hi,
>
> On Mon, Jan 08, 2024 at 04:09:02PM -0600, david zuhn via
> lists.openembedded.org wrote:
> > rng-tools used to depend on libsysfs, but has since been changed
> > to read directly from the /sys filesystem.  The build time
> > dependency on sysfsutils is no longer needed.
>
> This is a good change log entry but should be in the git commit directly
> to be recorded in git history. No need for extra cover letter if change
> itself
> documents everything.
>
> Cheers,
>
> -Mikko
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#193443):
> https://lists.openembedded.org/g/openembedded-core/message/193443
> Mute This Topic: https://lists.openembedded.org/mt/103608803/953399
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> rwmacleod@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>