mbox series

[0/5,v3] image_types: use IMAGE_FILE_MAXSIZE variable to create fixed partition size

Message ID 20231101231058.86928-1-charles-antoine.couret@mind.be
Headers show
Series image_types: use IMAGE_FILE_MAXSIZE variable to create fixed partition size | expand

Message

Charles-Antoine Couret Nov. 1, 2023, 11:10 p.m. UTC
Details are described in the first patch.

Difference from v2:

* Added working and failing tests in meta/lib/oeqa/selftest/cases/imagefeatures.py
* Split commit to send documentation to right mailing list

Difference from v1:

* Added documentation for IMAGE_FILE_MAXSIZE variable
* Added Python function to get the value of this variable from shell functions
otherwise parsing issue can happen
* Added an additional task to check the final result which works for all filesystems
and not only those created with dd command.

Charles-Antoine Couret (6):
  image_types: add python function to get the IMAGE_FILE_MAXSIZE:fstype
    value
  image_types: use IMAGE_FILE_MAXSIZE variable for ext2/3/4 image types
  image_types: use IMAGE_FILE_MAXSIZE variable for btrfs image types
  image_types: use IMAGE_FILE_MAXSIZE variable for f2fs image types
  image: add check_image_max_size as post function to check file size
    against IMAGE_FILE_MAXSIZE
  ref-manual: document IMAGE_FILE_MAXSIZE variable

 documentation/ref-manual/variables.rst        | 14 +++++
 meta/classes-recipe/image.bbclass             | 30 +++++++++++
 meta/classes-recipe/image_types.bbclass       | 43 ++++++++++++---
 meta/lib/oeqa/selftest/cases/imagefeatures.py | 52 +++++++++++++++++++
 4 files changed, 131 insertions(+), 8 deletions(-)

Comments

Alexandre Belloni Nov. 5, 2023, 12:26 a.m. UTC | #1
Hello,

The tests fail on the ubuntu and debian workers but seemed to pass just
fine on fedora:

https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/5941/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6008/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/127/builds/2369/steps/15/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6010/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/5943/steps/14/logs/stdio

I'm not sure the login timeout is relevant.

Also, can you please fix your git configuration:
https://docs.yoctoproject.org/dev/contributor-guide/submit-changes.html#fixing-your-from-identity

On 02/11/2023 00:10:49+0100, Charles-Antoine Couret via lists.openembedded.org wrote:
> Details are described in the first patch.
> 
> Difference from v2:
> 
> * Added working and failing tests in meta/lib/oeqa/selftest/cases/imagefeatures.py
> * Split commit to send documentation to right mailing list
> 
> Difference from v1:
> 
> * Added documentation for IMAGE_FILE_MAXSIZE variable
> * Added Python function to get the value of this variable from shell functions
> otherwise parsing issue can happen
> * Added an additional task to check the final result which works for all filesystems
> and not only those created with dd command.
> 
> Charles-Antoine Couret (6):
>   image_types: add python function to get the IMAGE_FILE_MAXSIZE:fstype
>     value
>   image_types: use IMAGE_FILE_MAXSIZE variable for ext2/3/4 image types
>   image_types: use IMAGE_FILE_MAXSIZE variable for btrfs image types
>   image_types: use IMAGE_FILE_MAXSIZE variable for f2fs image types
>   image: add check_image_max_size as post function to check file size
>     against IMAGE_FILE_MAXSIZE
>   ref-manual: document IMAGE_FILE_MAXSIZE variable
> 
>  documentation/ref-manual/variables.rst        | 14 +++++
>  meta/classes-recipe/image.bbclass             | 30 +++++++++++
>  meta/classes-recipe/image_types.bbclass       | 43 ++++++++++++---
>  meta/lib/oeqa/selftest/cases/imagefeatures.py | 52 +++++++++++++++++++
>  4 files changed, 131 insertions(+), 8 deletions(-)
> 
> -- 
> 2.41.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#190048): https://lists.openembedded.org/g/openembedded-core/message/190048
> Mute This Topic: https://lists.openembedded.org/mt/102331599/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>