| Message ID | 20230714093554.2402426-3-u.oelmann@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/3] ref-manual: classes: kernel-fitimage: fix source of imagetype | expand |
Hi Ulrich, On 14.07.23 at 11:35, Ulrich Ölmann wrote: > Although it might seem a little bit pedantic this patch describes what the class > actually checks (see e.g. [1]) and kernel.bbclass per default sets the parameter > INITRAMFS_IMAGE_BUNDLE to the empty string (see [2]) which already satisfies > that check without the need of additionally explicitly setting it to '0'. > > [1] https://git.yoctoproject.org/poky/tree/meta/classes-recipe/kernel-fitimage.bbclass?h=4.3_M1&id=cc97d775cb402df0d4122bf54eab1a5198c98471#n667 > [2] https://git.yoctoproject.org/poky/tree/meta/classes-recipe/kernel.bbclass?h=4.3_M1&id=cc97d775cb402df0d4122bf54eab1a5198c98471#n37 > > Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de> > --- > documentation/ref-manual/classes.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/documentation/ref-manual/classes.rst b/documentation/ref-manual/classes.rst > index dc30419a1e7f..4577baba3e66 100644 > --- a/documentation/ref-manual/classes.rst > +++ b/documentation/ref-manual/classes.rst > @@ -1625,7 +1625,7 @@ The address where the RAM disk image is to be loaded by U-Boot > is specified by :term:`UBOOT_RD_LOADADDRESS` and the entrypoint by > :term:`UBOOT_RD_ENTRYPOINT`. The ramdisk is added to the FIT image when > :term:`INITRAMFS_IMAGE` is specified and requires that :term:`INITRAMFS_IMAGE_BUNDLE` > -is set to 0. > +is not set to 1. > > Only a single :term:`Initramfs` bundle can be added to the FIT image created by > :ref:`ref-classes-kernel-fitimage` and the :term:`Initramfs` bundle in FIT is optional. Many thanks for the 3 patches, much appreciated as always. For the 3 patches: Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com> Merged into master-next. Thanks again Michael.
diff --git a/documentation/ref-manual/classes.rst b/documentation/ref-manual/classes.rst index dc30419a1e7f..4577baba3e66 100644 --- a/documentation/ref-manual/classes.rst +++ b/documentation/ref-manual/classes.rst @@ -1625,7 +1625,7 @@ The address where the RAM disk image is to be loaded by U-Boot is specified by :term:`UBOOT_RD_LOADADDRESS` and the entrypoint by :term:`UBOOT_RD_ENTRYPOINT`. The ramdisk is added to the FIT image when :term:`INITRAMFS_IMAGE` is specified and requires that :term:`INITRAMFS_IMAGE_BUNDLE` -is set to 0. +is not set to 1. Only a single :term:`Initramfs` bundle can be added to the FIT image created by :ref:`ref-classes-kernel-fitimage` and the :term:`Initramfs` bundle in FIT is optional.
Although it might seem a little bit pedantic this patch describes what the class actually checks (see e.g. [1]) and kernel.bbclass per default sets the parameter INITRAMFS_IMAGE_BUNDLE to the empty string (see [2]) which already satisfies that check without the need of additionally explicitly setting it to '0'. [1] https://git.yoctoproject.org/poky/tree/meta/classes-recipe/kernel-fitimage.bbclass?h=4.3_M1&id=cc97d775cb402df0d4122bf54eab1a5198c98471#n667 [2] https://git.yoctoproject.org/poky/tree/meta/classes-recipe/kernel.bbclass?h=4.3_M1&id=cc97d775cb402df0d4122bf54eab1a5198c98471#n37 Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de> --- documentation/ref-manual/classes.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)