npmsw fetcher: Avoid instantiating Fetch class if url list is empty

Recipes containing both git and npmsw sources in the SRC_URI
fail during fetch from the shrinkwrap. It seems that when the fetcher is
fetching from the shrinkwrap, the SRCREV variable has been deleted but it
still ends up fetching from the git source resulting in an error because
SRCREV is undefined. The root cause of this is that the Fetch class defaults
to urls from the SRC_URI when the urls parameter contains an empty list. This
patch will ensure that Fetch is not instantiated if the urls list is empty.

Signed-off-by: Svend Meyland Nicolaisen <public@smn.dk>
---
lib/bb/fetch2/npmsw.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

--
2.39.2.windows.1

Hello Svend,

On Sun, 16 Apr 2023 13:07:15 -0700
public@smn.dk wrote:

> Recipes containing both git and npmsw sources in the SRC_URI
> fail during fetch from the shrinkwrap. It seems that when the fetcher is
> fetching from the shrinkwrap, the SRCREV variable has been deleted but it
> still ends up fetching from the git source resulting in an error because
> SRCREV is undefined. The root cause of this is that the Fetch class defaults
> to urls from the SRC_URI when the urls parameter contains an empty list. This
> patch will ensure that Fetch is not instantiated if the urls list is empty.
> 
> Signed-off-by: Svend Meyland Nicolaisen <public@smn.dk>

Thanks for your patch. However it does not apply using 'git am',
because it is an HTML e-mail.

The simplest way to send a properly formatted patch is using 'git
send-email'.

For more info read:
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded

Hi Svend

On 17.04.23 at 09:53, Luca Ceresoli via lists.openembedded.org wrote:
> Hello Svend,
>
> On Sun, 16 Apr 2023 13:07:15 -0700
> public@smn.dk wrote:
>
>> Recipes containing both git and npmsw sources in the SRC_URI
>> fail during fetch from the shrinkwrap. It seems that when the fetcher is
>> fetching from the shrinkwrap, the SRCREV variable has been deleted but it
>> still ends up fetching from the git source resulting in an error because
>> SRCREV is undefined. The root cause of this is that the Fetch class defaults
>> to urls from the SRC_URI when the urls parameter contains an empty list. This
>> patch will ensure that Fetch is not instantiated if the urls list is empty.
>>
>> Signed-off-by: Svend Meyland Nicolaisen <public@smn.dk>
> Thanks for your patch. However it does not apply using 'git am',
> because it is an HTML e-mail.
>
> The simplest way to send a properly formatted patch is using 'git
> send-email'.
>
> For more info read:
> https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded


In particular, make sure you don't miss 
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity, 
because the way your e-mail is configured, you won't have a correct git 
"Author" field, which should match your "Signed-off-by" information.

Thanks in advance :)
Cheers
Michael.

Thank you for your replies. I had a hassle getting SMTP to work using gmail.com. Now I have sent the patch using "my own" smtp server, wonder why I didn't do that on the first attempts.....

Anyway the patch sent using git send-email ended up in this thread. Is that OK?

Kind regards,
Svend

Hi Svend

On 17.04.23 at 23:18, Svend Meyland Nicolaisen wrote:
> Thank you for your replies. I had a hassle getting SMTP to work using 
> gmail.com. Now I have sent the patch using "my own" smtp server, 
> wonder why I didn't do that on the first attempts.....
>
> Anyway the patch sent using git send-email ended up in this thread. Is 
> that OK?


Yes, everything looks good now and your patch applies nicely.
Thanks!
Michael.