diff mbox series

[v2] fetch2: Adds vscode devcontainer support

Message ID ccc1cddd-3dee-4495-b41c-2dee2b2fe238@schnelte.de
State Accepted, archived
Commit 612bdf09416ff96d08b22cf92b077516d23d0963
Headers show
Series [v2] fetch2: Adds vscode devcontainer support | expand

Commit Message

Matthias Schnelte Sept. 17, 2023, 12:31 p.m. UTC
Visual studio code is injecting a git credential helper
into every dev container. This helper is forwarding the git credentials
from the host into the container.

In order for this helper to work the REMOTE_CONTAINERS_IPC
needs to be available in the environment for all git operations
that require authentication.

v2: Added signed-off

Signed-off-by: Matthias Schnelte <develop@schnelte.de>
---
  lib/bb/fetch2/__init__.py | 1 +
  1 file changed, 1 insertion(+)

Comments

Peter Kjellerstedt Sept. 18, 2023, 9:29 a.m. UTC | #1
> -----Original Message-----
> From: bitbake-devel@lists.openembedded.org <bitbake-devel@lists.openembedded.org> On Behalf Of Matthias Schnelte
> Sent: den 17 september 2023 14:31
> To: bitbake-devel@lists.openembedded.org
> Subject: [bitbake-devel] [PATCH v2] fetch2: Adds vscode devcontainer support
> 
> Visual studio code is injecting a git credential helper
> into every dev container. This helper is forwarding the git credentials
> from the host into the container.
> 
> In order for this helper to work the REMOTE_CONTAINERS_IPC
> needs to be available in the environment for all git operations
> that require authentication.
> 
> v2: Added signed-off

Patch set change information belongs below the --- line below. Otherwise 
it will be part of the actual commit, which normally does not make any 
sense.

> 
> Signed-off-by: Matthias Schnelte <develop@schnelte.de>
> ---
>   lib/bb/fetch2/__init__.py | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
> index 765aedd5..ffb1a92b 100644
> --- a/lib/bb/fetch2/__init__.py
> +++ b/lib/bb/fetch2/__init__.py
> @@ -874,6 +874,7 @@ FETCH_EXPORT_VARS = ['HOME', 'PATH',
>                        'AWS_SECRET_ACCESS_KEY',
>                        'AWS_DEFAULT_REGION',
>                        'GIT_CACHE_PATH',
> +                     'REMOTE_CONTAINERS_IPC',
>                        'SSL_CERT_DIR']
> 
>   def get_fetcher_environment(d):
> --
> 2.42.0

//Peter
diff mbox series

Patch

diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
index 765aedd5..ffb1a92b 100644
--- a/lib/bb/fetch2/__init__.py
+++ b/lib/bb/fetch2/__init__.py
@@ -874,6 +874,7 @@  FETCH_EXPORT_VARS = ['HOME', 'PATH',
                       'AWS_SECRET_ACCESS_KEY',
                       'AWS_DEFAULT_REGION',
                       'GIT_CACHE_PATH',
+                     'REMOTE_CONTAINERS_IPC',
                       'SSL_CERT_DIR']

  def get_fetcher_environment(d):