| Message ID | 20231110172620.396838-1-alassane.yattara@savoirfairelinux.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/6] Toaster: Write UI TestCase -> Visualize all builds | expand |
Hi Alassane, For this series, the patches themselves look ok but the commit messages still needs improvement. To show why, have a look at this view: https://git.openembedded.org/bitbake-contrib/log/?h=abelloni/master-next-success I see: Toaster: Toaster: Write UI TestCase -> Visualize all builds Toaster: Toaster: Write UI TestCase -> Visualize all builds Toaster: Write UI TestCase -> Visualize all builds Toaster: Write UI TestCase -> Visualize all builds Toaster: Write UI TestCase -> Visualize all builds Toaster: Write UI TestCase -> Visualize all builds and the issue is that the detail is buried in the main body of the commit message. I can tell they're toaster tests but that is it, I can't tell the difference between those commits. If instead you change the shortlog, you could have a more useful and specific summary like: toaster/tests: Add no builds message test toaster/tests: Add test for build by recipe name search box which is then more meaningful. These messages go on to end up in things like our release logs so they are important. Could you resend please with the shortlog/subject tweaked please? Cheers, Richard On Fri, 2023-11-10 at 18:26 +0100, Alassane Yattara wrote: > Test a message is shown when there are no build in all builds page > > Signed-off-by: Alassane Yattara <alassane.yattara@savoirfairelinux.com> > --- > lib/toaster/tests/browser/test_sample.py | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/lib/toaster/tests/browser/test_sample.py b/lib/toaster/tests/browser/test_sample.py > index b0067c21..73973778 100644 > --- a/lib/toaster/tests/browser/test_sample.py > +++ b/lib/toaster/tests/browser/test_sample.py > @@ -27,3 +27,12 @@ class TestSample(SeleniumTestCase): > self.get(url) > brand_link = self.find('.toaster-navbar-brand a.brand') > self.assertEqual(brand_link.text.strip(), 'Toaster') > + > + def test_no_builds_message(self): > + """ Test that a message is shown when there are no builds """ > + url = reverse('all-builds') > + self.get(url) > + div_msg = self.find('#empty-state-allbuildstable .alert-info') > + > + msg = 'Sorry - no data found' > + self.assertEqual(div_msg.text, msg) > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#15506): https://lists.openembedded.org/g/bitbake-devel/message/15506 > Mute This Topic: https://lists.openembedded.org/mt/102511272/1686473 > Group Owner: bitbake-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [richard.purdie@linuxfoundation.org] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/lib/toaster/tests/browser/test_sample.py b/lib/toaster/tests/browser/test_sample.py index b0067c21..73973778 100644 --- a/lib/toaster/tests/browser/test_sample.py +++ b/lib/toaster/tests/browser/test_sample.py @@ -27,3 +27,12 @@ class TestSample(SeleniumTestCase): self.get(url) brand_link = self.find('.toaster-navbar-brand a.brand') self.assertEqual(brand_link.text.strip(), 'Toaster') + + def test_no_builds_message(self): + """ Test that a message is shown when there are no builds """ + url = reverse('all-builds') + self.get(url) + div_msg = self.find('#empty-state-allbuildstable .alert-info') + + msg = 'Sorry - no data found' + self.assertEqual(div_msg.text, msg)
Test a message is shown when there are no build in all builds page Signed-off-by: Alassane Yattara <alassane.yattara@savoirfairelinux.com> --- lib/toaster/tests/browser/test_sample.py | 9 +++++++++ 1 file changed, 9 insertions(+)