diff mbox series

[2/3] server/process: Improve exception logging

Message ID 20221221233507.519249-2-richard.purdie@linuxfoundation.org
State New
Headers show
Series [1/3] event: Always use threadlock | expand

Commit Message

Richard Purdie Dec. 21, 2022, 11:35 p.m. UTC 
Currently if either idle functions loop suffers a traceback, it is
silently dropped and there is no log message to say what happened.
This change at least means the traceback is in the cooker log, making
some debugging possible.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 lib/bb/server/process.py | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py
index 51eb882092..a3f2829560 100644
--- a/lib/bb/server/process.py
+++ b/lib/bb/server/process.py
@@ -395,6 +395,7 @@  class ProcessServer():
                     if not isinstance(exc, bb.BBHandledException):
                         logger.exception('Running idle function')
                     del self._idlefuns[function]
+                    serverlog("Exception %s broke the idle_thread, exiting" % traceback.format_exc())
                     self.quit = True
 
             if nextsleep is not None:
@@ -424,6 +425,7 @@  class ProcessServer():
                 except Exception as exc:
                     if not isinstance(exc, bb.BBHandledException):
                         logger.exception('Running heartbeat function')
+                    serverlog("Exception %s broke in idle_commands, exiting" % traceback.format_exc())
                     self.quit = True
         if nextsleep and bb.event._heartbeat_enabled and now + nextsleep > self.next_heartbeat:
             # Shorten timeout so that we we wake up in time for