mbox series

[0/3] support git's safe.bareRepository=explicit

Message ID 20240219095454.3211974-1-andre.draszik@linaro.org
Headers show
Series support git's safe.bareRepository=explicit | expand

Message

André Draszik Feb. 19, 2024, 9:52 a.m. UTC
Hi,

When git is configured with safe.bareRepository=explicit [1], various pieces
here just fail. LWN has an article about the problem that this configuration
option addresses and why it is useful in [2].

It also seems that it is being rolled out in some environments as a
default for users.

To reproduce, simply run
    git config --global safe.bareRepository explicit
to add safe.bareRepository=explicit to your ~/.gitconfig, and see things
fail without these patches.

These patches are the first stop-gap step to make bitbake/OE work with this
configuration option enabled. I believe in the future, these should be
converted to invoking git with the --git-dir= option explicitly.

Link: https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/config/safe.txt#n1 [1]
Link: https://lwn.net/Articles/892755/ [2]

Cheers,
Andre'

Comments

Richard Purdie Feb. 19, 2024, 12:08 p.m. UTC | #1
On Mon, 2024-02-19 at 09:52 +0000, André Draszik wrote:
> When git is configured with safe.bareRepository=explicit [1], various pieces
> here just fail. LWN has an article about the problem that this configuration
> option addresses and why it is useful in [2].
> 
> It also seems that it is being rolled out in some environments as a
> default for users.
> 
> To reproduce, simply run
>     git config --global safe.bareRepository explicit
> to add safe.bareRepository=explicit to your ~/.gitconfig, and see things
> fail without these patches.
> 
> These patches are the first stop-gap step to make bitbake/OE work with this
> configuration option enabled. I believe in the future, these should be
> converted to invoking git with the --git-dir= option explicitly.
> 
> Link: https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/config/safe.txt#n1 [1]
> Link: https://lwn.net/Articles/892755/ [2]

Thanks. I'm not thrilled to need to do this and we probably do need a
better solution but a stop gap does help.

It may be an idea to file a bug so we don't forget we need to improve
things?

Thanks,

Richard
André Draszik Feb. 19, 2024, 1:25 p.m. UTC | #2
Hi Richard,

On Mon, 2024-02-19 at 12:08 +0000, Richard Purdie wrote:
> Thanks. I'm not thrilled to need to do this and we probably do need a
> better solution but a stop gap does help.

I had some issues with failing selftests when I converted to --git-dir= initially
instead of the patches here, so I went for this solution as a quicker alternative
for now.

> It may be an idea to file a bug so we don't forget we need to improve
> things?

https://bugzilla.yoctoproject.org/show_bug.cgi?id=15405

Cheers,
Andre'