| Message ID | 20230606230320.2678321-1-rs@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,master/kirkstone] arago-image.inc: fix the default systemd target | expand |
On Tue, Jun 06, 2023 at 06:03:20PM -0500, Randolph Sapp via lists.yoctoproject.org wrote: > From: Randolph Sapp <rs@ti.com> > > SYSTEMD_DEFAULT_TARGET is dynamically set based on the contents of > IMAGE_FEATURES. Would you like to know what doesn't get updated when we > use a bunch of package groups to dictate what is present in the image? > > This makes systemd actually start graphical applications if the opengl > distro feature is set. It assumes the distro is using weston though. I'm Why check for "opengl" and not "wayland" in DISTRO_FEATURES? > sure that will eventually be invalid when the package group contents > drift. > > Signed-off-by: Randolph Sapp <rs@ti.com> > --- > meta-arago-distro/recipes-core/images/arago-image.inc | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc > index d00c1f70..7104d87c 100644 > --- a/meta-arago-distro/recipes-core/images/arago-image.inc > +++ b/meta-arago-distro/recipes-core/images/arago-image.inc > @@ -6,6 +6,11 @@ COMPATIBLE_MACHINE = "ti-soc" > > IMAGE_FEATURES += "package-management splash" > > +# this is required to make sure the proper systemd default target gets set > +IMAGE_FEATURES += " \ > + ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'weston', '',d)} \ > +" > + > # 4KB per 1 inode should be enough > EXTRA_IMAGECMD:ext2.gz += "-i 4096" > > -- > 2.40.1
On 6/6/23 18:20, Denys Dmytriyenko wrote: > On Tue, Jun 06, 2023 at 06:03:20PM -0500, Randolph Sapp via lists.yoctoproject.org wrote: >> From: Randolph Sapp <rs@ti.com> >> >> SYSTEMD_DEFAULT_TARGET is dynamically set based on the contents of >> IMAGE_FEATURES. Would you like to know what doesn't get updated when we >> use a bunch of package groups to dictate what is present in the image? >> >> This makes systemd actually start graphical applications if the opengl >> distro feature is set. It assumes the distro is using weston though. I'm > > Why check for "opengl" and not "wayland" in DISTRO_FEATURES? > Fair enough. Forgot that was a distro feature. V2 inbound > >> sure that will eventually be invalid when the package group contents >> drift. >> >> Signed-off-by: Randolph Sapp <rs@ti.com> >> --- >> meta-arago-distro/recipes-core/images/arago-image.inc | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc >> index d00c1f70..7104d87c 100644 >> --- a/meta-arago-distro/recipes-core/images/arago-image.inc >> +++ b/meta-arago-distro/recipes-core/images/arago-image.inc >> @@ -6,6 +6,11 @@ COMPATIBLE_MACHINE = "ti-soc" >> >> IMAGE_FEATURES += "package-management splash" >> >> +# this is required to make sure the proper systemd default target gets set >> +IMAGE_FEATURES += " \ >> + ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'weston', '',d)} \ >> +" >> + >> # 4KB per 1 inode should be enough >> EXTRA_IMAGECMD:ext2.gz += "-i 4096" >> >> -- >> 2.40.1
diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc index d00c1f70..7104d87c 100644 --- a/meta-arago-distro/recipes-core/images/arago-image.inc +++ b/meta-arago-distro/recipes-core/images/arago-image.inc @@ -6,6 +6,11 @@ COMPATIBLE_MACHINE = "ti-soc" IMAGE_FEATURES += "package-management splash" +# this is required to make sure the proper systemd default target gets set +IMAGE_FEATURES += " \ + ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'weston', '',d)} \ +" + # 4KB per 1 inode should be enough EXTRA_IMAGECMD:ext2.gz += "-i 4096"