mbox series

[meta-arago,kirkstone,0/4] cleanup old/add new chromium

Message ID 20240206175841.32717-1-detheridge@ti.com
Headers show
Series cleanup old/add new chromium | expand

Message

Etheridge, Darren Feb. 6, 2024, 5:58 p.m. UTC
From: Darren Etheridge <detheridge@ti.com>

Sending again (no changes in patch series) but it never made it to
meta-arago list.

Patch series to add IMG PowerVR GPU accelerated Chromium support into
Kirkstone.

Patch 1 and 4 clean up some of the old Chromium cruft that was left in
the kirkstone branch that I can't imagine can possibly be useful now.

Then patch 2 and 3 add in a new dynamic layer to provide GPU support to
Chromium by allowing the PowerVR libraries to be used from within the
Chromium sandbox.   Also apply an upstream Chromium patch to stop
Chromium from segfaulting immediately on startup if no input devices are
detected.
The dynamic layer will append chromium-ozone-wayland to the
IMAGE_INSTALL for tisdk-default-image if the meta-browser layer is
detected.

Currently we need to pin the meta-browser layer to chromium v111 as there are
problems with the GPU integration in newer versions.  This pinning will
be taken care of as part of oe-layersetup once we decide if it becomes a
new "chromium" configuration, or if we add these layers into the normal
kirkstone configurations.  Downside is build time increases
considerably and image size increases.

All of this working depends on IMG PowerVR DDK23.3 being available in
meta-ti - Randolph sent these patches for review last week.

Darren Etheridge (4):
  meta-arago: distro: chromium: remove old dynamic layer
  meta-arago: distro: add a bbapend to patch the chromium browser
  meta-arago: images: update tisdk-default-image to include chromium
  meta-arago: tisdk-default-image: remove old chromium logic

 meta-arago-distro/conf/layer.conf             |  4 +-
 .../chromium-75.0.3770.80-SIOCGSTAMP.patch    | 15 ----
 .../chromium-ozone-wayland/pulse.patch        | 47 ------------
 .../chromium-ozone-wayland_%.bbappend         |  8 --
 ...omium-ozone-wayland_111.0.5563.64.bbappend |  8 ++
 ...dbox-allow-access-to-PowerVR-GPU-fro.patch | 74 +++++++++++++++++++
 ...-chromium-32307795-fix-nullprt-deref.patch | 52 +++++++++++++
 .../images/tisdk-default-image.bbappend       |  3 +
 .../images/tisdk-default-image.bb             | 10 ---
 9 files changed, 139 insertions(+), 82 deletions(-)
 delete mode 100644 meta-arago-distro/dynamic-layers/browser-layer/recipes-browser/chromium/chromium-ozone-wayland/chromium-75.0.3770.80-SIOCGSTAMP.patch
 delete mode 100644 meta-arago-distro/dynamic-layers/browser-layer/recipes-browser/chromium/chromium-ozone-wayland/pulse.patch
 delete mode 100644 meta-arago-distro/dynamic-layers/browser-layer/recipes-browser/chromium/chromium-ozone-wayland_%.bbappend
 create mode 100644 meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland_111.0.5563.64.bbappend
 create mode 100644 meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland_111.0.5563.64/0001-chromium-gpu-sandbox-allow-access-to-PowerVR-GPU-fro.patch
 create mode 100644 meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland_111.0.5563.64/0002-upstream-chromium-32307795-fix-nullprt-deref.patch
 create mode 100644 meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-core/images/tisdk-default-image.bbappend

Comments

Randolph Sapp Feb. 6, 2024, 6:01 p.m. UTC | #1
On 2/6/24 11:58, detheridge@ti.com wrote:
> From: Darren Etheridge <detheridge@ti.com>
> 
> Sending again (no changes in patch series) but it never made it to
> meta-arago list.
> 
> Patch series to add IMG PowerVR GPU accelerated Chromium support into
> Kirkstone.
> 
> Patch 1 and 4 clean up some of the old Chromium cruft that was left in
> the kirkstone branch that I can't imagine can possibly be useful now.
> 
> Then patch 2 and 3 add in a new dynamic layer to provide GPU support to
> Chromium by allowing the PowerVR libraries to be used from within the
> Chromium sandbox.   Also apply an upstream Chromium patch to stop
> Chromium from segfaulting immediately on startup if no input devices are
> detected.
> The dynamic layer will append chromium-ozone-wayland to the
> IMAGE_INSTALL for tisdk-default-image if the meta-browser layer is
> detected.
> 
> Currently we need to pin the meta-browser layer to chromium v111 as there are
> problems with the GPU integration in newer versions.  This pinning will
> be taken care of as part of oe-layersetup once we decide if it becomes a
> new "chromium" configuration, or if we add these layers into the normal
> kirkstone configurations.  Downside is build time increases
> considerably and image size increases.
> 
> All of this working depends on IMG PowerVR DDK23.3 being available in
> meta-ti - Randolph sent these patches for review last week.
> 
> Darren Etheridge (4):
>    meta-arago: distro: chromium: remove old dynamic layer
>    meta-arago: distro: add a bbapend to patch the chromium browser
>    meta-arago: images: update tisdk-default-image to include chromium
>    meta-arago: tisdk-default-image: remove old chromium logic
> 
>   meta-arago-distro/conf/layer.conf             |  4 +-
>   .../chromium-75.0.3770.80-SIOCGSTAMP.patch    | 15 ----
>   .../chromium-ozone-wayland/pulse.patch        | 47 ------------
>   .../chromium-ozone-wayland_%.bbappend         |  8 --
>   ...omium-ozone-wayland_111.0.5563.64.bbappend |  8 ++
>   ...dbox-allow-access-to-PowerVR-GPU-fro.patch | 74 +++++++++++++++++++
>   ...-chromium-32307795-fix-nullprt-deref.patch | 52 +++++++++++++
>   .../images/tisdk-default-image.bbappend       |  3 +
>   .../images/tisdk-default-image.bb             | 10 ---
>   9 files changed, 139 insertions(+), 82 deletions(-)
>   delete mode 100644 meta-arago-distro/dynamic-layers/browser-layer/recipes-browser/chromium/chromium-ozone-wayland/chromium-75.0.3770.80-SIOCGSTAMP.patch
>   delete mode 100644 meta-arago-distro/dynamic-layers/browser-layer/recipes-browser/chromium/chromium-ozone-wayland/pulse.patch
>   delete mode 100644 meta-arago-distro/dynamic-layers/browser-layer/recipes-browser/chromium/chromium-ozone-wayland_%.bbappend
>   create mode 100644 meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland_111.0.5563.64.bbappend
>   create mode 100644 meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland_111.0.5563.64/0001-chromium-gpu-sandbox-allow-access-to-PowerVR-GPU-fro.patch
>   create mode 100644 meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland_111.0.5563.64/0002-upstream-chromium-32307795-fix-nullprt-deref.patch
>   create mode 100644 meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-core/images/tisdk-default-image.bbappend
> 

There we go. Finally got outside of the org. Just reiterating:

This looks fine and can be applied to master as well.

Reviewed-by: Randolph Sapp <rs@ti.com>