mbox series

[oe-layersetup,PATCHv2,00/16] Sacrifice your first born to the linter

Message ID 20230614034507.598391-1-res.sapp@gmail.com
Headers show
Series Sacrifice your first born to the linter | expand

Message

Res Sapp June 14, 2023, 3:44 a.m. UTC 
A few days ago someone in the beagle community reported some cryptic
errors from oe-layersetup so I took the time to address all of the
issues reported by Shellcheck and add some extra sanity checks.

I tried to split it into reasonable segments.

Resubmitting with a sane email I guess. Probably good I had to resubmit
it. Apparently somewhere along the way a patch was dropped in the first
series.

Randolph Sapp (16):
  oe-layertool-setup: split logic and/or expressions
  oe-layertool-setup: prefer use of $() notation
  oe-layertool-setup: replace all x comparisons with -n/-z
  oe-layertool-setup: fix all the printf calls
  oe-layertool-setup: fix all quoting, switch eval to export
  oe-layertool-setup: only invoke read with -r
  oe-layertool-setup: check exit code directly
  oe-layertool-setup: guard all cd calls
  oe-layertool-setup: eliminate useless cat
  oe-layertool-setup: use subshell execution with redirect
  oe-layertool-setup: guard against invalid expression in case
  oe-layertool-setup: replace all calls to echo with printf
  oe-layertool-setup: drop unused variable
  oe-layertool-setup: add a path sanity check for oebase
  oe-layertool-setup: fix multi-line printfs
  oe-layertool-setup: add sanity check for layer names

 oe-layertool-setup.sh | 435 +++++++++++++++++++++---------------------
 1 file changed, 220 insertions(+), 215 deletions(-)