Patchwork [meta-xfce] xfce4-screenshooter: Add new recipe

login
register
mail settings
Submitter Andreas Müller
Date Aug. 12, 2011, 11 p.m.
Message ID <1313190057-17104-1-git-send-email-schnitzeltony@gmx.de>
Download mbox | patch
Permalink /patch/9793/
State New, archived
Headers show

Comments

Andreas Müller - Aug. 12, 2011, 11 p.m.
Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>
---
 .../xfce4-screenshooter_1.8.0.bb                   |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.0.bb
Paul Menzel - Aug. 13, 2011, 8:22 a.m.
Am Samstag, den 13.08.2011, 01:00 +0200 schrieb Andreas Mueller:

To be consistent with your other commits this should be

	Add initial recipe with version 1.8.0

although »… recipe for version …« is better as far as I know.

> Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>
> ---
>  .../xfce4-screenshooter_1.8.0.bb                   |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
>  create mode 100644 meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.0.bb
> 
> diff --git a/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.0.bb b/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.0.bb
> new file mode 100644
> index 0000000..9b008c3
> --- /dev/null
> +++ b/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.0.bb
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "An application to take screenshots"

»An« can be left out.

Please add the following fields.

        HOMEPAGE = "http://goodies.xfce.org/projects/applications/xfce4-screenshooter"
        SECTION = "x11/application"


> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=d791728a073bc009b4ffaf00b7599855"
> +DEPENDS = "xfce4-panel libxfce4util libxfce4ui gdk-pixbuf gtk+ glib-2.0 libsoup-2.4 exo libxfixes xext virtual/libx11"
> +
> +PR = "r0"
> +
> +inherit xfce
> +
> +# SRC_URI must follow inherited one
> +SRC_URI = "http://archive.xfce.org/src/apps/${PN}//${@'${PV}'[0:3]}/${PN}-${PV}.tar.bz2 \
> +"

Maybe add an example URL as a comment, so that people not familiar with
regular expression know what is done here.

> +
> +FILES_${PN} += "${datadir}/xfce4/panel-plugins/*"
> +FILES_${PN}-dbg += "${libexecdir}/xfce4/panel-plugins/.debug"
> +
> +SRC_URI[md5sum] = "b51ab5725418e7258273c4a6402adb02"
> +SRC_URI[sha256sum] = "68748a42ae68c5a8e9ed1c14ec5c741a344ab30b5b325b8812220539548ad83e"

I would put the checksums right below the other `SRC_URI` fields, but
your other recipes seem to use put it at the end too.

You can put

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

to the iteration with these comments addressed.


Thanks,

Paul


[1] http://wiki.openembedded.org/index.php/Styleguide

Patch

diff --git a/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.0.bb b/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.0.bb
new file mode 100644
index 0000000..9b008c3
--- /dev/null
+++ b/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.0.bb
@@ -0,0 +1,18 @@ 
+DESCRIPTION = "An application to take screenshots"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d791728a073bc009b4ffaf00b7599855"
+DEPENDS = "xfce4-panel libxfce4util libxfce4ui gdk-pixbuf gtk+ glib-2.0 libsoup-2.4 exo libxfixes xext virtual/libx11"
+
+PR = "r0"
+
+inherit xfce
+
+# SRC_URI must follow inherited one
+SRC_URI = "http://archive.xfce.org/src/apps/${PN}//${@'${PV}'[0:3]}/${PN}-${PV}.tar.bz2 \
+"
+
+FILES_${PN} += "${datadir}/xfce4/panel-plugins/*"
+FILES_${PN}-dbg += "${libexecdir}/xfce4/panel-plugins/.debug"
+
+SRC_URI[md5sum] = "b51ab5725418e7258273c4a6402adb02"
+SRC_URI[sha256sum] = "68748a42ae68c5a8e9ed1c14ec5c741a344ab30b5b325b8812220539548ad83e"