Patchwork bluez4: Added new recipe version 4.96

login
register
mail settings
Submitter Noor Ahsan
Date Aug. 11, 2011, 4 p.m.
Message ID <1313078412-6872-1-git-send-email-noor_ahsan@mentor.com>
Download mbox | patch
Permalink /patch/9613/
State Superseded
Headers show

Comments

Noor Ahsan - Aug. 11, 2011, 4 p.m.
From: Noor Ahsan <noor_ahsan@mentor.com>

* Added new recipe version 4.96.


Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
---
 .../bluez/bluez4-4.96/bluetooth.conf               |   16 ++++
 meta/recipes-connectivity/bluez/bluez4_4.96.bb     |   73 ++++++++++++++++++++
 2 files changed, 89 insertions(+), 0 deletions(-)
Phil Blundell - Aug. 11, 2011, 4:02 p.m.
On Thu, 2011-08-11 at 21:00 +0500, Noor, Ahsan wrote:
> From: Noor Ahsan <noor_ahsan@mentor.com>
> 
> * Added new recipe version 4.96.

Is there a particular reason why we need both this and the old 4.82?

p.
Saul Wold - Aug. 11, 2011, 8:26 p.m.
On 08/11/2011 09:02 AM, Phil Blundell wrote:
> On Thu, 2011-08-11 at 21:00 +0500, Noor, Ahsan wrote:
>> From: Noor Ahsan<noor_ahsan@mentor.com>
>>
>> * Added new recipe version 4.96.
>
> Is there a particular reason why we need both this and the old 4.82?
>
Agreed,

I would entertain a v2 that removes the older recipe, as we don't keep 
older recipes unless there is specific license issues (such as GPLv2 vs 
GPLv3), which does not seem to be the case here.

It's better to do a "git mv" if you can.

Thanks	
	Sau!

> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Noor Ahsan - Aug. 12, 2011, 7:18 a.m.
Hi,

I noticed that meta-oe version of bluez was using Bluetooth.conf file from 4.82's directory 

FILESPATH =. "${COREBASE}/meta/recipes-connectivity/bluez/bluez4-4.82/:"

and meta-oe bluez 4.95 version recipe did not have Bluetooth.conf file in its dir. So that is why I did not touch that recipe otherwise meta-oe recipe will start complaining.

Regards,
Noor

-----Original Message-----
From: Saul Wold [mailto:sgw@linux.intel.com] 
Sent: Friday, August 12, 2011 1:26 AM
To: Patches and discussions about the oe-core layer; Ahsan, Noor
Subject: Re: [OE-core] [PATCH] bluez4: Added new recipe version 4.96

On 08/11/2011 09:02 AM, Phil Blundell wrote:
> On Thu, 2011-08-11 at 21:00 +0500, Noor, Ahsan wrote:
>> From: Noor Ahsan<noor_ahsan@mentor.com>
>>
>> * Added new recipe version 4.96.
>
> Is there a particular reason why we need both this and the old 4.82?
>
Agreed,

I would entertain a v2 that removes the older recipe, as we don't keep 
older recipes unless there is specific license issues (such as GPLv2 vs 
GPLv3), which does not seem to be the case here.

It's better to do a "git mv" if you can.

Thanks	
	Sau!

> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Martin Jansa - Aug. 12, 2011, 7:29 a.m.
On Fri, Aug 12, 2011 at 09:18:29AM +0200, Ahsan, Noor wrote:
> Hi,
> 
> I noticed that meta-oe version of bluez was using Bluetooth.conf file from 4.82's directory 
> 
> FILESPATH =. "${COREBASE}/meta/recipes-connectivity/bluez/bluez4-4.82/:"
> 
> and meta-oe bluez 4.95 version recipe did not have Bluetooth.conf file in its dir. So that is why I did not touch that recipe otherwise meta-oe recipe will start complaining.

I think that's expected with layers.. and someone will update it in
meta-oe as soon as it starts complaining..

otherwise you cannot upgrade any recipe where we have .bbappend for it
in meta-oe

Regards,
Noor Ahsan - Aug. 12, 2011, 7:50 a.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Martin Jansa
> Sent: Friday, August 12, 2011 12:30 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH] bluez4: Added new recipe version 4.96
> 
> On Fri, Aug 12, 2011 at 09:18:29AM +0200, Ahsan, Noor wrote:
> > Hi,
> >
> > I noticed that meta-oe version of bluez was using Bluetooth.conf
file
> > from 4.82's directory
> >
> > FILESPATH =. "${COREBASE}/meta/recipes-connectivity/bluez/bluez4-
> 4.82/:"
> >
> > and meta-oe bluez 4.95 version recipe did not have Bluetooth.conf
> file in its dir. So that is why I did not touch that recipe otherwise
> meta-oe recipe will start complaining.
> 
> I think that's expected with layers.. and someone will update it in
> meta-oe as soon as it starts complaining..
> 
> otherwise you cannot upgrade any recipe where we have .bbappend for it
> in meta-oe
> 
> Regards,
> 
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com


OK .. I'll send out version 2.

Regards,
Noor
Paul Eggleton - Aug. 12, 2011, 9:10 a.m.
On Friday 12 August 2011 08:29:50 Martin Jansa wrote:
> I think that's expected with layers.. and someone will update it in
> meta-oe as soon as it starts complaining..

If we're updating the version in OE-core then do we still need the one in 
meta-oe? What would it do that the OE-core version wouldn't?

Cheers,
Paul
Koen Kooi - Aug. 12, 2011, 10:11 a.m.
Op 12 aug. 2011, om 11:10 heeft Paul Eggleton het volgende geschreven:

> On Friday 12 August 2011 08:29:50 Martin Jansa wrote:
>> I think that's expected with layers.. and someone will update it in
>> meta-oe as soon as it starts complaining..
> 
> If we're updating the version in OE-core then do we still need the one in 
> meta-oe? What would it do that the OE-core version wouldn't?

It would build from scratch, where the OE-core one wouldn't due to missing deps :) And your udev and bluez versions need to match since some utils (hid2hci) moved between them.

On a more serious note, how does one become a maintainer for a recipe in OE-core? Bluez4 only seems to get updates when someone tries to update recipes-connectivity/* and doesn't seem to get actually used or runtime tested.

regards,

Koen
Paul Eggleton - Aug. 12, 2011, 10:29 a.m.
On Friday 12 August 2011 11:11:24 Koen Kooi wrote:
> On a more serious note, how does one become a maintainer for a recipe in
> OE-core? Bluez4 only seems to get updates when someone tries to update
> recipes-connectivity/* and doesn't seem to get actually used or runtime
> tested.

Surely maintainer or not you can just test and send patches for the BlueZ 
recipe in OE-core as you would any other recipe? I suspect if you do this 
often enough you'll become the de-facto maintainer anyway.

Cheers,
Paul
Saul Wold - Aug. 12, 2011, 5:28 p.m.
On 08/12/2011 03:29 AM, Paul Eggleton wrote:
> On Friday 12 August 2011 11:11:24 Koen Kooi wrote:
>> On a more serious note, how does one become a maintainer for a recipe in
>> OE-core? Bluez4 only seems to get updates when someone tries to update
>> recipes-connectivity/* and doesn't seem to get actually used or runtime
>> tested.
>
> Surely maintainer or not you can just test and send patches for the BlueZ
> recipe in OE-core as you would any other recipe? I suspect if you do this
> often enough you'll become the de-facto maintainer anyway.
>
Koen,

Paul is right, and you also have a good point about becoming a 
maintainer. Currently as you have seen, its mostly the Yocto Team doing 
updates with some other fixes and updates coming from the community and 
that these updates are when a team member goes through and does a load 
of them at once.

If you would like to update a recipe, feel free to send tested patches. 
Moving forward, I will propose a process to the OE-Core TSC that would 
include some basic requirements of maintainership, so things don't drift 
into staleness.

Thanks
	Sau!


> Cheers,
> Paul
>

Patch

diff --git a/meta/recipes-connectivity/bluez/bluez4-4.96/bluetooth.conf b/meta/recipes-connectivity/bluez/bluez4-4.96/bluetooth.conf
new file mode 100644
index 0000000..ca5e9e4
--- /dev/null
+++ b/meta/recipes-connectivity/bluez/bluez4-4.96/bluetooth.conf
@@ -0,0 +1,16 @@ 
+<!-- This configuration file specifies the required security policies
+     for Bluetooth core daemon to work. -->
+
+<!DOCTYPE busconfig PUBLIC "-//freedesktop//DTD D-BUS Bus Configuration 1.0//EN"
+ "http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd">
+<busconfig>
+
+  <!-- ../system.conf have denied everything, so we just punch some holes -->
+
+  <policy context="default">
+    <allow own="org.bluez"/>
+    <allow send_destination="org.bluez"/>
+    <allow send_interface="org.bluez.Agent"/>
+  </policy>
+
+</busconfig>
diff --git a/meta/recipes-connectivity/bluez/bluez4_4.96.bb b/meta/recipes-connectivity/bluez/bluez4_4.96.bb
new file mode 100644
index 0000000..ebd2849
--- /dev/null
+++ b/meta/recipes-connectivity/bluez/bluez4_4.96.bb
@@ -0,0 +1,73 @@ 
+SUMMARY = "Linux Bluetooth Stack Userland V4"
+DESCRIPTION = "Linux Bluetooth stack V4 userland components.  These include a system configurations, daemons, tools and system libraries."
+HOMEPAGE = "http://www.bluez.org"
+SECTION = "libs"
+LICENSE = "GPLv2+ & LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
+                    file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
+                    file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
+                    file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191"
+DEPENDS = "gst-plugins-base alsa-lib libusb dbus-glib libnl"
+RDEPENDS_${PN}-dev = "bluez-hcidump"
+
+# For angstrom we want this to replace at least bluez-libs
+PROVIDES_append_angstrom = " bluez-utils bluez-libs"
+
+ASNEEDED = ""
+
+PR = "r0"
+
+SRC_URI = "\
+  ${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.gz \
+  file://bluetooth.conf \
+"
+
+SRC_URI[md5sum] = "296111afac49e3f9035085ac14daf518"
+SRC_URI[sha256sum] = "c06fd50fd77909cad55e3181a42c6bce7cfcf7abb8cd87871c13d0d70f87fa99"
+S = "${WORKDIR}/bluez-${PV}"
+
+inherit autotools
+
+EXTRA_OECONF = "\
+  --enable-gstreamer \
+  --enable-alsa \
+  --enable-usb \
+  --enable-netlink \
+  --enable-tools \
+  --enable-bccmd \
+  --enable-hid2hci \
+  --enable-dfutool \
+  --enable-hidd \
+  --enable-pandd \
+  --enable-dund \
+  --disable-cups \
+  --enable-test \
+  --enable-manpages \
+  --enable-configfiles \
+  --enable-initscripts \
+  --disable-pcmciarules \
+"
+
+do_install_append() {
+	install -m 0644 ${S}/audio/audio.conf ${D}/${sysconfdir}/bluetooth/
+	install -m 0644 ${S}/network/network.conf ${D}/${sysconfdir}/bluetooth/
+	install -m 0644 ${S}/input/input.conf ${D}/${sysconfdir}/bluetooth/
+	# at_console doesn't really work with the current state of OE, so punch some more holes so people can actually use BT
+	install -m 0644 ${WORKDIR}/bluetooth.conf ${D}/${sysconfdir}/dbus-1/system.d/
+}
+
+PACKAGES =+ "gst-plugin-bluez libasound-module-bluez"
+
+FILES_gst-plugin-bluez = "${libdir}/gstreamer-0.10/lib*.so"
+FILES_libasound-module-bluez = "${libdir}/alsa-lib/lib*.so"
+FILES_${PN} += "${libdir}/bluetooth/plugins/*.so"
+FILES_${PN}-dev += "\
+  ${libdir}/bluetooth/plugins/*.la \
+  ${libdir}/alsa-lib/*.la \
+  ${libdir}/gstreamer-0.10/*.la \
+"
+
+FILES_${PN}-dbg += "\
+  ${libdir}/bluetooth/plugins/.debug \
+  ${libdir}/*/.debug \
+"