[v2] coreutils: Tweak packaging variable names for coreutils-dev

Message ID 20220627112432.421296-1-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit a5edae117d0d2a59fd3456ccbeeb6cd35dd1951f
Headers show
Series [v2] coreutils: Tweak packaging variable names for coreutils-dev | expand

Commit Message

Richard Purdie June 27, 2022, 11:24 a.m. UTC
PACKAGES uses ${PN}-dev so be consistent with the addition to the
variable to avoid weird variable conflicts.

The flags variable used here is messy, key expansion and overrides are
not supported by flags. The plain variable access does happen to work
though, so leave it as is for now and note.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-core/coreutils/coreutils_9.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

v2: Add in note about key expansion flags issues

Patch

diff --git a/meta/recipes-core/coreutils/coreutils_9.1.bb b/meta/recipes-core/coreutils/coreutils_9.1.bb
index d57e147a7e0..55663c77136 100644
--- a/meta/recipes-core/coreutils/coreutils_9.1.bb
+++ b/meta/recipes-core/coreutils/coreutils_9.1.bb
@@ -171,8 +171,9 @@  RDEPENDS:${PN}-ptest += "bash findutils gawk liberror-perl make perl perl-module
 
 # -dev automatic dependencies fails as we don't want libmodule-build-perl-dev, its too heavy
 # may need tweaking if DEPENDS changes
+# Can't use ${PN}-dev here since flags with overrides and key expansion not supported
 RRECOMMENDS:coreutils-dev[nodeprrecs] = "1"
-RRECOMMENDS:coreutils-dev = "acl-dev attr-dev gmp-dev libcap-dev bash-dev findutils-dev gawk-dev shadow-dev"
+RRECOMMENDS:${PN}-dev += "acl-dev attr-dev gmp-dev libcap-dev bash-dev findutils-dev gawk-dev shadow-dev"
 
 do_install_ptest () {
     install -d ${D}${PTEST_PATH}/tests