Patchwork gtk-icon-cache: fix RDEPENDS append bug

login
register
mail settings
Submitter Koen Kooi
Date Aug. 6, 2011, 7:25 a.m.
Message ID <1312615528-23732-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/9448/
State New, archived
Headers show

Comments

Koen Kooi - Aug. 6, 2011, 7:25 a.m.
python += doesn't add a leading space, which we do need:

| Collected errors:
|  * satisfy_dependencies_for: Cannot satisfy the following dependencies for task-gnome-themes:
|  *    gnome-icon-themehicolor-icon-theme *
|  * opkg_install_cmd: Cannot install package task-gnome-themes.
|  * satisfy_dependencies_for: Cannot satisfy the following dependencies for task-gnome-apps:
|  *    iso-codeshicolor-icon-theme *
|  * opkg_install_cmd: Cannot install package task-gnome-apps.
|  * satisfy_dependencies_for: Cannot satisfy the following dependencies for task-gnome:
|  *    grephicolor-icon-theme *
|  * opkg_install_cmd: Cannot install package task-gnome.

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/classes/gtk-icon-cache.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Richard Purdie - Aug. 8, 2011, 1:11 p.m.
On Sat, 2011-08-06 at 09:25 +0200, Koen Kooi wrote:
> python += doesn't add a leading space, which we do need:
> 
> | Collected errors:
> |  * satisfy_dependencies_for: Cannot satisfy the following dependencies for task-gnome-themes:
> |  *    gnome-icon-themehicolor-icon-theme *
> |  * opkg_install_cmd: Cannot install package task-gnome-themes.
> |  * satisfy_dependencies_for: Cannot satisfy the following dependencies for task-gnome-apps:
> |  *    iso-codeshicolor-icon-theme *
> |  * opkg_install_cmd: Cannot install package task-gnome-apps.
> |  * satisfy_dependencies_for: Cannot satisfy the following dependencies for task-gnome:
> |  *    grephicolor-icon-theme *
> |  * opkg_install_cmd: Cannot install package task-gnome.
> 
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta/classes/gtk-icon-cache.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Squashed into the original commit since that hadn't merged yet and both
merged into master, thanks.

Richard

Patch

diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-icon-cache.bbclass
index 5d8ef34..3bfb8ff 100644
--- a/meta/classes/gtk-icon-cache.bbclass
+++ b/meta/classes/gtk-icon-cache.bbclass
@@ -38,7 +38,7 @@  python populate_packages_append () {
 
 		bb.note("adding hicolor-icon-theme dependency to %s" % pkg)	
 		rdepends = bb.data.getVar('RDEPENDS_%s' % pkg, d, 1)
-		rdepends += "hicolor-icon-theme"
+		rdepends += " hicolor-icon-theme"
 		bb.data.setVar('RDEPENDS_%s' % pkg, rdepends, d)
 	
 		bb.note("adding gtk-icon-cache postinst and postrm scripts to %s" % pkg)