Patchwork [V2] defaultsetup: Use .= to add TCLIBCAPPEND to TMPDIR

login
register
mail settings
Submitter Khem Raj
Date Aug. 5, 2011, 7:56 p.m.
Message ID <1312574177-20210-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/9403/
State New, archived
Headers show

Comments

Khem Raj - Aug. 5, 2011, 7:56 p.m.
From: Daniel Lazzari <dlazzari@leapfrog.com>

Lazily appending causes a bug where wrong cache is
cleared when BB_SRCREV_POLICY = "clear".

Tested with qemuarm on uclibc/eglibc in same build dir

Signed-off-by: Daniel Lazzari Jr <dlazzari@leapfrog.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/conf/distro/defaultsetup.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Richard Purdie - Aug. 10, 2011, 12:34 p.m.
On Fri, 2011-08-05 at 12:56 -0700, Khem Raj wrote:
> From: Daniel Lazzari <dlazzari@leapfrog.com>
> 
> Lazily appending causes a bug where wrong cache is
> cleared when BB_SRCREV_POLICY = "clear".
> 
> Tested with qemuarm on uclibc/eglibc in same build dir
> 
> Signed-off-by: Daniel Lazzari Jr <dlazzari@leapfrog.com>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/conf/distro/defaultsetup.conf |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Merged to master, thanks.

Richard

Patch

diff --git a/meta/conf/distro/defaultsetup.conf b/meta/conf/distro/defaultsetup.conf
index 919ed00..1a29778 100644
--- a/meta/conf/distro/defaultsetup.conf
+++ b/meta/conf/distro/defaultsetup.conf
@@ -11,7 +11,7 @@  require conf/distro/include/tclibc-${TCLIBC}.inc
 
 # Allow single libc distros to disable this code
 TCLIBCAPPEND ?= "-${TCLIBC}"
-TMPDIR_append = "${TCLIBCAPPEND}"
+TMPDIR .= "${TCLIBCAPPEND}"
 
 CACHE = "${TMPDIR}/cache/${TCMODE}-${TCLIBC}${@['', '/' + str(bb.data.getVar('MACHINE', d, 1))][bool(bb.data.getVar('MACHINE', d, 1))]}${@['', '/' + str(bb.data.getVar('SDKMACHINE', d, 1))][bool(bb.data.getVar('SDKMACHINE', d, 1))]}"