Patchwork [10/10] local.conf.sample: make BBMASK assignment weak

login
register
mail settings
Submitter Nitin A Kamble
Date Aug. 4, 2011, 3:01 p.m.
Message ID <aa5a0621a4d7110828517949f4c07221e62b068c.1312469790.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/9337/
State New, archived
Headers show

Comments

Nitin A Kamble - Aug. 4, 2011, 3:01 p.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

So that it can be overridden by layers if needed.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta-yocto/conf/local.conf.sample |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Tom Rini - Aug. 4, 2011, 10:52 p.m.
On Thu, Aug 4, 2011 at 8:01 AM,  <nitin.a.kamble@intel.com> wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
> So that it can be overridden by layers if needed.
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta-yocto/conf/local.conf.sample |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta-yocto/conf/local.conf.sample b/meta-yocto/conf/local.conf.sample
> index 3e71b0a..4acec37 100644
> --- a/meta-yocto/conf/local.conf.sample
> +++ b/meta-yocto/conf/local.conf.sample
> @@ -39,7 +39,7 @@ DISTRO ?= "poky"
>
>  # BBMASK is a regular expression that can be used to tell BitBake to ignore
>  # certain recipes.
> -BBMASK = ""
> +BBMASK ?= ""
>
>  # EXTRA_IMAGE_FEATURES allows extra packages to be added to the generated images
>  # (Some of these are automatically added to certain image types)

In oe.dev we just dropped this from local.conf iirc since a real
assignmnet was overriding a useful setting we provided.  IMHO, we
should do the same here (or at least comment it out).
Nitin A Kamble - Aug. 4, 2011, 10:54 p.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Tom Rini
> Sent: Thursday, August 04, 2011 3:53 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 10/10] local.conf.sample: make BBMASK
> assignment weak
> 
> On Thu, Aug 4, 2011 at 8:01 AM,  <nitin.a.kamble@intel.com> wrote:
> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >
> > So that it can be overridden by layers if needed.
> >
> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > ---
> >  meta-yocto/conf/local.conf.sample |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta-yocto/conf/local.conf.sample b/meta-
> yocto/conf/local.conf.sample
> > index 3e71b0a..4acec37 100644
> > --- a/meta-yocto/conf/local.conf.sample
> > +++ b/meta-yocto/conf/local.conf.sample
> > @@ -39,7 +39,7 @@ DISTRO ?= "poky"
> >
> >  # BBMASK is a regular expression that can be used to tell BitBake to
> ignore
> >  # certain recipes.
> > -BBMASK = ""
> > +BBMASK ?= ""
> >
> >  # EXTRA_IMAGE_FEATURES allows extra packages to be added to the
> generated images
> >  # (Some of these are automatically added to certain image types)
> 
> In oe.dev we just dropped this from local.conf iirc since a real
> assignmnet was overriding a useful setting we provided.  IMHO, we
> should do the same here (or at least comment it out).

I agree. We should comment it out.
> 
> --
> Tom
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie - Aug. 5, 2011, 4:07 p.m.
On Thu, 2011-08-04 at 15:54 -0700, Kamble, Nitin A wrote:
> 
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> > Tom Rini
> > Sent: Thursday, August 04, 2011 3:53 PM
> > To: Patches and discussions about the oe-core layer
> > Subject: Re: [OE-core] [PATCH 10/10] local.conf.sample: make BBMASK
> > assignment weak
> > 
> > On Thu, Aug 4, 2011 at 8:01 AM,  <nitin.a.kamble@intel.com> wrote:
> > > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> > >
> > > So that it can be overridden by layers if needed.
> > >
> > > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > > ---
> > >  meta-yocto/conf/local.conf.sample |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/meta-yocto/conf/local.conf.sample b/meta-
> > yocto/conf/local.conf.sample
> > > index 3e71b0a..4acec37 100644
> > > --- a/meta-yocto/conf/local.conf.sample
> > > +++ b/meta-yocto/conf/local.conf.sample
> > > @@ -39,7 +39,7 @@ DISTRO ?= "poky"
> > >
> > >  # BBMASK is a regular expression that can be used to tell BitBake to
> > ignore
> > >  # certain recipes.
> > > -BBMASK = ""
> > > +BBMASK ?= ""
> > >
> > >  # EXTRA_IMAGE_FEATURES allows extra packages to be added to the
> > generated images
> > >  # (Some of these are automatically added to certain image types)
> > 
> > In oe.dev we just dropped this from local.conf iirc since a real
> > assignmnet was overriding a useful setting we provided.  IMHO, we
> > should do the same here (or at least comment it out).
> 
> I agree. We should comment it out.

I agree too.

Cheers,

Richard
Richard Purdie - Aug. 5, 2011, 4:20 p.m.
On Fri, 2011-08-05 at 17:07 +0100, Richard Purdie wrote:
> On Thu, 2011-08-04 at 15:54 -0700, Kamble, Nitin A wrote:
> > 
> > > -----Original Message-----
> > > From: openembedded-core-bounces@lists.openembedded.org
> > > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> > > Tom Rini
> > > Sent: Thursday, August 04, 2011 3:53 PM
> > > To: Patches and discussions about the oe-core layer
> > > Subject: Re: [OE-core] [PATCH 10/10] local.conf.sample: make BBMASK
> > > assignment weak
> > > 
> > > On Thu, Aug 4, 2011 at 8:01 AM,  <nitin.a.kamble@intel.com> wrote:
> > > > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> > > >
> > > > So that it can be overridden by layers if needed.
> > > >
> > > > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > > > ---
> > > >  meta-yocto/conf/local.conf.sample |    2 +-
> > > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/meta-yocto/conf/local.conf.sample b/meta-
> > > yocto/conf/local.conf.sample
> > > > index 3e71b0a..4acec37 100644
> > > > --- a/meta-yocto/conf/local.conf.sample
> > > > +++ b/meta-yocto/conf/local.conf.sample
> > > > @@ -39,7 +39,7 @@ DISTRO ?= "poky"
> > > >
> > > >  # BBMASK is a regular expression that can be used to tell BitBake to
> > > ignore
> > > >  # certain recipes.
> > > > -BBMASK = ""
> > > > +BBMASK ?= ""
> > > >
> > > >  # EXTRA_IMAGE_FEATURES allows extra packages to be added to the
> > > generated images
> > > >  # (Some of these are automatically added to certain image types)
> > > 
> > > In oe.dev we just dropped this from local.conf iirc since a real
> > > assignmnet was overriding a useful setting we provided.  IMHO, we
> > > should do the same here (or at least comment it out).
> > 
> > I agree. We should comment it out.
> 
> I agree too.

To save more respin and so forth I went ahead and merged that change.

Cheers,

Richard

Patch

diff --git a/meta-yocto/conf/local.conf.sample b/meta-yocto/conf/local.conf.sample
index 3e71b0a..4acec37 100644
--- a/meta-yocto/conf/local.conf.sample
+++ b/meta-yocto/conf/local.conf.sample
@@ -39,7 +39,7 @@  DISTRO ?= "poky"
 
 # BBMASK is a regular expression that can be used to tell BitBake to ignore
 # certain recipes.
-BBMASK = ""
+BBMASK ?= ""
 
 # EXTRA_IMAGE_FEATURES allows extra packages to be added to the generated images 
 # (Some of these are automatically added to certain image types)