Patchwork [08/10] insane.bbclass: add entries for linux-gnu<ABI>

login
register
mail settings
Submitter Nitin A Kamble
Date Aug. 4, 2011, 3:01 p.m.
Message ID <6f5d9933df00c226e73afe5398613021a6a58133.1312469790.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/9333/
State New, archived
Headers show

Comments

Nitin A Kamble - Aug. 4, 2011, 3:01 p.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

for x86_64 multiple ABIs now have these new names for the TARGET_OS.
Add entries for:
 linux-gnu32, linux-gnux32, linux-gnu64

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/classes/insane.bbclass |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
Richard Purdie - Aug. 5, 2011, 4:06 p.m.
On Thu, 2011-08-04 at 08:01 -0700, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> for x86_64 multiple ABIs now have these new names for the TARGET_OS.
> Add entries for:
>  linux-gnu32, linux-gnux32, linux-gnu64
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/classes/insane.bbclass |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index 5fb0d98..15e7fc7 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -90,6 +90,15 @@ def package_qa_get_machine_dict():
>                          "microblaze":   (47787,  0,    0,          False,         32),
>                          "microblazeel": (47787,  0,    0,          True,          32),
>                        },
> +            "linux-gnu32" :       {
> +                        "x86_64":     (62,     0,    0,          True,          32),
> +                      },

This one doesn't make sense to me. linux-gnu32 would be i586 (arch=3)
and not arch=62?

> +            "linux-gnux32" :       {
> +                        "x86_64":     (62,     0,    0,          True,          32),
> +                      },

This one is fine.

> +            "linux-gnu64" :       {
> +                        "x86_64":     (62,     0,    0,          True,          64),
> +                      },
>         }

I'm not sure we need this either...

Cheers,

Richard
Nitin A Kamble - Aug. 5, 2011, 4:56 p.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Richard Purdie
> Sent: Friday, August 05, 2011 9:07 AM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 08/10] insane.bbclass: add entries for
> linux-gnu<ABI>
> 
> On Thu, 2011-08-04 at 08:01 -0700, nitin.a.kamble@intel.com wrote:
> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >
> > for x86_64 multiple ABIs now have these new names for the TARGET_OS.
> > Add entries for:
> >  linux-gnu32, linux-gnux32, linux-gnu64
> >
> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > ---
> >  meta/classes/insane.bbclass |    9 +++++++++
> >  1 files changed, 9 insertions(+), 0 deletions(-)
> >
> > diff --git a/meta/classes/insane.bbclass
> b/meta/classes/insane.bbclass
> > index 5fb0d98..15e7fc7 100644
> > --- a/meta/classes/insane.bbclass
> > +++ b/meta/classes/insane.bbclass
> > @@ -90,6 +90,15 @@ def package_qa_get_machine_dict():
> >                          "microblaze":   (47787,  0,    0,
> False,         32),
> >                          "microblazeel": (47787,  0,    0,
> True,          32),
> >                        },
> > +            "linux-gnu32" :       {
> > +                        "x86_64":     (62,     0,    0,
> True,          32),
> > +                      },
> 
> This one doesn't make sense to me. linux-gnu32 would be i586 (arch=3)
> and not arch=62?
> 
> > +            "linux-gnux32" :       {
> > +                        "x86_64":     (62,     0,    0,
> True,          32),
> > +                      },
> 
> This one is fine.
> 
> > +            "linux-gnu64" :       {
> > +                        "x86_64":     (62,     0,    0,
> True,          64),
> > +                      },
> >         }
> 
> I'm not sure we need this either...

If the ABIEXTENTION is taken out for m32 & m64 tunes, then these are not needed. So I will take them out.
Thanks,
Nitin

> 
> Cheers,
> 
> Richard
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 5fb0d98..15e7fc7 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -90,6 +90,15 @@  def package_qa_get_machine_dict():
                         "microblaze":   (47787,  0,    0,          False,         32),
                         "microblazeel": (47787,  0,    0,          True,          32),
                       },
+            "linux-gnu32" :       {
+                        "x86_64":     (62,     0,    0,          True,          32),
+                      },
+            "linux-gnux32" :       {
+                        "x86_64":     (62,     0,    0,          True,          32),
+                      },
+            "linux-gnu64" :       {
+                        "x86_64":     (62,     0,    0,          True,          64),
+                      },
        }