Patchwork [06/10] kernel, module-base.bbclass: fix KERNEL_LD & KERNEL_AR vars

login
register
mail settings
Submitter Nitin A Kamble
Date Aug. 4, 2011, 3:01 p.m.
Message ID <e4f4b9c5a4b28f252e30c4b92cdfc3c624bc22e5.1312469790.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/9329/
State New, archived
Headers show

Comments

Nitin A Kamble - Aug. 4, 2011, 3:01 p.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

KERNEL_LD was using ${LD} in it's definition, which is not correct for
Phil Blundell - Aug. 4, 2011, 9:50 p.m.
On Thu, 2011-08-04 at 08:01 -0700, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> KERNEL_LD was using ${LD} in it's definition, which is not correct for
> different ABIs such as x32 or i386 on x86_64 machine.
> 
> Same with KERNEL_AR var.

Why is ar an issue?  That doesn't have any unusual args, does it?

p.
Nitin A Kamble - Aug. 4, 2011, 10:03 p.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Phil Blundell
> Sent: Thursday, August 04, 2011 2:50 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 06/10] kernel, module-base.bbclass: fix
> KERNEL_LD & KERNEL_AR vars
> 
> On Thu, 2011-08-04 at 08:01 -0700, nitin.a.kamble@intel.com wrote:
> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >
> > KERNEL_LD was using ${LD} in it's definition, which is not correct
> for
> > different ABIs such as x32 or i386 on x86_64 machine.
> >
> > Same with KERNEL_AR var.
> 
> Why is ar an issue?  That doesn't have any unusual args, does it?
> 
> p.

No special args for ar, but The change makes definition of KERNEL_AR consistent with other definitions like KERNEL_CC & KERNEL_LD.

Nitin
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Phil Blundell - Aug. 5, 2011, 7:52 a.m.
On Thu, 2011-08-04 at 15:03 -0700, Kamble, Nitin A wrote:
> 
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> > Phil Blundell
> > Sent: Thursday, August 04, 2011 2:50 PM
> > To: Patches and discussions about the oe-core layer
> > Subject: Re: [OE-core] [PATCH 06/10] kernel, module-base.bbclass: fix
> > KERNEL_LD & KERNEL_AR vars
> > 
> > On Thu, 2011-08-04 at 08:01 -0700, nitin.a.kamble@intel.com wrote:
> > > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> > >
> > > KERNEL_LD was using ${LD} in it's definition, which is not correct
> > for
> > > different ABIs such as x32 or i386 on x86_64 machine.
> > >
> > > Same with KERNEL_AR var.
> > 
> > Why is ar an issue?  That doesn't have any unusual args, does it?
> > 
> > p.
> 
> No special args for ar, but The change makes definition of KERNEL_AR consistent with other definitions like KERNEL_CC & KERNEL_LD.

Okay, fair enough.  Please say that in the checkin message, though.  The
existing text makes it sound as though KERNEL_AR was actually broken
before.

p.
Nitin A Kamble - Aug. 5, 2011, 3:41 p.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Phil Blundell
> Sent: Friday, August 05, 2011 12:52 AM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 06/10] kernel, module-base.bbclass: fix
> KERNEL_LD & KERNEL_AR vars
> 
> On Thu, 2011-08-04 at 15:03 -0700, Kamble, Nitin A wrote:
> >
> > > -----Original Message-----
> > > From: openembedded-core-bounces@lists.openembedded.org
> > > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> Of
> > > Phil Blundell
> > > Sent: Thursday, August 04, 2011 2:50 PM
> > > To: Patches and discussions about the oe-core layer
> > > Subject: Re: [OE-core] [PATCH 06/10] kernel, module-base.bbclass:
> fix
> > > KERNEL_LD & KERNEL_AR vars
> > >
> > > On Thu, 2011-08-04 at 08:01 -0700, nitin.a.kamble@intel.com wrote:
> > > > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> > > >
> > > > KERNEL_LD was using ${LD} in it's definition, which is not
> correct
> > > for
> > > > different ABIs such as x32 or i386 on x86_64 machine.
> > > >
> > > > Same with KERNEL_AR var.
> > >
> > > Why is ar an issue?  That doesn't have any unusual args, does it?
> > >
> > > p.
> >
> > No special args for ar, but The change makes definition of KERNEL_AR
> consistent with other definitions like KERNEL_CC & KERNEL_LD.
> 
> Okay, fair enough.  Please say that in the checkin message, though.
> The
> existing text makes it sound as though KERNEL_AR was actually broken
> before.
> 
Point noted, Changed the commit message.

Nitin

> p.
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie - Aug. 5, 2011, 4:16 p.m.
On Fri, 2011-08-05 at 08:41 -0700, Kamble, Nitin A wrote:
> 
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> > Phil Blundell
> > Sent: Friday, August 05, 2011 12:52 AM
> > To: Patches and discussions about the oe-core layer
> > Subject: Re: [OE-core] [PATCH 06/10] kernel, module-base.bbclass: fix
> > KERNEL_LD & KERNEL_AR vars
> > 
> > On Thu, 2011-08-04 at 15:03 -0700, Kamble, Nitin A wrote:
> > >
> > > > -----Original Message-----
> > > > From: openembedded-core-bounces@lists.openembedded.org
> > > > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> > Of
> > > > Phil Blundell
> > > > Sent: Thursday, August 04, 2011 2:50 PM
> > > > To: Patches and discussions about the oe-core layer
> > > > Subject: Re: [OE-core] [PATCH 06/10] kernel, module-base.bbclass:
> > fix
> > > > KERNEL_LD & KERNEL_AR vars
> > > >
> > > > On Thu, 2011-08-04 at 08:01 -0700, nitin.a.kamble@intel.com wrote:
> > > > > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> > > > >
> > > > > KERNEL_LD was using ${LD} in it's definition, which is not
> > correct
> > > > for
> > > > > different ABIs such as x32 or i386 on x86_64 machine.
> > > > >
> > > > > Same with KERNEL_AR var.
> > > >
> > > > Why is ar an issue?  That doesn't have any unusual args, does it?
> > > >
> > > > p.
> > >
> > > No special args for ar, but The change makes definition of KERNEL_AR
> > consistent with other definitions like KERNEL_CC & KERNEL_LD.
> > 
> > Okay, fair enough.  Please say that in the checkin message, though.
> > The
> > existing text makes it sound as though KERNEL_AR was actually broken
> > before.
>  
> Point noted, Changed the commit message.

I've merged this with an updated commit message.

Cheers,

Richard

Patch

different ABIs such as x32 or i386 on x86_64 machine.

Same with KERNEL_AR var.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/classes/kernel.bbclass      |    2 +-
 meta/classes/module-base.bbclass |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index f2f05b1..7dc9cc6 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -47,7 +47,7 @@  TARGET_LD_KERNEL_ARCH ?= ""
 HOST_LD_KERNEL_ARCH ?= "${TARGET_LD_KERNEL_ARCH}"
 
 KERNEL_CC = "${CCACHE}${HOST_PREFIX}gcc${KERNEL_CCSUFFIX} ${HOST_CC_KERNEL_ARCH}${TOOLCHAIN_OPTIONS}"
-KERNEL_LD = "${LD}${KERNEL_LDSUFFIX} ${HOST_LD_KERNEL_ARCH}${TOOLCHAIN_OPTIONS}"
+KERNEL_LD = "${HOST_PREFIX}ld${KERNEL_LDSUFFIX} ${HOST_LD_KERNEL_ARCH}${TOOLCHAIN_OPTIONS}"
 
 # Where built kernel lies in the kernel tree
 KERNEL_OUTPUT ?= "arch/${ARCH}/boot/${KERNEL_IMAGETYPE}"
diff --git a/meta/classes/module-base.bbclass b/meta/classes/module-base.bbclass
index 1a39cc1..9379bf8 100644
--- a/meta/classes/module-base.bbclass
+++ b/meta/classes/module-base.bbclass
@@ -21,8 +21,8 @@  TARGET_AR_KERNEL_ARCH ?= ""
 HOST_AR_KERNEL_ARCH ?= "${TARGET_AR_KERNEL_ARCH}"
 
 KERNEL_CC = "${CCACHE}${HOST_PREFIX}gcc${KERNEL_CCSUFFIX} ${HOST_CC_KERNEL_ARCH}"
-KERNEL_LD = "${LD}${KERNEL_LDSUFFIX} ${HOST_LD_KERNEL_ARCH}"
-KERNEL_AR = "${AR}${KERNEL_ARSUFFIX} ${HOST_AR_KERNEL_ARCH}"
+KERNEL_LD = "${HOST_PREFIX}ld${KERNEL_LDSUFFIX} ${HOST_LD_KERNEL_ARCH}"
+KERNEL_AR = "${HOST_PREFIX}ar${KERNEL_ARSUFFIX} ${HOST_AR_KERNEL_ARCH}"
 
 # kernel modules are generally machine specific
 PACKAGE_ARCH = "${MACHINE_ARCH}"