Patchwork [CONSOLIDATED,PULL,v2,18/33] xserver-nodm-init: Fix X start failure on some platform

login
register
mail settings
Submitter Saul Wold
Date Aug. 3, 2011, 10:11 p.m.
Message ID <e95f69f3e67bc1140a8eb76f8caee6c1e7b14c7f.1312407628.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/9245/
State New, archived
Headers show

Comments

Saul Wold - Aug. 3, 2011, 10:11 p.m.
From: Zhai Edwin <edwin.zhai@intel.com>

sudo is used to run rootless X in xserver-nodm, and start to fail with
"xf86OpenConsole: Cannot open /dev/tty0" error after upgrade to 1.8.1. sudo
seems wait for some resource that is unavailable in early phase of booting.
This patch swith to "su" for rootless X starting as a fix.

[YOCTO #1211] got fixed

Signed-off-by: Zhai Edwin <edwin.zhai@intel.com>
---
 .../x11-common/xserver-nodm-init/xserver-nodm      |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

Patch

diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm b/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
index d8c4ba0..3b71983 100755
--- a/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
+++ b/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
@@ -35,10 +35,8 @@  case "$1" in
            chmod g+r /dev/tty[0-3]
            chmod o+rw /dev/input/*
        fi
-       # Using sudo -i here has the nice side effect of making sire
-       # HOME, USER and other previously problematic variables
-       # are set correctly
-       sudo -b -i -u $username /etc/X11/Xserver
+       # Using su rather than sudo as latest 1.8.1 cause failure [YOCTO #1211]
+       su -l -c '/etc/X11/Xserver&' $username 
        # Wait for the desktop to say its finished loading
        dbus-wait org.matchbox_project.desktop Loaded
   ;;