Patchwork [v2] image-mklibs.bbclass: Add powerpc64 arch support

login
register
mail settings
Submitter Kumar Gala
Date Aug. 3, 2011, 5:27 a.m.
Message ID <1312349222-27254-1-git-send-email-galak@kernel.crashing.org>
Download mbox | patch
Permalink /patch/9093/
State New, archived
Headers show

Comments

Kumar Gala - Aug. 3, 2011, 5:27 a.m.
powerp64 dynamic loader is 'ld64.so.1'.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
* Use correct name of ppc64 dynamic loader
* user ${baselib} so if we are /lib or /lib64 things work

 meta/classes/image-mklibs.bbclass |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Richard Purdie - Aug. 3, 2011, 4:53 p.m.
On Wed, 2011-08-03 at 00:27 -0500, Kumar Gala wrote:
> powerp64 dynamic loader is 'ld64.so.1'.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> * Use correct name of ppc64 dynamic loader
> * user ${baselib} so if we are /lib or /lib64 things work
> 
>  meta/classes/image-mklibs.bbclass |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/classes/image-mklibs.bbclass b/meta/classes/image-mklibs.bbclass
> index 9f5a4ea..83f609c 100644
> --- a/meta/classes/image-mklibs.bbclass
> +++ b/meta/classes/image-mklibs.bbclass
> @@ -19,6 +19,9 @@ mklibs_optimize_image_doit() {
>  		powerpc | mips | microblaze )
>  			dynamic_loader="/lib/ld.so.1"
>  			;;
> +		powerpc64)
> +			dynamic_loader="/${baselib}/ld64.so.1"
> +			;;
>  		x86_64)
>  			dynamic_loader="/lib/ld-linux-x86-64.so.2"
>  			;;

Can we use ${base_libdir} there please?

${baselib} is really intended only for use to build the other
expressions.

We should probably use ${base_libdir} elsewhere in this file too. I also
suspect prelinking of a multilib image may need work :/.

Cheers,

Richard
Kumar Gala - Aug. 4, 2011, 4:03 a.m.
On Aug 3, 2011, at 11:53 AM, Richard Purdie wrote:

> On Wed, 2011-08-03 at 00:27 -0500, Kumar Gala wrote:
>> powerp64 dynamic loader is 'ld64.so.1'.
>> 
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>> * Use correct name of ppc64 dynamic loader
>> * user ${baselib} so if we are /lib or /lib64 things work
>> 
>> meta/classes/image-mklibs.bbclass |    3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>> 
>> diff --git a/meta/classes/image-mklibs.bbclass b/meta/classes/image-mklibs.bbclass
>> index 9f5a4ea..83f609c 100644
>> --- a/meta/classes/image-mklibs.bbclass
>> +++ b/meta/classes/image-mklibs.bbclass
>> @@ -19,6 +19,9 @@ mklibs_optimize_image_doit() {
>> 		powerpc | mips | microblaze )
>> 			dynamic_loader="/lib/ld.so.1"
>> 			;;
>> +		powerpc64)
>> +			dynamic_loader="/${baselib}/ld64.so.1"
>> +			;;
>> 		x86_64)
>> 			dynamic_loader="/lib/ld-linux-x86-64.so.2"
>> 			;;
> 
> Can we use ${base_libdir} there please?
> 
> ${baselib} is really intended only for use to build the other
> expressions.
> 
> We should probably use ${base_libdir} elsewhere in this file too. I also
> suspect prelinking of a multilib image may need work :/.

Sent a fixed patch for powerpc64 and a new patch to change everyone else.

- k

Patch

diff --git a/meta/classes/image-mklibs.bbclass b/meta/classes/image-mklibs.bbclass
index 9f5a4ea..83f609c 100644
--- a/meta/classes/image-mklibs.bbclass
+++ b/meta/classes/image-mklibs.bbclass
@@ -19,6 +19,9 @@  mklibs_optimize_image_doit() {
 		powerpc | mips | microblaze )
 			dynamic_loader="/lib/ld.so.1"
 			;;
+		powerpc64)
+			dynamic_loader="/${baselib}/ld64.so.1"
+			;;
 		x86_64)
 			dynamic_loader="/lib/ld-linux-x86-64.so.2"
 			;;